File Opening problem
-
Hi, i have a variable str in which i have file name with complete folder path char str[100]; --- ----- --------code --- final str will have a value C:/folder/folder/file.txt then i have used ShellExecute(NULL, "open", "str" ,NULL, NULL, SW_SHOWNORMAL); but this statment has no effect its not opening the file. i checked with example ShellExecute(NULL, "open", "D:/folder/folder/file.txt" ,NULL, NULL, SW_SHOWNORMAL); this code opens the file,can any one tell why the file is not opening in the first case... do we have to convert char array to CString then pass it to ShellExecute ??? Regards, Vinay Charan.
vinaycool wrote:
ShellExecute(NULL, "open", "str" ,NULL, NULL, SW_SHOWNORMAL);
Use this instead:
ShellExecute(NULL, "open", str, NULL, NULL, SW_SHOWNORMAL);Note I removed the quotes. Steve PS: Why use acharat all? You can replace the "str" variable with theCStringvariable and it will work, be simpler and also safer. -
vinaycool wrote:
ShellExecute(NULL, "open", "str" ,NULL, NULL, SW_SHOWNORMAL);
Use this instead:
ShellExecute(NULL, "open", str, NULL, NULL, SW_SHOWNORMAL);Note I removed the quotes. Steve PS: Why use acharat all? You can replace the "str" variable with theCStringvariable and it will work, be simpler and also safer.Hi Stephen Hewitt, I have checked with this code ShellExecute(NULL, "open", str ,NULL, NULL, SW_SHOWNORMAL); no effect ,its not opening the file .... since i get the file name input as c:\folder\folder\file.ext i have used 2 sting array to convert it to c:/folder/folder/file.ext now i have to change char to CString ????
-
Hi, i have a variable str in which i have file name with complete folder path char str[100]; --- ----- --------code --- final str will have a value C:/folder/folder/file.txt then i have used ShellExecute(NULL, "open", "str" ,NULL, NULL, SW_SHOWNORMAL); but this statment has no effect its not opening the file. i checked with example ShellExecute(NULL, "open", "D:/folder/folder/file.txt" ,NULL, NULL, SW_SHOWNORMAL); this code opens the file,can any one tell why the file is not opening in the first case... do we have to convert char array to CString then pass it to ShellExecute ??? Regards, Vinay Charan.
its work
CString str="c:\\test.txt"; ShellExecute(NULL, "open",str ,NULL, NULL, SW_SHOWNORMAL); ------------------------------- char str3[100]; str3[0]='\0'; strcat(str3,"c:\\test.txt"); ShellExecute(NULL, "open",str3 ,NULL, NULL, SW_SHOWNORMAL);_**
**_
whitesky
-
its work
CString str="c:\\test.txt"; ShellExecute(NULL, "open",str ,NULL, NULL, SW_SHOWNORMAL); ------------------------------- char str3[100]; str3[0]='\0'; strcat(str3,"c:\\test.txt"); ShellExecute(NULL, "open",str3 ,NULL, NULL, SW_SHOWNORMAL);_**
**_
whitesky
Don't use
strcat: this is C++ not C! If you want to concatenate do it like this:CString str = "C:\\"; str += "test.txt"; // This is how you do it! ShellExecute(NULL, "open", str, NULL, NULL, SW_SHOWNORMAL);Steve -
vinaycool wrote:
ShellExecute(NULL, "open", "str" ,NULL, NULL, SW_SHOWNORMAL);
Use this instead:
ShellExecute(NULL, "open", str, NULL, NULL, SW_SHOWNORMAL);Note I removed the quotes. Steve PS: Why use acharat all? You can replace the "str" variable with theCStringvariable and it will work, be simpler and also safer.Hi Stephen one question how to use modify button!?it seems dosent work for me_**
**_
whitesky
-
its work
CString str="c:\\test.txt"; ShellExecute(NULL, "open",str ,NULL, NULL, SW_SHOWNORMAL); ------------------------------- char str3[100]; str3[0]='\0'; strcat(str3,"c:\\test.txt"); ShellExecute(NULL, "open",str3 ,NULL, NULL, SW_SHOWNORMAL);_**
**_
whitesky
Hi WhiteSky, below is the function which i have used can u please what the error in it
void CSearchDlg::OnDblclkSout() { // TODO: Add your control notification handler code here // Code to open the selected file. int d; d=m_SOUT.GetCurSel(); CString FName; m_SOUT.GetText(d,FName); char str[100]; int i,l,k,j,m; strcpy(str, FName); for (i=0;str[i]!='\0';i++) { if (str[i]=='\\') { l=i; k=0; char str1[100]; if (str[l+1]=='\0') { str[l]='/'; } else { for (j=l+1;str[j]!='\0';j++) { str1[k]=str[j]; k++; } str1[k]='\0'; str[l]='/'; for (m=0;str1[m]!='\0';m++) { str[++l]=str1[m]; } } str[++l]='\0'; i=i++; } } m_ctrlEDIT.SetWindowText(str); ShellExecute(NULL, "open", str ,NULL, NULL, SW_SHOWNORMAL); } -
Hi Stephen one question how to use modify button!?it seems dosent work for me_**
**_
whitesky
I just press it and it works; sorry I can't be of more help. Steve
-
Hi WhiteSky, below is the function which i have used can u please what the error in it
void CSearchDlg::OnDblclkSout() { // TODO: Add your control notification handler code here // Code to open the selected file. int d; d=m_SOUT.GetCurSel(); CString FName; m_SOUT.GetText(d,FName); char str[100]; int i,l,k,j,m; strcpy(str, FName); for (i=0;str[i]!='\0';i++) { if (str[i]=='\\') { l=i; k=0; char str1[100]; if (str[l+1]=='\0') { str[l]='/'; } else { for (j=l+1;str[j]!='\0';j++) { str1[k]=str[j]; k++; } str1[k]='\0'; str[l]='/'; for (m=0;str1[m]!='\0';m++) { str[++l]=str1[m]; } } str[++l]='\0'; i=i++; } } m_ctrlEDIT.SetWindowText(str); ShellExecute(NULL, "open", str ,NULL, NULL, SW_SHOWNORMAL); }I can't follow code without formatting. Click the ignore HTML tags checkbox when you enter a message so we can see the formatting. Also give the types of all variables referred to. e.g. The type of the "m_SOUT" variable. Steve
-
Don't use
strcat: this is C++ not C! If you want to concatenate do it like this:CString str = "C:\\"; str += "test.txt"; // This is how you do it! ShellExecute(NULL, "open", str, NULL, NULL, SW_SHOWNORMAL);Stevei know strcat it was for str3[100]; not cstring:)_**
**_
whitesky
-
I can't follow code without formatting. Click the ignore HTML tags checkbox when you enter a message so we can see the formatting. Also give the types of all variables referred to. e.g. The type of the "m_SOUT" variable. Steve
Hi Stephen Hewitt, In list box i have items like C:\folder\folder\filename1.txt C:\folder\folder\filename2.txt C:\folder\folder\filename3.txt C:\folder\folder\filename4.txt since by default i get the file name as c:\folder\folder\file.txt i have char array to change it to c:/folder/folder/file.txt final value of str will have C:/Folder/Folder/filename.txt below code i have used to open void CSearchDlg::OnDblclkSout() { // Code to open the selected file. int d; d=m_SOUT.GetCurSel(); CString FName; m_SOUT.GetText(d,FName); char str[100]; int i,l,k,j,m; strcpy(str, FName); for (i=0;str[i]!='\0';i++) { if (str[i]=='\\') { l=i; k=0; char str1[100]; if (str[l+1]=='\0') { str[l]='/'; } else { for (j=l+1;str[j]!='\0';j++) { str1[k]=str[j]; k++; } str1[k]='\0'; str[l]='/'; for (m=0;str1[m]!='\0';m++) { str[++l]=str1[m]; } } str[++l]='\0'; i=i++; } } m_ctrlEDIT.SetWindowText(str); ShellExecute(NULL, "open", str ,NULL, NULL, SW_SHOWNORMAL); }
-
Hi WhiteSky, below is the function which i have used can u please what the error in it
void CSearchDlg::OnDblclkSout() { // TODO: Add your control notification handler code here // Code to open the selected file. int d; d=m_SOUT.GetCurSel(); CString FName; m_SOUT.GetText(d,FName); char str[100]; int i,l,k,j,m; strcpy(str, FName); for (i=0;str[i]!='\0';i++) { if (str[i]=='\\') { l=i; k=0; char str1[100]; if (str[l+1]=='\0') { str[l]='/'; } else { for (j=l+1;str[j]!='\0';j++) { str1[k]=str[j]; k++; } str1[k]='\0'; str[l]='/'; for (m=0;str1[m]!='\0';m++) { str[++l]=str1[m]; } } str[++l]='\0'; i=i++; } } m_ctrlEDIT.SetWindowText(str); ShellExecute(NULL, "open", str ,NULL, NULL, SW_SHOWNORMAL); }your code now open one text file
void CssDlg::OnBnClickedMybutton() { // TODO: Add your control notification handler code here // Code to open the selected file. int d; //d=m_SOUT.GetCurSel();//listbox CString FName; FName="c:\\code.txt"; //m_SOUT.GetText(d,FName); //one function from listbox char str[100]; int i,l,k,j,m; strcpy(str, FName); for (i=0;str[i]!='\0';i++) { if (str[i]=='\\') { l=i; k=0; char str1[100]; if (str[l+1]=='\0') { str[l]='/'; } else { for (j=l+1;str[j]!='\0';j++) { str1[k]=str[j]; k++; } str1[k]='\0'; str[l]='/'; for (m=0;str1[m]!='\0';m++) { str[++l]=str1[m]; } } str[++l]='\0'; i=i++; } } /*m_ctrlEDIT*/m_Edit1.SetWindowText(str);//maybe editbox ShellExecute(NULL, "open", str ,NULL, NULL, SW_SHOWNORMAL); }_**
**_
whitesky
-
I just press it and it works; sorry I can't be of more help. Steve
Vinay wrote:
one question how to use modify button!?it seems dosent work for me
What a lazy guy.:| Yesterday asked for same. Knock out 't' from can't, You can if you think you can :cool:
-
I just press it and it works; sorry I can't be of more help. Steve
thank you for information i know i cant use modify about 3 days ago :)_**
**_
whitesky
-
Vinay wrote:
one question how to use modify button!?it seems dosent work for me
What a lazy guy.:| Yesterday asked for same. Knock out 't' from can't, You can if you think you can :cool:
-
your code now open one text file
void CssDlg::OnBnClickedMybutton() { // TODO: Add your control notification handler code here // Code to open the selected file. int d; //d=m_SOUT.GetCurSel();//listbox CString FName; FName="c:\\code.txt"; //m_SOUT.GetText(d,FName); //one function from listbox char str[100]; int i,l,k,j,m; strcpy(str, FName); for (i=0;str[i]!='\0';i++) { if (str[i]=='\\') { l=i; k=0; char str1[100]; if (str[l+1]=='\0') { str[l]='/'; } else { for (j=l+1;str[j]!='\0';j++) { str1[k]=str[j]; k++; } str1[k]='\0'; str[l]='/'; for (m=0;str1[m]!='\0';m++) { str[++l]=str1[m]; } } str[++l]='\0'; i=i++; } } /*m_ctrlEDIT*/m_Edit1.SetWindowText(str);//maybe editbox ShellExecute(NULL, "open", str ,NULL, NULL, SW_SHOWNORMAL); }_**
**_
whitesky
-
Hi WhiteSky, The code will open only 1 file by default, how can we do it dynamically ??is there any solution for this problem..please let me know...
yes this code open only one file(text) because i dont know that you how to get files and paths, this code work for one file so maybe your path is wrong your files_**
**_
whitesky
-
yes this code open only one file(text) because i dont know that you how to get files and paths, this code work for one file so maybe your path is wrong your files_**
**_
whitesky
Hi WhiteSky, ShellExecute(NULL, "open", str ,NULL, NULL, SW_SHOWNORMAL); here i am passing str is of char str[100]; is this can be problem ??? have to change char array to CString ??? if i convert it will work ?? can u please tell me how to change char array to CString .. char str[100]; CString Name;
-
Hi WhiteSky, ShellExecute(NULL, "open", str ,NULL, NULL, SW_SHOWNORMAL); here i am passing str is of char str[100]; is this can be problem ??? have to change char array to CString ??? if i convert it will work ?? can u please tell me how to change char array to CString .. char str[100]; CString Name;
I write your code and it work. I am not understanding your question what do you need you said this code will open only one file but i need to run dynamically for another files now you said is this problem(str[100]) if this code will work so you need to trace your code can you explain exactly: 1-you can use ShellExecute or no 2-you need to change char array to CString or no if yes why 3-your code has problem or no 4-how to get files and paths 5-can you use from debugger(F9 and F5)for show str value 6-whats the meaning of change array to cstring 7-in your code you use from one loop why_**
**_
whitesky
-
I write your code and it work. I am not understanding your question what do you need you said this code will open only one file but i need to run dynamically for another files now you said is this problem(str[100]) if this code will work so you need to trace your code can you explain exactly: 1-you can use ShellExecute or no 2-you need to change char array to CString or no if yes why 3-your code has problem or no 4-how to get files and paths 5-can you use from debugger(F9 and F5)for show str value 6-whats the meaning of change array to cstring 7-in your code you use from one loop why_**
**_
whitesky
Hi WhiteSky, The exact problem is in the list box i have list of file names with there complete path. file names are added by other function which is adding correctly ex C:\Box01\00000304\00000034.txt C:\Box01\00000304\00000035.txt C:\Box01\00000304\00000036.txt C:\Box01\00000304\00000037.txt etc... since i am using ShellExecute as it takes only file name like C:/Box01/00000304/00000037.txt i have used char array & changed the \ to / i am using this stament just as a check point to find what data str has m_ctrlEDIT.SetWindowText(str); in the str i get the data as C:\Box01\00000304\00000037.txt i also ued F5 and cheked str has proper data.. but still the file is not opening ...please tell me waht will be possible cause..
-
Hi WhiteSky, The exact problem is in the list box i have list of file names with there complete path. file names are added by other function which is adding correctly ex C:\Box01\00000304\00000034.txt C:\Box01\00000304\00000035.txt C:\Box01\00000304\00000036.txt C:\Box01\00000304\00000037.txt etc... since i am using ShellExecute as it takes only file name like C:/Box01/00000304/00000037.txt i have used char array & changed the \ to / i am using this stament just as a check point to find what data str has m_ctrlEDIT.SetWindowText(str); in the str i get the data as C:\Box01\00000304\00000037.txt i also ued F5 and cheked str has proper data.. but still the file is not opening ...please tell me waht will be possible cause..
C:\Box01\00000304\00000034.txt it seems not problem of course if is valid and i think if you use like this it work you can use CString instead char[100] and if these paths and files are valid so i think you can use ShellExecute that it should open notepad (I guess I'm not sure maybe your string concat to previous string for example you have c:\\1.txt then you want to open another file then c:\\1.txtc:\\2.txt Did you check for this case)_**
**_
whitesky