insert syntax problem, pls help....

[kyosugi]

posted b4 but i cant seem to find the old thread n i need help urgently >.< tis is the code i tried to use --------- Private Sub AddSubmitB_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles AddSubmitB.Click Dim strcon As String = "Provider=Microsoft.Jet.OLEDB.4.0;Data Source=C:\Documents and Settings\Jasmine\db.mdb" Dim cmd As New OleDb.OleDbCommand Dim con As OleDb.OleDbConnection Dim strsql As String con = New OleDb.OleDbConnection(strcon) con.Open() strsql = "Insert into member (BorrowerId, password, MemberType, Fname, Lname, Gender, Address1, Address2, Address3, ContactNo, HandPhNo, Email, CourseOfStudy, EnrolledDate, ExpiryDate) values ('" & StudIdTB.Text & "','" & StudPwTB.Text & "','" & UgTB.Text & "','" & StudFnTB.Text & "','" & StudLnTB.Text & "','" & StudGenderCLB.Text & "','" & StudAdd1TB.Text & "','" & StudAdd2TB.Text & "','" & StudAdd3TB.Text & "','" & StudHmTB.Text & "','" & StudHpTB.Text & "','" & StudMailTB.Text & "','" & CosCB.Text & "','" & EnrolledCB.Text & "','" & ExpiryCB.Text & "')" cmd.Connection = con cmd.CommandText = strsql cmd.ExecuteNonQuery() con.Close() MsgBox("New Member Added!") Me.Close() End Sub --------- when i tested it today, it did not work the debugger stopped at cmd.ExecuteNonQuery it says OleDbException was unhandled Syntax error in INSERT INTO statement. i checked thru my database and the sql statements n r fine, oso tried adding square brackets how to solve?

[Nouvand]

Have you check the concurency?

[Dave Kreskowiak]

Your old post is here[^], along with my reply to it.

Dave Kreskowiak Microsoft MVP - Visual Basic

[kyosugi]

opps, thx mus haf posted help at too many forums, missed out, haha

[Stephen McGuire]

You have single quotes inside your double quotes. You should only include these for 'string' values. Numbers should not have single quotes. Additionally, 'Date' fields may need octothorpes (#) instead of single quotes. Your commands are setup a little inefficiently. You should only keep a connection open for the shortest time possible. Do everything else first, then open the connection just before you execute your command, then close immediately. Try this: Private Sub AddSubmitB_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles AddSubmitB.Click Dim strcon As String = "Provider=Microsoft.Jet.OLEDB.4.0;Data Source=C:\Documents and Settings\Jasmine\db.mdb" Dim con As OleDb.OleDbConnection con = New OleDb.OleDbConnection(strcon) Dim cmd As New OleDb.OleDbCommand cmd.Connection = con Dim strsql As String strsql = "Insert into member (BorrowerId, password, MemberType, Fname, Lname, Gender, Address1, Address2, Address3, ContactNo, HandPhNo, Email, CourseOfStudy, EnrolledDate, ExpiryDate) values ('" & StudIdTB.Text & "','" & StudPwTB.Text & "','" & UgTB.Text & "','" & StudFnTB.Text & "','" & StudLnTB.Text & "','" & StudGenderCLB.Text & "','" & StudAdd1TB.Text & "','" & StudAdd2TB.Text & "','" & StudAdd3TB.Text & "','" & StudHmTB.Text & "','" & StudHpTB.Text & "','" & StudMailTB.Text & "','" & CosCB.Text & "','" & EnrolledCB.Text & "','" & ExpiryCB.Text & "')" cmd.CommandText = strsql con.Open() cmd.ExecuteNonQuery() con.Close() MsgBox("New Member Added!") Me.Close() End Sub I haven't changed any of strsql because you seem to think the query is ok. Only you would know that. Check the single quotes etc are legal.. For queries containing this many fields, you should be using parameter queries. Once you get used to them, you will use them all the time. They are much easier to read and you can check/set data types as you go. Steve