Question about CSV file [modified]

[TeiUKei]

I gt a line of data which i intend to display in CSV file as below, "A12435625" "b" "b2" "c44566" "A12435625" "b" "b2" "c44566" however with my coding, it only displayed as "A12435625" "b" "b2" "c44566" "A12435625" "b" "b2" "c44566" What is my mistake and how to display my desire answer? Below is my coding, pls kindly help! FileOpen(2, sFilename, OpenMode.Output) For b = 0 To CreatePP.Counter - 1 For a = 0 To 4 c = CStr(CreatePP.Data(a)) If c.Length <= 1 Then c = c.PadRight(2, CChar(" ")) ElseIf c.Length <= 2 Then c = c.PadRight(3, CChar(" ")) ElseIf c.Length > 2 And c.Length <= 4 Then c = c.PadRight(5, CChar(" ")) ElseIf c.Length > 4 And c.Length <= 6 Then c = c.PadRight(7, CChar(" ")) ElseIf c.Length > 6 And c.Length <= 11 Then c = c.PadRight(12, CChar(" ")) End If Write(2, c) Next a Next b FileClose(2) -- modified at 0:27 Thursday 12th October, 2006

[Dave Sexton]

I think if you add either vbCrLf or ControlChars.NewLine to where you want the string to be written on a new line that may work.

[TeiUKei]

Thanx for help although it didn't work. As a result,it ony return "aaaaaaaa",blank line,"b",blank line,"b2". Do you have another tricks or idea?

[Dave Kreskowiak]

We need to see your code so we can figure out what you did wrong.

Dave Kreskowiak Microsoft MVP - Visual Basic

[TeiUKei]

It is almost the same,i highlighted the change the below. I gt a line of data which i intend to display in CSV file as below, "A12435625" "b" "b2" "c44566" "A12435625" "b" "b2" "c44566" however with my coding, it only displayed as "A12435625" "b" "b2" "c44566" "A12435625" "b" "b2" "c44566" What is my mistake and how to display my desire answer? Below is my coding, pls kindly help! FileOpen(2, sFilename, OpenMode.Output) For b = 0 To CreatePP.Counter - 1 For a = 0 To 4 c = CStr(CreatePP.Data(a)) If c.Length <= 1 Then c = c.PadRight(2, CChar(" ")) ElseIf c.Length <= 2 Then c = c.PadRight(3, CChar(" ")) ElseIf c.Length > 2 And c.Length <= 4 Then c = c.PadRight(5, CChar(" ")) ElseIf c.Length > 4 And c.Length <= 6 Then c = c.PadRight(7, CChar(" ")) ElseIf c.Length > 6 And c.Length <= 11 Then c = c.PadRight(12, CChar(" ")) End If Write(2, c) Write(2,c,ControlChars.Newline) Next a Next b FileClose(2) I appreciate so much for help!Thanx!

[Dave Kreskowiak]

First, copy and paste your ACTUAL code, not something that's "alomst the same". I very small difference in your code can make all the difference in your output. Next, don't use ControlChars.NewLine. If you want a complete new line, which is TWO characters in Windows (CR and LF), use Environment.NewLine instead.

TeiUKei wrote:

If c.Length <= 1 Then c = c.PadRight(2, CChar(" ")) ElseIf c.Length <= 2 Then c = c.PadRight(3, CChar(" ")) ElseIf c.Length > 2 And c.Length <= 4 Then c = c.PadRight(5, CChar(" ")) ElseIf c.Length > 4 And c.Length <= 6 Then c = c.PadRight(7, CChar(" ")) ElseIf c.Length > 6 And c.Length <= 11 Then c = c.PadRight(12, CChar(" ")) End If

What on earth is this doing?? You realize that c is being evaluated for length in every one of those if statements, including after each new change you make by padding it with spaces?

Dave Kreskowiak Microsoft MVP - Visual Basic

[TeiUKei]

Well, this is the actual code i am doing. I still can't find where the problem is although i use Environment.Newline, sorry for the troublesome! This is the data i try to displayed Dim Data1 As New PropertyCreateFile Dim aa As New ArrayList aa.Add("A4585525581") aa.Add("b") aa.Add("b2") aa.Add("c234") aa.Add("M45686") Data1.Data = aa Data1.Counter = 3 'aaa.CreateTextFile(Data1) aaa.CreateCSVFile(Data1) Public Function CreateCSVFile(ByVal CreatePP As PropertyCreateFile) As String Dim sFilename As String = (CurDir & "/CSVFile.csv") Dim b As Integer Dim a As Integer Dim c As String Dim Data(4) As String FileOpen(20, sFilename, OpenMode.Output) For b = 0 To CreatePP.Counter - 1 For a = 0 To 4 c = CStr(CreatePP.Data(a)) 'For these if statement, i intend to get and check the 'length of data pass in by user, so the data can displayed 'systematically If c.Length <= 1 Then c = c.PadRight(2, CChar(" ")) ElseIf c.Length <= 2 Then c = c.PadRight(3, CChar(" ")) ElseIf c.Length > 2 And c.Length <= 4 Then c = c.PadRight(5, CChar(" ")) ElseIf c.Length > 4 And c.Length <= 6 Then c = c.PadRight(7, CChar(" ")) ElseIf c.Length > 6 And c.Length <= 11 Then c = c.PadRight(12, CChar(" ")) End If Data(a) = c 'Is it right if i use Environment.NewLine here? Write(20, Data(a), Environment.NewLine) Next a Next b FileClose(20)

[Dave Kreskowiak]

This is not all the code that's involved. What's the code for PropertyCreateFile and what is it supposed to do? Where is aaa defined ("aaa.CreateCSVFile(Data1)"), and as what?

If c.Length <= 1 Then
c = c.PadRight(2, CChar(" "))
ElseIf c.Length <= 2 Then
c = c.PadRight(3, CChar(" "))
ElseIf c.Length > 2 And c.Length <= 4 Then
c = c.PadRight(5, CChar(" "))
ElseIf c.Length > 4 And c.Length <= 6 Then
c = c.PadRight(7, CChar(" "))
ElseIf c.Length > 6 And c.Length <= 11 Then
c = c.PadRight(12, CChar(" "))

A CSV file doesn't care about padding, so what's this for? Is this for displaying the information in a TextBox or something, while you write the data to a CSV file?

Dave Kreskowiak Microsoft MVP - Visual Basic

[TeiUKei]

Really? So, how about when it convert to text file? Anyway,this is where aaa defined which you ask about. Private Sub Button2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button2.Click Dim Data1 As New PropertyCreateFile Dim aa As New ArrayList aa.Add("A45855") aa.Add("b") aa.Add("120306") aa.Add("c234") aa.Add("M45686") Data1.Data = aa Data1.Counter = 3 aaa.CreateCSVFile(Data1) End Sub 'This is the code for PropertyCreateFile. It will take in the data detail and 'counter on how many times it will loop. Public Class PropertyCreateFile Dim Str As ArrayList Dim Ctr As Integer Dim UBSBadgeNo As Integer Public Property Data() As ArrayList Get Return Str End Get Set(ByVal Value As ArrayList) Str = Value End Set End Property Public Property Counter() As Integer Get Return Ctr End Get Set(ByVal Value As Integer) Ctr = Value End Set End Property End Class Public Function CreateCSVFile(ByVal CreatePP As PropertyCreateFile) As String Dim sFilename As String = (CurDir & "/CSVFile.csv") Dim b As Integer Dim a As Integer Dim c As String Dim x As String Dim Data(4) As String FileOpen(20, sFilename, OpenMode.Output) For b = 0 To CreatePP.Counter - 1 For a = 0 To 4 c = CStr(CreatePP.Data(a)) If c.Length <= 1 Then c = c.PadRight(2, CChar(" ")) ElseIf c.Length <= 2 Then c = c.PadRight(3, CChar(" ")) ElseIf c.Length > 2 And c.Length <= 4 Then c = c.PadRight(5, CChar(" ")) ElseIf c.Length > 4 And c.Length <= 6 Then c = c.PadRight(7, CChar(" ")) ElseIf c.Length > 6 And c.Length <= 11 Then c = c.PadRight(12, CChar(" ")) End If Data(a) = c Next a x = Data(0) + Data(1) + Data(2) + Data(3) + Data(4) WriteLine(20, x, Environment.NewLine) Next b FileClose(20) Return Nothing End Function Thanks for help, Dave!!

[Dave Kreskowiak]

TeiUKei wrote:

Really? So, how about when it convert to text file?

A CSV file (Comma Seperated Values) IS a text file!

TeiUKei wrote:

WriteLine(20, x, Environment.NewLine)

Change it to this:

WriteLine(20, x)
WriteLine(20, Environment.NewLine)

Dave Kreskowiak Microsoft MVP - Visual Basic