file input program

[klutez123]

I'm trying to make a program to open a file named stats.dat and input name, batting average, and home run amount. So far I have: #include "stdafx.h" #include "statistics.h" #include #include #include // Global Declarations using namespace std; CWinApp TheApp; /***************************************************** * MAIN * *****************************************************/ int main() { //variable declarations char end, lc; //declare char int hr_num; //declare int float bat_avg; //declare float string name; //declare string ofstream outfile; //declare an ofstream filestream outfile.open("FLOATS.DAT",ios::app); //open file for output lc = 'y'; if(outfile) //if file opened successfully { while (lc = 'y') // { cout << "Enter the name of the player: "; getline(cin, name); outfile << name<> bat_avg; outfile << bat_avg<> hr_num; outfile << hr_num<> lc; } //while x does not equal 0 } else //if file failed to open... { cout << "Error opening file.\n"; //output error message } outfile.close(); //close file return 0; //terminate program } My problem is that after the .exe runs through once and will skip lines the second time through. All help is appreciated

[David Crow]

klutez123 wrote:

while (lc = 'y') //

If you'll put constants on the left side of the operator, you won't have such problems. Having while ('y' = lc), the compiler would have immediately told you the problem.

---

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

[toxcct]

klutez123 wrote:

while (lc = 'y')

my answer is certainly not related to your question, but are you sure you didn't want to write this instead ?

while (lc **==** 'y')

---

[VisualCalc][Flags Beginner's Guide] | [Forums Guidelines][My Best Advice]

[jhwurmbach]

Totally unrealated to your question, but this

char end, lc; //declare char

is an example for a very bad comment. Everyone who knows a little C++ knows the he read a char variable declaration before he even comes to reading the comment. Write what the role of the variables will be, comment why, not what.

---

Failure is not an option - it's built right in.

[Sebastian Schneider]

I would even go as far as saying that the comment is plain wrong. He is not declaring char, he is declaring the variables end and lc.

Cheers, Sebastian -- Contra vim mortem non est medicamen in hortem.