How to allocate memory for array..?How to delete that array.? Am i correct in this code?

G Haranadh

... ... BYTE *pbyCmd; pbyCmd = new BYTE[byCount+1]; ... ... if (pbyCmd) delete pbyCmd; ... ... Is this correct code. which I am posting here above. Please let me know?

Nice talking to you. :-O
If you judge people, you have no time to love them. -- Mother Teresa

Christian Graus

G Haranadh wrote:

pbyCmd = new BYTE[byCount+1];

Why +1 ?

G Haranadh wrote:

if (pbyCmd) delete pbyCmd;

No. if (pbyCmd) delete [] pbyCmd;

Christian Graus - Microsoft MVP - C++ Metal Musings - Rex and my new metal blog "I am working on a project that will convert a FORTRAN code to corresponding C++ code.I am not aware of FORTRAN syntax" ( spotted in the C++/CLI forum )

toxcct

BYTE *pbyCmd = NULL; //Always allocate a default value,
// or directly assign a value

pbyCmd = new BYTE[byCount+1]; //why +1 ?

if (pbyCmd) {
delete**[]** pbyCmd;
pbyCmd = NULL; //this is not done automatically by delete
// but you should do it for security, and if
// you want to be able to test if NULL or not
}

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

G Haranadh

Christian Graus wrote:

Why +1 ?

This is existing project. And we need one byte extra allocation at that situation. :) Thanks.

Christian Graus wrote:

if (pbyCmd) delete [] pbyCmd;

Thanks:-D. I am replacing this code with this. :cool:

Nice talking to you. :-O
If you judge people, you have no time to love them. -- Mother Teresa

Christian Graus

Good point, how did I forget it ?

Christian Graus - Microsoft MVP - C++ Metal Musings - Rex and my new metal blog "I am working on a project that will convert a FORTRAN code to corresponding C++ code.I am not aware of FORTRAN syntax" ( spotted in the C++/CLI forum )

G Haranadh

Thanks.:rose:After long time we met:cool:. Ok If i said pbyCmd = new BYTE[1]; then? delete pbyCmd; //or delete[] pbyCmd;

Nice talking to you. :-O
If you judge people, you have no time to love them. -- Mother Teresa

toxcct

new -> delete new[] -> delete[]

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

prasad_som

toxcct wrote:

if (pbyCmd) { delete[] pbyCmd;

Checking for NULL while deleting pointers feels unnecessary. There is no harm deleting NULL pointers. And if its dangled/uninitialized pointer, that will cause problem any way.

Prasad Notifier using ATL | Operator new[],delete[][^]