Get rid of this programmer
-
GTuritto wrote:
It could be solved with ++ operator. But you will surprise to know how many Developers, (and some of them are really good) that I personally know that they never in their's life are used ++ and they had no idea about the ++ operator.
I, thankfully, am not one of them. I for one, as are most people, am completely satisfied with
i=i+1in the event that a++operator doesn't exist, in any language I use. I the consequences and performance benefits/costs of making a call to a function along with the optimizations available in todays compilers.GTuritto wrote:
If it was me first I will be say "What a F...", then I will have a chat with the guy asking why he did that, third I will lecture him why the method is bad, and showing to him the ++ operator, fourth I will see if we can improve the idea, or tell to the programmer to fix the little issue, fifth I will check again to see if he fixed in the right way.
Reading the original post, it's entirely possible that this DID occur, and he still doesn't work for the company. Maybe this person did all kinds of stupid things in his code, maybe not. We simply don't know. I know, it's no reason to be critical of it. But, we also don't know what kind of skill level assumption he was hired under either. If they were expecting higher quality work and he just couldn't deliver past high-school code, out the door he goes.
GTuritto wrote:
All of us we did some stupid mistake like that.
There's a huge difference between making a stupid mistake like that and turning it in as production code. I for one, have never turned in a stupid mistake, no, let me change that, a stupid rationalisation like that! What on earth was this guy thinking when he wrote this? What's the rationale behind writing a function like this? Having said that, what's going through this guys head with the rest of the code he turned in, or will turn in in the future? How much work are we going to now have to invest in him AND cleaning up his code. This guy wasn't ready for a full-time coding job, plain and simple. School, or his own study habits, it seems, has failed to prepare him for a real world coding job. In this cut-throat business, I don't know of too many internships that could spare the time or the resources to teach him what he should have learnt in class. I know
Even then, why write a function to do it, he could just easily call +1 on the integer.
-
Even then, why write a function to do it, he could just easily call +1 on the integer.
Exactly my point! :-D
Dave Kreskowiak Microsoft MVP Visual Developer - Visual Basic
2006, 2007 -
I think he should be informed of his mistake, encouragement might help him to overcome his deficiencies. A.A.
asif
asifali wrote:
I think he should be informed of his mistake, encouragement might help him to overcome his deficiencies.
If you want to change your job from programmer to teacher, go ahead. You know the saying: "Give a dog a bone and it'll bite your hand off.":) I'm sure we all had this kind of classmates in school, and unless the code is just the result of a moment's inattention, it's amazing he even had the guts to apply for the job!:omg: It must have been loads of fun firing him. Wish I were there.:laugh:
-
It was about to become really costful, as he was paid on the number of lines he was writing. He even managed to write wrappers over each native Win32 API, even the ones he was not using, just to charge more... And above this, he planned to rewrite Windows in a VM ! That's an explanation, find more :) Kochise
In Code we trust !
What's a line?
-
PIEBALDconsult wrote:
May have used # define integer int or typedef
C# does not have them although
usingcan be used for that purpose in a file scope, but I honestly think that the OP made a typo. Maybe he should be fired, rather than the poor beginner programmer :)
-
I hired a programmer right out of school. Started him on a very simple project. I performed a tech review of the code and saw the following method call private integer inc(integer int_i) { integer int_j=int_i+1; return int_j; } He no longer works for the company.......:wtf: Moose Man
-
I hired a programmer right out of school. Started him on a very simple project. I performed a tech review of the code and saw the following method call private integer inc(integer int_i) { integer int_j=int_i+1; return int_j; } He no longer works for the company.......:wtf: Moose Man
eunderwo00 wrote:
He no longer works for the company.......
That's pretty lame of you to can him over stupid code like that. You could have at least maybe mentored him with Code Complete :rolleyes:
-
Better still - I say get rid of the person who hired him in the first place. At least that way you guarantee such a disaster wont enter "the" organisation again. :cool:
Arash Partow wrote:
I say get rid of the person who hired him in the first place. At least that way you guarantee such a disaster wont enter "the" organisation again.
I agree. The OP should have at least mentored him with the tech review, and if it happened again, then fire the programmer. Doesn't sound like the person was given much of a chance...
-
Did you offer him/her constructive criticism? :) Otherwise they'll continue writing bad code. IMHO it's not really bad code as from what I can tell it looks valid. More bad practice, which is something only experience can teach you - at least osmething that trivial as I don't think Fowler, etc address those kind of design choices. :P
I'm finding the only constant in software development is change it self.
Hockey wrote:
Did you offer him/her constructive criticism?
It doesn't sound like he did. In a few posts in this thread, I've been mentioning it...
-
It was about to become really costful, as he was paid on the number of lines he was writing. He even managed to write wrappers over each native Win32 API, even the ones he was not using, just to charge more... And above this, he planned to rewrite Windows in a VM ! That's an explanation, find more :) Kochise
In Code we trust !
Kochise wrote:
he was paid on the number of lines he was writing
Oh, no! You're working in a place that measures code by the yard, and then complain that somebody fresh out of the egg is - well let's say a little uncertain in their grasp of fundamentals. Get a grip! Frankly, I'd have fired others, starting (in the very first femtosecond) with the guy who instigated the fatuous "quantity rather than quality" regime, continuing with whoever did the hiring (since this job apparently called for an accurate, experienced programmer), and possibly with whoever did the firing (though that may have been for factors other than the predictable howlers from a coding tyro).
Kochise wrote:
He even managed to write wrappers over each native Win32 API, even the ones he was not using
Did they work? That's moderately sophisticated for a kid straight out of school. This sounds to me like someone who, with a modicum of sympathetic mentoring obviously not available in your shop, could well turn into a real code warrior. Oh, and what was the kid's supervisor doing while he did all this apparently unnecessary work? Think I'll add him to the firing line as well.
-
I can't see anything wrong with that code. Attitudes like that stop people like me (Students from college) from becoming developers, because no-one wants a newbie. Catch 22. Tom
Functionally the code would work. Just weird, when some smarty-pants with a 4-years information system B.-degree and some >=3-years 'experience' codes crap like that. Imagine then, 4 out of 5 (internal) programmers at the company where i was emplyed, churned out crap like that, for a complex financial system. Mind you, the lead programmer was creating such code himself. I have, in my 9 years as developer came across countless exampless of coding horrors, which are created to show-off their 'skill'.
Tom Moore wrote:
I can't see anything wrong with that code. Attitudes like that stop people like me (Students from college) from becoming developers, because no-one wants a newbie. Catch 22.
met vriendelijke groet, Michiel Erasmus