Inserting new records in a child table

[Psyfo]

Hi everyone I have the folowing code in the Business class in my program, but when i run it says that there's an error in the sql. Can you please help Public Function AddSale(ByVal dtDate As DateTime, ByVal bookcode As String, ByVal InvoiceNo As String, ByVal qty As Integer, ByVal subtot As Single, ByVal vat As Single, ByVal tot As Single) As String Dim sql As String Dim cmd As OleDb.OleDbCommand Dim result As String = "" Try sql = "INSERT INTO SALES (Dates, BookCode, InvoiceNumber, Quantity, SubTotal, VAT, Total) Values ( " + dtDate + " ,'" + bookcode + "','" + InvoiceNo + "', qty , subtot, vat, tot)" cmd = New OleDb.OleDbCommand(sql, con) cmd.Parameters.Add(New OleDb.OleDbParameter("@qty", qty)) cmd.Parameters.Add(New OleDb.OleDbParameter("@subtot", subtot)) cmd.Parameters.Add(New OleDb.OleDbParameter("@vat", vat)) cmd.Parameters.Add(New OleDb.OleDbParameter("@tot", tot)) cmd.Parameters.Add(New OleDb.OleDbParameter("@dtDate", dtDate)) If cmd.Connection.State = ConnectionState.Closed Then cmd.Connection.Open() End If cmd.CommandText = sql cmd.ExecuteNonQuery() result = "true" Catch ex As Exception result = ex.Message.ToString() End Try Return result End Function

[bigjokey]

When adding parameters, the parameter names in the SQL must match the parameters that you add: so your SQL should look like this: sql = "INSERT INTO SALES (Dates, BookCode, InvoiceNumber, Quantity, SubTotal, VAT, Total) Values ( " + dtDate + " ,'" + bookcode + "','" + InvoiceNo + "', @qty , @subtot, @vat, @tot)" You are also adding the date as a parameter "cmd.Parameters.Add(New OleDb.OleDbParameter("@dtDate", dtDate))" after you have already embedded it in the SQL. So you may want to change your SQL to look something like this: sql = "INSERT INTO SALES (Dates, BookCode, InvoiceNumber, Quantity, SubTotal, VAT, Total) Values ( @dtDate ,'" + bookcode + "','" + InvoiceNo + "', @qty , @subtot, @vat, @tot)" And given that you are using parameters, you may want to add the BookCode as a paramter aswell, for consistency. Hope this helps