"__declspec(thread)" or "__declspec(thread) static"

[chenggong]

to make the nextBuf and workBuf in the following code multi-thread save, is it correct to replace "static" with "__declspec(thread)" in the code? or it should be "__declspec(thread) static" ? THANKS FOR THE HELP! ------ static int nextBuf ; static char workBuf[8][64] ; char * GetBuf() { nextBuf++ ; if( nextBuf >= 8 ) nextBuf = 0 ; return workBuf[nextBuf] ; }

[led mike]

chenggong wrote:

multi-thread save

I guess you meant "safe"? You did not specify your problem. So deducing your intent from your code it seems you are trying to share the workbuf[] array across threads? If so, you need to synchronize access to the GetBuf() function, not put the array into TLS as _declspec(thread) would do. Not to mention putting the array but not the indexer into TLS would certainly produce undesired behavior. Also your design is, well less than [whatever]. Have you ever heard of the Singleton Design Pattern? Any Design Patterns? Are you sure you should be writing multi-threading code?

[cmk]

The static just says that the variables are local to the module (.cpp file). That is, they are not going to be directly used (by name) in any other module. Both will work, but since you have already marked them as static i would keep that. Also, you should init your global vars, even though in this case it still works without doing so. Also, since the variables are (should be) only used in the function you may want to put them there. i.e.

char* gb( void ) {
__declspec(thread) static int i = 0;
__declspec(thread) static char b[8][64];

if( i >= 8 )  i = 0;
return( b\[i++\] );

}

...cmk Save the whales - collect the whole set

[chenggong]

Thank you cmk !