Two methods to create dialog

[acerunner316]

Method 1:

CMyDialog mMyDialog;
mMyDialog.Create(CMyDialog::IDD, this);

Method 2:

CMyDialog* mptrMyDialog;
mptrMyDialog = new CMyDialog;
mptrMyDialog -> Create(CMyDialog::IDD, this);

In method 2, I have to call delete mptrMyDialog before closing, but in method 1, mMyDialog will be destroyed when its parent is closed, correct? So why is method 2 generally the preferred way? Method 1 seems to me like the simpler way because you don't have to worry about deallocating.

[David Crow]

acerunner316 wrote:

So why is method 2 generally the preferred way?

It all depends on the individual (and where they may have copied their code from).

---

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

[Mark Salsbery]

acerunner316 wrote:

in method 1, mMyDialog will be destroyed when its parent is closed, correct?

The windows object (HWND) will be destroyed when the parent is destroyed. The CMyDialog object is destroyed when it goes out of scope.  If it goes out of scope while its wrapped HWND is valid, the Windows object (HWND) will be destroyed as well. I suppose which method you use (in addition to DavidCrow's reply) depends on the desired scope of the object and/or whether you want it on the stack or the heap. Mark

Mark Salsbery Microsoft MVP - Visual C++ :java:

[toxcct]

acerunner316 wrote:

In method 2, I have to call delete mptrMyDialog before closing

wrong. after !!! otherwise, you delete a dialog still being displayed !

---

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

[Russell]

acerunner316 wrote:

So why is method 2 generally the preferred way?

I never heared this before:doh:... the 2 methods are exactly the same for me. The only difference that I can see is that using pointers you can pass the pointer from function to function, or, in a class, you can store the dialog pointer on a member variable of that class.:^)

---

Russell

[Roger Broomfield]

method 2 is preferred because the purpose of Create is to create a modeless dialog so imagine you have this function somewhere void OpenMyModelessDialog() { CMyDialog mMyDialog; mMyDialog.Create(CMyDialog::IDD, this); } as soon as the function returns the modeless dialog will be destroyed OOPS!!!