Do it only once please

Chris Meech

It would be interesting if the optimizer managed to do anything with this. This is the kind of stuff you end up with, when code gets 'maintained' over a couple of generations of developers. :)

Chris Meech I am Canadian. [heard in a local bar] Donate to help Conquer Cancer[^]

Pascal 0

Effectively, and no one changed it

Oshtri Deka

:D

Tony Wesley

The loop one times construct can be useful. Where I've used it is when I've had to work with a long sequence of if else/if's, and used break to exit. For instance:

while (true)   // loop 1 time, exit at bottom
{
    if (set (ifrFragment))
    {
        result = true;
        ifrTerm = ifrFragment;
        break;            
    }
    if (errorCode)
        break;

    if (keyword (TokenSubtype::Not) && term (ifrFragment))
    {
        result = true;
        ifrTerm = TokenSubtype::Not.asString() + " " + ifrFragment;
        break;
    }
    if (errorCode)
        break;
  // more lines snipped
   break;
}

But the switch/case in your example would lead me to believe that lnIndice had other values at some point, perhaps for debugging.

PIEBALDconsult

If it ain't broke...

Robert Surtees

lol. Haven't seen that done in a long time. We used to do it to piss off the "never use goto" zealots years ago when forbidden to use 'goto xit' for handling error conditions.

Tony Wesley

Robert Surtees wrote:

We used to do it to piss off the "never use goto" zealots years ago when forbidden to use 'goto xit' for handling error conditions.

Robert, I use goto's for exactly the same reason.

if (keyword (TokenSubtype::Group))
{
    if (!group\_label (groupName))
    {
        errorMessage = myName + ": Missing GROUP label\\n" + errorMessage;
        errorCode = DL\_ERROR;
        **goto exit\_;**
    }

    if (!separator (TokenSubtype::Colon))
    {
        errorMessage = myName + ": Missing colon following GROUP label";
        errorCode = DL\_ERROR;
        **goto exit\_;**
    }

// etc...

PIEBALDconsult

But then why not

do
{
...
} while ( false ) ;

Tony Wesley

Your way is better.

Chris Losinger

heh. of course that's just a coding-standards-compliant way of writing:

    if (set (ifrFragment))
    {
        result = true;
        ifrTerm = ifrFragment;
        goto done;            
    }
    if (errorCode)
        goto done;

    if (keyword (TokenSubtype::Not) && term (ifrFragment))
    {
        result = true;
        ifrTerm = TokenSubtype::Not.asString() + " " + ifrFragment;
        goto done;
    }
    if (errorCode)
        goto done;
  // more lines snipped

done:

:laugh:

image processing toolkits | batch image processing

Marc Clifton

You're sure you're not mistaking that "one" in lnIndice <= 1 for an "ell"? Marc

Thyme In The Country
Interacx
My Blog

chmod2222

I use goto only to break out of >1 nested loops... Don't see the need for it anywhere else...

-- www.domagoj.net

CPallini

The rollback from a list of initialization steps maybe another valid usage. :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.

leppie

Tony Wesley wrote:

I use goto's

It's OK, so do I, in C#! :)

xacc.ide
IronScheme a R5RS-compliant Scheme on the DLR
The rule of three: "The first time you notice something that might repeat, don't generalize it. The second time the situation occurs, develop in a similar fashion -- possibly even copy/paste -- but don't generalize yet. On the third time, look to generalize the approach."

Xiangyang Liu

That's what I call extendable coding. ;P

My .NET Business Application Framework My Home Page

Dalek Dave

FINALLY!!!! My first entry on a coding horror! Is this a sign I am starting to learn, possibly, but even in goood old fashioned ms basic circa 1981 I would have spotted this load of old codswallop! So pleased to say that I would never have done this!:-D

------------------------------------ Happy Primes Lead to Happy Memories. Don't Google FGI

Tony Wesley

chmod2222 wrote:

I use goto only to break out of >1 nested loops... Don't see the need for it anywhere else...

Real Programmers aren't afraid to use GOTO's[^]

chmod2222

I aint affraid to use it bubba joe :) I just don't see the need for it... At least in C#...

-- www.domagoj.net

Secrets

heheheh :D. Cool thing....i myself as developer can understand that sort of things can happen when code passes through certain hands without proper comments.

KarstenK

Whether it was the basement of great code or the ruin of an unlucky project. Who knows... :~ A good optimized cempiler would clean this up. :-O

Greetings from Germany