returning a string in reverse
-
Where is this code? You didn't provide it in your original post. If you have already managed to reverse the string and display it, you must have the reversed string in a variable to be returned from your method. The absence of this code suggests that you haven't written it at all and want someone else to do it for you. This isn't how the site works.
Paul Marfleet "No, his mind is not for rent To any God or government" Tom Sawyer - Rush
OMG... ok then, i created a char array; char[] myArray = new char[m]; //m is the length of array read all the data into the array using; for (int i =0; iCheers :)
-
hmmmm... does that sound like a homework question? you could use a stack to do this:
public void Main()
{
string foo = "i will do my homework on my own";
string blah = reverseString(foo);
Console.WriteLine(foo);
Console.WriteLine(blah);
}
public void reverseString(string Text)
{
System.Collections.Stack st = new Stack();
foreach (char c in Text)
{
st.Push(c);
}
ArrayList l = new ArrayList();
while (st.Count > 0)
{
l.Add(st.Pop());
}
char[] s = l.ToArray(typeof(char)) as char[];
string RetVal = new string(s);
return RetVal;
}but if you use one of the other 999999999 possibilities to do it it'll be more efficient
ok this is my method, the loop is not functioning, but i cant see y??? public string Reverse(string WhatToReverse) { int lengthOfArray = WhatToReverse.Length; //char array char[] myArray = new char[lengthOfArray]; for (int i = lengthOfArray; i < 0; i--) { myArray[i] = WhatToReverse[i]; Console.Write(myArray[i]); } return ;//still to complete, but the loop dont work }
Cheers :)
-
last year? thats too long time ago. i go back a lil, but not that far. could u please search n let me know, that would be v.helpful
Cheers :)
-
ok this is my method, the loop is not functioning, but i cant see y??? public string Reverse(string WhatToReverse) { int lengthOfArray = WhatToReverse.Length; //char array char[] myArray = new char[lengthOfArray]; for (int i = lengthOfArray; i < 0; i--) { myArray[i] = WhatToReverse[i]; Console.Write(myArray[i]); } return ;//still to complete, but the loop dont work }
Cheers :)
hustler2005 wrote:
for (int i = lengthOfArray; i < 0; i--)
I is not less than 0 at the start.
-
As just stated, if its not homework and you have working code then post it and someone here will explain the use of the
returnkeyword for you. I still call this out as homework.Of course this is homework, no company is going to pay for string reversals. Maybe
class gnirtscould help, but sadly it has been postponed till the next major upgrade of the .NET Framework. :doh:Luc Pattyn [Forum Guidelines] [My Articles]
this months tips: - before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use PRE tags to preserve formatting when showing multi-line code snippets
-
last year? thats too long time ago. i go back a lil, but not that far. could u please search n let me know, that would be v.helpful
Cheers :)
Another http://www.codeproject.com/script/comments/forums.asp?forumid=1649&ForumID=1649&XtraIDs=1649&searchkw=reverse&sd=24%20Aug%202006&ed=22%20Nov%202007&stype=3&Page=4&select=1810365&df=100&exp=1&mpp=50&fr=13817[^] and another http://www.codeproject.com/script/comments/forums.asp?forumid=1649&ForumID=1649&XtraIDs=1649&searchkw=reverse&sd=24%20Aug%202006&ed=22%20Nov%202007&stype=3&Page=4&select=1793424&df=100&exp=1&mpp=50&fr=14253&tid=1793237[^]
-
I must object a little; in C# strings are immutable, so swapping chars isn't the right way...
Luc Pattyn [Forum Guidelines] [My Articles]
this months tips: - before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use PRE tags to preserve formatting when showing multi-line code snippets
-
hmmmm... does that sound like a homework question? you could use a stack to do this:
public void Main()
{
string foo = "i will do my homework on my own";
string blah = reverseString(foo);
Console.WriteLine(foo);
Console.WriteLine(blah);
}
public void reverseString(string Text)
{
System.Collections.Stack st = new Stack();
foreach (char c in Text)
{
st.Push(c);
}
ArrayList l = new ArrayList();
while (st.Count > 0)
{
l.Add(st.Pop());
}
char[] s = l.ToArray(typeof(char)) as char[];
string RetVal = new string(s);
return RetVal;
}but if you use one of the other 999999999 possibilities to do it it'll be more efficient
I prefer the following...
public void Main()
{
string str = "I will do my homework on my own";
IntPtr strPtr = Marshal.StringToHGlobalUni(str);
IntPtr resPtr = ReverseString(strPtr);
string res = Marshal.PtrToStringUni(result);
Marshal.FreeHGlobal(strPtr);
Marshal.FreeHGlobal(resPtr);
Console.WriteLine(str);
Console.WriteLine(res);
}public IntPtr ReverseString(IntPtr strPtr)
{
string str = Marshal.PtrToStringUni(strPtr);
char[] strAsCharArray = new char[str.Length];
for (int i = 0; i < str.Length; ++i)
{
strAsCharArray[i] = str[0];
str = str.Substring(1);
}
StringBuilder sb = new StringBuilder(strAsCharArray.Length);
string res = string.Empty;
for (int i = 0; i < str.Length; i += 2)
{
string next = string.Empty;
for (int j = 1; j >= 0; --j)
{
if (i + j == str.Length)
continue;
char c = strAsCharArray[i + j];
next.Insert(0, c.ToString());
res.Insert(1 - j, c.ToString());
}
sb.Append(next);
}
str = sb.ToString();
IntPtr rval = Marshal.StringToHGlobalUni(res);
return rval;
}This is O(n), which is as fast as this operation can be done given how strings are implemented in the system (with a double-linked-list, it can be O(1)). Hope this helps. Jeff
-
Another http://www.codeproject.com/script/comments/forums.asp?forumid=1649&ForumID=1649&XtraIDs=1649&searchkw=reverse&sd=24%20Aug%202006&ed=22%20Nov%202007&stype=3&Page=4&select=1810365&df=100&exp=1&mpp=50&fr=13817[^] and another http://www.codeproject.com/script/comments/forums.asp?forumid=1649&ForumID=1649&XtraIDs=1649&searchkw=reverse&sd=24%20Aug%202006&ed=22%20Nov%202007&stype=3&Page=4&select=1793424&df=100&exp=1&mpp=50&fr=14253&tid=1793237[^]
Yep, just like a similar reverse problem[^] it can be solved with a single line of code, much shorter than each of the posts/replies in this thread... :)
Luc Pattyn [Forum Guidelines] [My Articles]
this months tips: - before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use PRE tags to preserve formatting when showing multi-line code snippets
-
I prefer the following...
public void Main()
{
string str = "I will do my homework on my own";
IntPtr strPtr = Marshal.StringToHGlobalUni(str);
IntPtr resPtr = ReverseString(strPtr);
string res = Marshal.PtrToStringUni(result);
Marshal.FreeHGlobal(strPtr);
Marshal.FreeHGlobal(resPtr);
Console.WriteLine(str);
Console.WriteLine(res);
}public IntPtr ReverseString(IntPtr strPtr)
{
string str = Marshal.PtrToStringUni(strPtr);
char[] strAsCharArray = new char[str.Length];
for (int i = 0; i < str.Length; ++i)
{
strAsCharArray[i] = str[0];
str = str.Substring(1);
}
StringBuilder sb = new StringBuilder(strAsCharArray.Length);
string res = string.Empty;
for (int i = 0; i < str.Length; i += 2)
{
string next = string.Empty;
for (int j = 1; j >= 0; --j)
{
if (i + j == str.Length)
continue;
char c = strAsCharArray[i + j];
next.Insert(0, c.ToString());
res.Insert(1 - j, c.ToString());
}
sb.Append(next);
}
str = sb.ToString();
IntPtr rval = Marshal.StringToHGlobalUni(res);
return rval;
}This is O(n), which is as fast as this operation can be done given how strings are implemented in the system (with a double-linked-list, it can be O(1)). Hope this helps. Jeff
Since you already optimized the code, more in particular by unrolling the for loop, it is actually more like O(n/2) which is quite good. :)
Luc Pattyn [Forum Guidelines] [My Articles]
this months tips: - before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use PRE tags to preserve formatting when showing multi-line code snippets
-
Since you already optimized the code, more in particular by unrolling the for loop, it is actually more like O(n/2) which is quite good. :)
Luc Pattyn [Forum Guidelines] [My Articles]
this months tips: - before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use PRE tags to preserve formatting when showing multi-line code snippets
Thanks all sorted, this is what i used....... public string Reverse(string WhatToReverse) { string str2 = string.Empty; StringBuilder sb = new StringBuilder(); //char array char[] myArray = WhatToReverse.ToCharArray(); for(int i = WhatToReverse.Length-1; i >=0; i--) { sb.Append(myArray[i].ToString()); } str2 = sb.ToString(); return str2; }
Cheers :)
-
Thanks all sorted, this is what i used....... public string Reverse(string WhatToReverse) { string str2 = string.Empty; StringBuilder sb = new StringBuilder(); //char array char[] myArray = WhatToReverse.ToCharArray(); for(int i = WhatToReverse.Length-1; i >=0; i--) { sb.Append(myArray[i].ToString()); } str2 = sb.ToString(); return str2; }
Cheers :)
Good work! Post something like this and ask how to make it better, and we will honestly try to help (instead of the crappy roundabout ways we proposed to solve the problem earlier). The way I would implement this problem is as follows...
public string ReverseString(string str) {
StringBuilder result = new StringBuilder();
for (int i = str.Length - 1; i >= 0; --i)
result.Append(str[i]);
return result.ToString();
}Like I said, show that you have put even a little effort into trying to find the answer by yourself, and we will try to give you the help you need to get it right, but don't expect us to give you the answer from scratch. Jeff
-
Of course this is homework, no company is going to pay for string reversals. Maybe
class gnirtscould help, but sadly it has been postponed till the next major upgrade of the .NET Framework. :doh:Luc Pattyn [Forum Guidelines] [My Articles]
this months tips: - before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use PRE tags to preserve formatting when showing multi-line code snippets
-
Since you already optimized the code, more in particular by unrolling the for loop, it is actually more like O(n/2) which is quite good. :)
Luc Pattyn [Forum Guidelines] [My Articles]
this months tips: - before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use PRE tags to preserve formatting when showing multi-line code snippets
-
Hi Guys i would like to know how you can create a simple method to return a string in reverse order. i have the following method public string myMethod (String myString) { . . //code goes in here . return myString } i have been trying to use a array to read the string into and try that but this doesnt seem to work any ideas please??
Cheers :)
Have you considered using Array.Reverse method?
string original = "original";
char[] reverseString = original.ToCharArray();
Array.Reverse(reverseString);
original = string.Empty;
for (int i = 0; i < reverseString.Length; i++)
original += reverseString[i];I will use Google before asking dumb questions
-
Have you considered using Array.Reverse method?
string original = "original";
char[] reverseString = original.ToCharArray();
Array.Reverse(reverseString);
original = string.Empty;
for (int i = 0; i < reverseString.Length; i++)
original += reverseString[i];I will use Google before asking dumb questions
summing up to
new string(Array.Reverse(original.ToCharArray())or even better a sequence oforiginal.ToCharArray(),Array.Reverse()andnew string(char[]):) -- modified at 15:58 Thursday 22nd November, 2007Luc Pattyn [Forum Guidelines] [My Articles]
this months tips: - before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use PRE tags to preserve formatting when showing multi-line code snippets
-
Good work! Post something like this and ask how to make it better, and we will honestly try to help (instead of the crappy roundabout ways we proposed to solve the problem earlier). The way I would implement this problem is as follows...
public string ReverseString(string str) {
StringBuilder result = new StringBuilder();
for (int i = str.Length - 1; i >= 0; --i)
result.Append(str[i]);
return result.ToString();
}Like I said, show that you have put even a little effort into trying to find the answer by yourself, and we will try to give you the help you need to get it right, but don't expect us to give you the answer from scratch. Jeff
Just one adjustment; specify the capacity when you create the StringBuilder: StringBuilder result = new StringBuilder(str.Length); This will allocate a string with the exact right size. This has two advantages: 1. The StringBuilder never has to increase the capacity (which is done by allocating a new string with double the size, and copy the data from the previous string to it). 2. The string returned by the ToString method doesn't have any extra unused characters beyond the actual string. If you don't specify the length, the string may use up to twice as much memory as it needs to.
Experience is the sum of all the mistakes you have done.
-
summing up to
new string(Array.Reverse(original.ToCharArray())or even better a sequence oforiginal.ToCharArray(),Array.Reverse()andnew string(char[]):) -- modified at 15:58 Thursday 22nd November, 2007Luc Pattyn [Forum Guidelines] [My Articles]
this months tips: - before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use PRE tags to preserve formatting when showing multi-line code snippets
-
No, you can't do like that. The Array.Reverse method doesn't return the reversed array, it reverses the array in place.
Experience is the sum of all the mistakes you have done.
You're right of course. So I'd better turn it into a small method... :)
Luc Pattyn [Forum Guidelines] [My Articles]
this months tips: - before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use PRE tags to preserve formatting when showing multi-line code snippets
-
Hi Guys i would like to know how you can create a simple method to return a string in reverse order. i have the following method public string myMethod (String myString) { . . //code goes in here . return myString } i have been trying to use a array to read the string into and try that but this doesnt seem to work any ideas please??
Cheers :)
Of course, as a quick and dirty hack you could always use a recursive method. I'm not saying you should, but you could. I've seen this done in so many homework assignments and coursework samples.
Deja View - the feeling that you've seen this post before.