Seems familiar?

gnjunge

I came across the following function:

private static string[] SplitByString(string testString, string split)
{
int offset = 0;
int index = 0;
int[] offsets = new int[testString.Length + 1];

        while (index < testString.Length)
        {
            int indexOf = testString.IndexOf(split, index);
            if (indexOf != -1)
            {
                offsets\[offset++\] = indexOf;
                index = (indexOf + split.Length);
            }
            else
            {
                index = testString.Length;
            }
        }

        string\[\] final = new string\[offset + 1\];
        if (offset == 0)
        {
            final\[0\] = testString;
        }
        else
        {
            offset--;
            final\[0\] = testString.Substring(0, offsets\[0\]);
            for (int i = 0; i < offset; i++)
            {
                final\[i + 1\] = testString.Substring(offsets\[i\] + split.Length, offsets\[i + 1\] 
                               - offsets\[i\] - split.Length);
            }
            final\[offset + 1\] = testString.Substring(offsets\[offset\] + split.Length);
        }
        return final;
    }

and just had to run it in order to make sure that this function was really only a rewrite of String.Split(string[] seperator, StringSplitOptions option) which was taken from some website.

PIEBALDconsult

I agree that it's not very well written, but when was it written? Splitting on string was added in .net 2.0; this may have been written before that... as was mine. Mine also has the benefit of honoring quotes and escapes within the string, so splitting 12345,"Coyote, Wile E.","\"Super Genius\"" on comma will return the proper results. Reinventing the wheel is acceptable if (and only if) it results in a better wheel.

Dave Kreskowiak

PIEBALDconsult wrote:

12345,"Coyote, Wile E.","\"Super Genius\""

If he was that much of a genius, why did he keep buying all this crap from ACME after everything he bought repeatedly failed?? :confused: :-D

A guide to posting questions on CodeProject[^]
Dave Kreskowiak Microsoft MVP Visual Developer - Visual Basic
2006, 2007

PIEBALDconsult

They're the only ones to give him a credit card.

gnjunge

I don't know about the original website where it was copied from, but the code I found it in was written/targeted for .NET 3.5.....

Guido_d

string.Split() was available in framework 1.0 and 1.1 too..

PIEBALDconsult

But only with splitting on single-character delimiters, not multi-character (string) delimiters.

PIEBALDconsult

Mark it as Obsolete.

Christoph Menge

Less subtle, and probably posted a thousand times: bool b = whatever; switch(b) { case true: // do something break; case false: // omg... do something else? break; } Seen as PHP-Code... This is completely unrelated, but it just came to my mind...

"Obstacles are those frightening things you see when you take your Eyes off your aim" - Henry Ford
Articles Blog

Steve Westbrook

The split(string, delim) function from earlier VB versions is still available and accepts multi-character delimiter parameters.