split string - better way?

Tara14

Hi, I have to split a string in the format mm/dd/yyyy. This is what I do:

CString date,sMM,sDD,sYY,str;
int	yy,mm,dd; 

// date\_poleSet = CString object date in the format mm/dd/yyyy
// the month,day and year have to be seperated into int mm,dd,yy

int offset = date\_poleSet.Find('/');
date = date\_poleSet;
sMM = date\_poleSet.Left(offset); 
mm = atoi(sMM); // gives the month
str = date.Mid(offset+1);

offset = str.Find('/');
date = str;
sDD = str.Left(offset);
dd = atoi(sDD); // gives the day
sYY = date.Mid(offset+1);
yy = atoi(sYY); // gives the year

Is this good enough? Or can it be done in two or three lines?

Thanks, Tara

CPallini

if your mm/dd/yyyy hypothesis holds then

mm = atoi(str.Left(2));
dd = atoi(str.Mid(3,2));
yy = atoi(str.Right(2));

is a bit more concise.

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke

David Crow

Have you considered COleDateTime::ParseDateTime()?

"Normal is getting dressed in clothes that you buy for work and driving through traffic in a car that you are still paying for, in order to get to the job you need to pay for the clothes and the car and the house you leave vacant all day so you can afford to live in it." - Ellen Goodman

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Tara14

Wow! Thats nice. Thanks a billion.

Thanks, Tara

Cedric Moonen

You could also use a COleDateTime[^] object: you "load" the date using the ParseDateTime method and then you can retrieve all the information you need using the different member functions. The big advantage is that it checks for the date validity, which is a pain if you have to do it yourself (months don't have the same number of days and you have to take into account leap years too :sigh: ).

Cédric Moonen Software developer
Charting control [v1.3]

Cedric Moonen

Damn, you beat me to it ;P

Cédric Moonen Software developer
Charting control [v1.3]

David Crow

I guess my CPMRU was fully charged.

"Normal is getting dressed in clothes that you buy for work and driving through traffic in a car that you are still paying for, in order to get to the job you need to pay for the clothes and the car and the house you leave vacant all day so you can afford to live in it." - Ellen Goodman

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Tara14

Thank you. I shall look into ParseDateTime. Didn't know about that! Although for now, what you showed me (left,right, mid) is perfect for what I am trying to do.

Thanks, Tara

Cedric Moonen

Tara14 wrote:

what you showed me

It was not me ;) Anyway, it all depends from where your date is coming from: if it entered by a user of your program, then it is better to check its validity.

Cédric Moonen Software developer
Charting control [v1.3]

Rajesh R Subramanian

Keep it in mind that no matter how charged it is, there may be some queries with which the CPMRU will not help you at all. ;P

Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP

Mark Salsbery

Indeed. That's a documented bug....won't be fixed for a few releases. Good luck.

Mark Salsbery Microsoft MVP - Visual C++ :java:

crossie

Can I ask what CPMRU is short for?

ThatsAlok

Cedric Moonen wrote:

you beat me to it

Using Sticks?? :doh: :laugh:

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow
Never mind - my own stupidity is the source of every "problem" - Mixture

cheers, Alok Gupta VC Forum Q&A :- I/IV Support CRY- Child Relief and You/codeProject$$>

Cedric Moonen

It is a 'private' joke. It means "Code Project Mind Reader Unit". It appeared recently because a lot of questions that were asked were so incomplete that you had to either see the screen of the guy or read his mind :rolleyes:

Cédric Moonen Software developer
Charting control [v1.3]