Unresolved external symbol in a DLL

[George_George]

Thanks Naveen! I have proved we could expose both class and global variable by DLL and using your mentioned elegant way. :-) But I am not 100% confident. Here is my code, could you have a code review please? DLL Part:

// foo.h

#ifdef _DLLPROJ_
#define DLLEXP __declspec (dllexport)
#else
#define DLLEXP __declspec (dllimport)
#endif

DLLEXP class CFoo
{
public:

DLLEXP int foo1();

DLLEXP int foo2();

};

DLLEXP class CFooImpl : CFoo
{
public:

DLLEXP CFooImpl();

DLLEXP int foo1();

DLLEXP int foo2();

};

// dllmain.cpp

#include "foo.h"

CFooImpl::CFooImpl()
{
return;
}

int CFooImpl::foo1()
{
return 100;
}

int CFooImpl::foo2()
{
return 200;
}

DLLEXP CFooImpl foo;

Hosting client part

// main.cpp

#include "foo.h"

DLLEXP CFooImpl foo;

int main()
{
CFooImpl foo1;

int i = foo.foo1();
i = foo.foo2();

return 0;

}

regards, George

[George_George]

Thanks Stuart, I have correct my code here, could you help to do a code review please? :-) http://www.codeproject.com/script/Forums/View.aspx?fid=1647&msg=2846175[^] regards, George

[Naveen]

I have noted the below problem

George_George wrote:

DLLEXP class CFoo

This should be modified as class DLLEXP CFoo everthing else seems ok.

nave [OpenedFileFinder] [My Blog]

[Stuart Dootson]

Aside from the issue Naveen showed you, IIRC you don't need to DLLEXP the class and the classes methods - one or the other, that's all that's needed really. I tend to DLLEXP the methods, as you have better control over what precisely is exported.

[George_George]

I think they should be the same? It compiles and runs well in VS. :-) regards, George

[George_George]

Hi Stuart, I have tried that if I only mark dllexport on class and not on methods, the methods could not be found during link process. So, I think we have to mark both. Could you have a try please? regards, George

[Stuart Dootson]

I have an awful lot of deployed code that uses this mechanism - here's a sample: #if!defined(COMMONLIB_API) #ifdef COMMONLIB_EXPORTS #define COMMONLIB_API __declspec(dllexport) #else #define COMMONLIB_API __declspec(dllimport) #endif #endif namespace MyAppLibrary { class MessageReporter { public: //ctor COMMONLIB_API MessageReporter(); //Add new reporting function COMMONLIB_API static void AddReportFunction(ReportFnPtr func); //Set MessageReporter Level on or off COMMONLIB_API static void SetReporterLevel(Level lev, bool on); //Set all levels to on COMMONLIB_API static void AllLevelsOn() {repLevels=~0;} //Set all levels to off COMMONLIB_API static void AllLevelsOff() {repLevels=0;} }; }; Is it possible you haven't exported necessary constructors?

[George_George]

But if you only expose class not expose methods, the methods could not be found when linking the client of the DLL (link error, unresolved symbols related to the methods). Could you have a try? I have tried. regards, George

[Stuart Dootson]

DLL interface defined in a.h

a.h

#if !defined(__A_H__) #define __A_H__ #if!defined(A_API) #ifdef A_EXPORTS #define A_API __declspec(dllexport) #else #define A_API __declspec(dllimport) #endif #endif class A_API A { public: A(); A(int a); void DoSomething(int b); int Result() const; private: int a_; }; #endif // !defined(__A_H__) DLL implemented in a.cpp and built with cl -EHsc -LD a.cpp

a.cpp

#include <windows.h> #define A_EXPORTS #include "a.h" BOOL APIENTRY DllMain( HANDLE hModule, DWORD ul_reason_for_call, LPVOID lpReserved ) { return TRUE; } A::A() : a_(0) {} A::A(int a) : a_(a) {} void A::DoSomething(int b) { a_ += b; } int A::Result() const { return a_; }
DLL used in b.cpp, built with cl -EHsc b.cpp a.lib:

b.cpp

#include <iostream> #include "a.h" int main(int argc, char** argv) { A a(argc); a.DoSomething(3); std::cout << a.Result() << std::endl; } Builds fine, runs OK and even produces the right result...which is nice.

modified on Saturday, December 20, 2008 6:19 AM

[George_George]

Cool, Stuart! regards, George