sprintf?

[dec82]

void *ptrList [30]; char ss [40]; for (i = 0; i<26; i++) { if (ptrList [i]) sprintf(ss, "%s", *(CString *) ptrList [i]); } What do those code do? Thanks.

[Nibu babu thomas]

hung1984 wrote:

if (ptrList [i]) sprintf(ss, "%s", *(CString *) ptrList [i]);

From the code... ptrList is an array of CString pointers which for some reason is kept as void pointers, but the developer knows it's internally CString* so he is "confidently" casting it to CString* then copying the CString value to a character buffer (ss). Confusing at times and also he forgot another step to cast *(CString*) to LPCTSTR and to use _stprintf instead of sprintf. So after correction the code will look like...

void *ptrList [30];
char ss [40];
for (i = 0; i<26; i++)
{
if (ptrList [i])
{
LPCTSTR lpctszStr = (LPCTSTR)(*(CString *) ptrList [i]);
_stprintf(ss, "%s", lpctszStr);
}
}

Nibu babu thomas Microsoft MVP for VC++ Code must be written to be read, not by the compiler, but by another human being. Programming Blog: http://nibuthomas.wordpress.com

[ThatsAlok]

hung1984 wrote:

if (ptrList [i]) sprintf(ss, "%s", *(CString *) ptrList [i]);

it's copying content of ptlist to ss!

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow
Never mind - my own stupidity is the source of every "problem" - Mixture

cheers, Alok Gupta VC Forum Q&A :- I/IV Support CRY- Child Relief and You

[dec82]

what the statement for if here ? if (ptrList [i])

[PCuong1983]

You just only declare a array of void pointer like void* ptrList[30]; and no initialize for them. so ptrList[i] point to a value that has no type (and thus also an undetermined length and undetermined dereference properties). ptrList[i] is now == 0x?????????? and if(ptrList[i]) is now similar if(true) let me know if i am wrong

[David Crow]

Can't you just use the debugger to find out? Otherwise, you're just programming "in the dark."

"Love people and use things, not love things and use people." - Unknown

"The brick walls are there for a reason...to stop the people who don't want it badly enough." - Randy Pausch

[Stephen Hewitt]

Looks like bad code to me.

Steve