New layout problem [modified]

[Hans Dietrich]

Problem: opening a child post will be displayed off the top of the window if the parent post is not entirely visible. Steps:

1. Open up this post: http://www.codeproject.com/Lounge.aspx?msg=2895800#xx2895800xx[^]
2. Scroll browser window so that the start of Joan's post is above the top of the window.
3. Click on the first child post (by Perspx). His post is displayed above the top of the window.

Details: FF2 and IE6, Layout=Normal Ctrl-F5 hit: Yes

Best wishes, Hans

---

[CodeProject Forum Guidelines] [How To Ask A Question] [My Articles]

modified on Sunday, January 25, 2009 1:13 PM

[Alan N]

I see this too. I'm using IE6, XP, display 1400 x 1050 and 144 dpi. Alan N.

[Shog9 0]

CP is no longer rendering in Quirks Mode. Therefore, the function EnsureMessageVisible() in ShortCuts.js must be updated to work with the documentElement (rather than body) as the scroll container:

function EnsureMessageVisible(msgID, bShowTop)
{
   var msgHeader = document.getElementById("F" + msgID + "_h0");
   var msgBody = document.getElementById("F" + msgID + "_h1");

if (!msgBody||!msgHeader)return;

// determine scroll position of top and bottom
   var scrollContainer = document.documentElement;
   var top = getRealPos(msgHeader, 'Top');
   var bottom = getRealPos(msgBody, 'Top') + msgBody.offsetHeight;

// if not already visible, scroll to make it so
   if ( scrollContainer.scrollTop > top && !bShowTop)
      scrollContainer.scrollTop = top - scrollContainer.clientHeight/10;
   if ( scrollContainer.scrollTop+scrollContainer.clientHeight < bottom)
      scrollContainer.scrollTop = bottom-scrollContainer.clientHeight;
   if ( scrollContainer.scrollTop > top && bShowTop)
      scrollContainer.scrollTop = top - scrollContainer.clientHeight/10;
}

(changes in bold - yes, there appears to be something of a regression WRT the message ID)

[Chris Maunder]

All fixed. Shog: add another beer to the tally. Or even a good red if you prefer.

cheers, Chris Maunder

CodeProject.com : C++ MVP

[Chris Richner]

same problem with IE 8 Beta 2

Chris Richner, raccoom.net

[Shog9 0]

The new menu is thanks enough. Seriously.

----

You're right. These facts that you've laid out totally contradict the wild ramblings that I pulled off the back of cornflakes packets.