CListBox

Davitor

Ok here i am try to do.i don't know it's a right or not.Code is here

UINT WorkerThreadProc( LPVOID Param );
UINT WorkerThreadProc(LPVOID Param)
{

CStdioFile file;
CString readstring;

if(file.Open(log1, CFile::modeRead | CFile::modeNoTruncate))
{

CString readstring
while(file.end)
{
int i=0;

			file47.ReadStringreadstring.Trim());
			
			if(readstring.IsEmpty())
			{
				
			break;
			}
			else
			{
				for(;i<1000;)
				{
				m\_listba.InsertString(i,readstring);
				break;
				}
				i++;
					
			}
		
		}	


file.Close();

}

return TRUE;

}

void CABC::OnBnClickedButton3()
{

AfxBeginThread(WorkerThreadProc,NULL,THREAD\_PRIORITY\_NORMAL,0,0,NULL);
			WaitForSingleObject(WorkerThreadProc, INFINITE);

}

It's working but when i click on OKButton then it's show Assertion Failed Afxwil2.inl Line 731. Plz help me

CPallini

That's exactly what Cédric suggested you NOT to do. :rolleyes: :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles]

Cedric Moonen

So, you didn't even read my reply did you ?

Cédric Moonen Software developer
Charting control [v1.5] OpenGL game tutorial in C++

Cedric Moonen

By the way, two remarks: 1) How does this code even compile ? How can you access your m_listba variable from your thread ? Is it a global variable X| ? 2) What's the purpose of doing that in a thread if you call WaitForSingleObject just afterwards anyway ? :doh:

Cédric Moonen Software developer
Charting control [v1.5] OpenGL game tutorial in C++

Davitor

yaa m_listba is global variable.Just i try to impliment it from example of Codeproject.

Sophiya Chen

Cedric Moonen is right,it's better that UI put in the UI thread.generate data in other thread. :-D

Cedric Moonen

(I'm gonna reply to your original message that you deleted)

MsmVc wrote:

Plz help me

Help yourself and read the article I linked to you. Threading is not a simple subject that can be explained in 3 lines. If you want to use multithreading and understand what you are doing, then you'll need to spend a bit more time than asking a question on a forum.

MsmVc wrote

Yes m_listba is global variable.

That's really ugly, you should make it a member of your dialog class. You can't access it from your thread so why making it a global varialbe ? And by the way, the "m_" suffix is usually applied to class member variables (m for member). If you use it on a global variable, it is totally confusing.

Cédric Moonen Software developer
Charting control [v1.5] OpenGL game tutorial in C++

CPallini

Davitor wrote:

yaa m_listba is global

To fool the enemy? :-D

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles]

Davitor

sorry m_listba is member variable..

Cedric Moonen

Then your code cannot compile (unless I missed something or you didn't post everything). Anyway, we can discuss the whole day about minor details as this, it still won't make your code work because you can't access UI elements (like the list box) from a separate thread. Serioulsy, I have the impression to talk to a wall here :sigh: ... Did you read that damn article finally ?

Cédric Moonen Software developer
Charting control [v1.5] OpenGL game tutorial in C++

Davitor

yaa i read it.My problem is that i have a file which have a somany data and i want to insertdata into ListBox through thread.I am useing thread becouse without thread my Dialog is showing Not responding. I read article which is given by you.But i need some example to do that.Plz help me

modified on Friday, March 27, 2009 5:28 AM

CPallini · modified on Friday, March 27, 2009 5:28 AM

The worker thread shouldn't directly manipulate the GUI. It should instead post a message to the GUI thread, with in turns updates the GUI. It's not difficult, instead of calling InsertString from within the thread, call PostMessage with appropriate data. On receiving the message, the GUI thread will call InsertString. :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles]

Christian Graus · modified on Friday, March 27, 2009 5:28 AM

The basic issue is that you're a retard. You've had explained to you why you can't do it, the framework it throwing exceptions, because you can't do it, and you're still trying to do it. Perhaps you should learn VB, or even Logo ?

Christian Graus Driven to the arms of OSX by Vista.

Cedric Moonen

The point is that everything is explained in the article, with an example and everything. And the example is about a list box being "populated" from a worker thread (through a message sent to the UI). So, I think this is a lost cause :sigh:

Cédric Moonen Software developer
Charting control [v1.5] OpenGL game tutorial in C++

CPallini

Christian Graus wrote:

Perhaps you should learn VB

I supposed it was already in the 'Retard's Toolbox'. :-D

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles]

Davitor

Thanks solved