Trouble with loops

[StateofMind09]

I've got an assignment that I've been struggling with all day, and after re-doing the program several times I believe I've narrowed down my problem to this:

#include #include int random;
int guess;
char play = 'y';
int game = 1;

int main()
{
while(game == 1)
{
if(play == 'y')
{
random = 1 + rand() % 1000;

	printf("\\nI have a number between 1 and 1000.\\nCan you guess my number?\\nType your first guess:");

	play = 'v';

}
	scanf("%i",&guess);

	if(guess == random)
	{
		printf("\\nExcellent! You guessed the number!\\nWould you like to play again?(y/n)");
		scanf("%c",&play);
		if(play == 'n')
		{
			 game = 0;
		}
	}

	else
	{
		if(guess < random && guess != random)
		{
			printf("\\nToo low, try again!");
		}

		if(guess > random && guess != random)
		{
			printf("\\nToo high, try again!");
		}
	}
}

	return 0;

}

When I enter the if(guess == random){} block and answer the (y/n) question, the program falls apart. No matter what I seem to do, it'll shut down, stop functioning, or repeat that block once more before it moves on to what it's supposed to do. I don't understand what I'm doing wrong.

[ShiXiangYang]

your program is too difficult to get the right number. because every time after one loop your random have changed, who can guess a unmber just equal one random number form 1 to 1000.

[CPallini]

StateofMind09 wrote:

if(guess < random && guess != random) { printf("\nToo low, try again!"); } if(guess > random && guess != random) { printf("\nToo high, try again!"); }

Funny. :-D Do you really think

if ( guess < random )
{
//...
}
else
{
//..
}

is not enough? [added] BTW: It shouldn't 'fall apart'. Why don't you use the debugger to see what actually happens? [/added] :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles]

modified on Thursday, April 23, 2009 4:11 AM

[Stuart Dootson]

Your problem is that when you enter the correct guess, you type a return character after the number to terminate the line. The scanf("%c",&play); line will then read that character as your (first) response, rather than the 'y' or 'n'. I would recommend altering that bit of the program into a loop, so it validates your input, so instead of this:

		scanf("%c",&play);
		if(play == 'n')
		{
			 game = 0;
		}

have this:

     do
     {
        scanf("%c", &play);
     } while (play != 'y' && play != 'n');
     if(play == 'n')
     {
        game = 0;
     }

Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p