Switch Statement from Hell

[Luc Pattyn]

Well, that is what you can get when applying the principles of self-documenting code. :)

Luc Pattyn [Forum Guidelines] [My Articles]

---

Avoiding unwanted divs (as in "articles needing approval") with the help of this FireFox add-in

---

[Jeroen De Dauw]

*Attempted to write a reply but got a heart attack while having a second look at the code* Cheers :) BN

GSoC 2009 student for SMW! --- My little forums: http://code.bn2vs.com --- 70 72 6F 67 72 61 6D 6D 69 6E 67 20 34 20 6C 69 66 65!

[ricmil42]

Brady Kelly wrote:

Switch Statement from Hell

You were NOT exaggerating!

[Spunky Coder]

Thank God! There are only 8 levels!!

"Don't worry if it doesn't work right. If everything did, you'd be out of a job." (Mosher's Law of Software Engineering)

[Super Lloyd]

What about the other case statements? I'm curious now!! ;)

A train station is where the train stops. A bus station is where the bus stops. On my desk, I have a work station.... _________________________________________________________ My programs never have bugs, they just develop random features.

[Brady Kelly]

OK, that was the last one, here are the first two.. You should be able to infer the rest.

                case "LEFT JOIN Extensions ON CallRecords.Ext\_ID = Extensions.Ext\_ID LEFT JOIN Level1 ON Extensions.LevUp\_ID = Level1.Lev\_ID LEFT JOIN CAT ON CallRecords.Cat\_ID = CAT.Cat\_ID ":
                    strSQL = strSQL + "Sites.SiteName, Sites.ReportCentre, Level1.LevelCode, Level1.LevelName, ";
                    strSQLGROUPandORDER = "GROUP BY Sites.SiteName, Sites.ReportCentre, Level1.LevelCode, Level1.LevelName ORDER BY Sites.SiteName, Sites.ReportCentre, Level1.LevelCode, Level1.LevelName;";
                    break;

                case "LEFT JOIN Extensions ON CallRecords.Ext\_ID = Extensions.Ext\_ID LEFT JOIN Level1 ON Extensions.LevUp\_ID = Level1.Lev\_ID LEFT JOIN Level2 ON Level1.LevUp\_ID = Level2.Lev\_ID LEFT JOIN CAT ON CallRecords.Cat\_ID = CAT.Cat\_ID ":
                    strSQL = strSQL + "Sites.SiteName, Sites.ReportCentre, Level2.LevelCode, Level2.LevelName, ";
                    strSQLGROUPandORDER = "GROUP BY Sites.SiteName, Sites.ReportCentre, Level2.LevelCode, Level2.LevelName ORDER BY Sites.SiteName, Sites.ReportCentre, Level2.LevelCode, Level2.LevelName;";
                    break;

You really gotta try harder to keep up with everyone that's not on the short bus with you. - John Simmons / outlaw programmer.

[Super Lloyd]

I see, mmm... Really the original programmer should have foreseen the problem and use Emit to dynamically generate/compile a method for an ever increasing number of case! :cool: :laugh:

A train station is where the train stops. A bus station is where the bus stops. On my desk, I have a work station.... _________________________________________________________ My programs never have bugs, they just develop random features.

[OriginalGriff]

Super Lloyd wrote:

A train station is where the train stops. A bus station is where the bus stops. On my desk, I have a work station....

:laugh: :laugh: :laugh: I want to steal your signature!

No trees were harmed in the sending of this message; however, a significant number of electrons were slightly inconvenienced. This message is made of fully recyclable Zeros and Ones

[Super Lloyd]

Ho no... I already stole it from someone else, you can't steal it from me!!! :rolleyes:

A train station is where the train stops. A bus station is where the bus stops. On my desk, I have a work station.... _________________________________________________________ My programs never have bugs, they just develop random features.

[BillW33]

I have to say that is the worst switch statement that I have ever seen and I have seen some pretty bad ones :sigh: Bill W

Just because the code works, it doesn't mean that it is good code.