Dynamic char Array

jlgeris

Essentially, I'm reading some names from a text file, and I need to allocate the array at runtime. I'm missing something regarding the allocation of each individual name. After I copy the first name into the array slot, it fills up every spot in the array with the first value. After the loop finishes I have an array with [count] copies of the initial value I read from the file. I'm using the StreamReader class in other places in the program so that's why I'm marshaling the string to a char*. Maybe not the ideal solution, but I believe the problem is separate from that.

char **temp=NULL;
my_malloc((void**)&temp,count*sizeof(char*));

StreamReader^ din = File::OpenText(fileName);
String^ str;

while ((str = din->ReadLine()) != nullptr)
{
char* x = (char*)System::Runtime::InteropServices::Marshal::StringToHGlobalAnsi(str).ToPointer();
my_malloc((void**)&temp[count],strlen(x)*sizeof(char)+1); //i imagine the problem is here
strcpy(temp[count],x); //or here
System::Runtime::InteropServices::Marshal::FreeHGlobal((IntPtr)x);
count++;
}

The my_malloc function is just a wrapper around free() and malloc(). Thanks for the help.

jlgeris

FYI

	int my\_malloc(void \*\*param\_adr,	int param\_size)
	{
		my\_free(param\_adr);
		if ((\*param\_adr = malloc(param\_size)) == NULL)
		{				
			return -1;
		}
		memset(\*param\_adr,0,param\_size);			
		
		return 0;
	}

	void my\_free(void \*\*param\_adr)
	{
		if (\*param\_adr != NULL)
		{
			free(\*param\_adr);
			\*param\_adr = NULL;
		}
		return;
	}

_Superman_

You're mixing managed and unmanaged code in a very strange way.

«_Superman_» I love work. It gives me something to do between weekends.

jlgeris

I know. This was the quick and dirty solution, but i'm open to alternatives.

Stuart Dootson

How about using an [array](http://msdn.microsoft.com/en-us/library/ts4c4dw6\(VS.80\).aspx)<[String](http://msdn.microsoft.com/en-us/library/system.string\(VS.80\).aspx)^>^ (i.e. a C++/CLI array of C++/CLI strings) instead of standard C types?

Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p

jlgeris

Well, I need the array in that format because I'm working with another proprietary API that works only with standard C types.

Stuart Dootson

jlgeris wrote:

temp[count]

When you allocated temp, you allocated temp[0] to temp[count-1] - temp[count] is undefined. Either use a different index variable or reset count to 0

jlgeris wrote:

strlen(x)*sizeof(char)+1

As sizeof(char)==1, it makes no difference, but you really wanted (strlen(x)+1)*sizeof(char)

Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p