Enumerator

[CodingYoshi]

I have a class which has a dictionary and I don't want to reveal this information to the outside. So I simply made it a private member. I want people to enumerate through my class so I did the following: public class CustomerCollection : IEnumerable<KeyValuePair<string, Customer>> { #region IEnumerable<KeyValuePair<string,Store>> Members public IEnumerator<KeyValuePair<string, Customer>> GetEnumerator() {       return this._districts.GetEnumerator(); } #endregion #region IEnumerable Members IEnumerator IEnumerable.GetEnumerator() {       return this._districts.GetEnumerator(); } #endregion } This works fine but during enumeration, the client has to write code as below: foreach (KeyValuePair<string, Customer> c in this._customers) // _customers is an instance of CustomerCollection { c.Value.Name = "Whatever"; } What should I do if I want the client to be able to do this: foreach (Customer c in this._customers) { c.Name = "whatever"; }

CodingYoshi Artificial Intelligence is no match for Human Stupidity.

[Adam R Harris]

Have CustomerCollection contain a list of Customer objects So your code should look something like this. NOTE: this is not tested and probably wont compile

public class Customer
{
    public string Name{get; set;}
    ...
}

public class CustomerCollection : CollectionBase
{
    public Customer this[int index]{
        get{ return innerList[index];}
        set{ innerList[index] = value;}
    }

    public void Add(Customer item){
       innerList.Add(item);
    }
}

If you inherit CollectionBase (System.Collections.Specialized i think) you don't to inherit or even implement IEnumerable because CollectionBase does all the dirty work for you.

If at first you don't succeed ... post it on The Code Project and Pray.

[DaveyM69]

I've never tried it, but it might work if you can provide an implicit conversion operator from Customer to KeyValuePair<string, Customer> although intellisense will still show as wanting a KeyValuePair so it wouldn't be intuitive. You may need to wrap the dictionary a little more to provide a different enumerator.

Dave
BTW, in software, hope and pray is not a viable strategy. (Luc Pattyn)
Visual Basic is not used by normal people so we're not covering it here. (Uncyclopedia)
Why are you using VB6? Do you hate yourself? (Christian Graus)

[Alan N]

Hi, If you expose the Dictionary's value collection you will get this functionality.

Dictionary<string, Customer> dic;
ICollection<Customer> Customers {
  get { return this.dic.Values; }
}

I think that's all you need as the value collection is enumerable. Alan.

[N a v a n e e t h]

CodingYoshi wrote:

What should I do if I want the client to be able to do this: foreach (Customer c in this._customers) { c.Name = "whatever"; }

How about this?

public class CustomerCollection : IEnumerable<Customer>
{
public IEnumerator<Customer> GetEnumerator()
{
foreach(KeyValuePair<string,Customer> item in _districts)
yield return item.Value;
}

System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator()
{
    return GetEnumerator();
}

}

:)

Navaneeth How to use google | Ask smart questions

[CodingYoshi]

I don't want to inherit because I want to hide the interface of the inner collection. Also, I want this to be a readonly collection.

CodingYoshi Artificial Intelligence is no match for Human Stupidity.

[CodingYoshi]

Thanks! That is exactly what I am looking for. I will give that a try and let you know if it works; although, it looks as it should.

CodingYoshi Artificial Intelligence is no match for Human Stupidity.