Code In Need Of Cleanup [modified]

Kevin Marois

Not the worst code I've seen, but it's bad. This is typical code worked on by multiple developers over time. The class this is in has over 5000 lines of code. All of it looks like this.

/* Get Shop Order Details.*/
DataTable dtShopOrder;

if(sSNInPK.ToLower()=="yes;")
dtShopOrder = new ERP().GetShopOrderDetails(txtSerialNum.Text);
else
dtShopOrder = new Operation().GetShopOrderDetails(txtSerialNum.Text);

if(dtShopOrder == null || dtShopOrder.Rows.Count <=0)
{
this.showMessage("Cannot find the serial number. Please contact your System Administrator.", MessageType.Warning);
return;
}

txtShopOrder.Text = dtShopOrder.Rows[0]["ShopOrder"].ToString();
txtAssembly.Text = dtShopOrder.Rows[0]["Assembly"].ToString();
txtRev.Text = dtShopOrder.Rows[0]["Revision"].ToString();
txtCUCode.Text = dtShopOrder.Rows[0]["CUCODE"].ToString();
txtCustomer.Text = dtShopOrder.Rows[0]["CUNAME"].ToString();
txtQty.Text = dtShopOrder.Rows[0]["Qty"].ToString();

/*START >> For enhancement - Sub assembly serial number management(9th June 2009)*/

strSubAsmWC = "";
try
{

if(dtShopOrder.Rows\[0\]\["SubAsmWC"\] != null)
{
	strSubAsmWC = dtShopOrder.Rows\[0\]\["SubAsmWC"\].ToString();
}

}
catch
{
strSubAsmWC = "";
}

/*End >> For enhancement - Sub assembly serial number management (9th June 2009)*/

/*START >> For enhancement - assigning Customer Label/MAC Addresses (1st Feb 2007)*/

iCustOpNum = -1;
iMACOpNum = -1;
iMACCount = -1;
strCustLabel = "";
strMACAddress = "";

if(dtShopOrder.Rows[0]["iCustLabelOpNum"] != null)
{
try
{
iCustOpNum = int.Parse(dtShopOrder.Rows[0]["iCustLabelOpNum"].ToString());
}
catch
{

}

if(dtShopOrder.Rows[0]["iMacAddressOpNum"] != null)
{
try
{
iMACOpNum = int.Parse(dtShopOrder.Rows[0]["iMacAddressOpNum"].ToString());
}
catch
{

}

if(dtShopOrder.Rows[0]["iMacAddressCount"] != null)
{
try
{
iMACCount = int.Parse(dtShopOrder.Rows[0]["iMacAddressCount"].ToString());
}
catch
{

}

if(dtShopOrder.Rows[0]["CustLabel"] != null)
strCustLabel = dtShopOrder.Rows[0]["CustLabel"].ToString();

if(dtShopOrder.Rows[0]["MacAddress"] != null)
strMACAddress = dtShopOrder.Rows[0]["MacAddress"].ToString();

/*END >> For enhancement - assigning Customer Label/MAC Addresses (1st Feb 2007)*/

Found this in there also

if(slAppConfig[AppConfig.Keys.address_defect_wc.ToString()].ToString().IndexOf(lblWCKey.Text + ";",0)>=0
|| lblWCKey.Text == this.GetC

GibbleCH

Looks like you maintain the same persons code I do! :laugh: I swear this guy has only heard of the string datatype. Everything is in strings, booleans "true", "false". And my favorite, arrays "1|12|34|56|". :^)

AspDotNetDev

GibbleCH wrote:

arrays "1|12|34|56|"

Depends on the language. In VB6, you do not have array initializers. Loading a list by parsing a string can be a very compact way of presenting code. Not as fast as manually setting each array element, but it does make the code shorter and still readable.

Visual Studio is an excellent GUIIDE.