Moving from validation function to validation read only Property
-
Hi, I was writing a validation function. Which is as follows
private void IsFolderValid1()
{
return false;
}and somebody suggested me to write it in following way.
private void IsFolderValid1()
{
Get
{
return false;
}
}Can u please explain me the reason. Whether it is right or wrong ? Thanks
-
Hi, I was writing a validation function. Which is as follows
private void IsFolderValid1()
{
return false;
}and somebody suggested me to write it in following way.
private void IsFolderValid1()
{
Get
{
return false;
}
}Can u please explain me the reason. Whether it is right or wrong ? Thanks
-
Hi, I was writing a validation function. Which is as follows
private void IsFolderValid1()
{
return false;
}and somebody suggested me to write it in following way.
private void IsFolderValid1()
{
Get
{
return false;
}
}Can u please explain me the reason. Whether it is right or wrong ? Thanks
Hi, none of that is correct, for several reasons: 1. if a property or method returns "false" its type should be boolean, not void. 2. property and method names normally shouldn't contain digits 3. method names normally contain a verb, and property names may or may not (preferably not, although IsValid would be acceptable) 4. private members use pascalCase, public ones CamelCase. 5. properties should always be public (protected could be OK, private is a bit strange). 6. properties don't take parentheses. So choose one of these:
public boolean IsFolderValid() { ... return false;}
public boolean FolderValid {
get { ... return false; }
}:)
Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles]
I only read code that is properly indented, and rendered in a non-proportional font; hint: use PRE tags in forum messages