a fscanf error in MFC SDI

[CHYGO]

my code:

#include "stdafx.h"
#include <stdio.h>
#include <fstream>

void CParamDisplay::OnParamOpen()
{
// TODO: Add your control notification handler code here
CFileDialog cfiledlg(TRUE, NULL, NULL, OFN_HIDEREADONLY | OFN_OVERWRITEPROMPT
, "Text Files (*.txt)|*.txt|All Files (*.*)|*.*||", this);

if (IDOK == cfiledlg.DoModal())
{
	m\_filename = cfiledlg.GetPathName();
	UpdateData(FALSE);
	DisplayParam(m\_filename);
}	

}

BOOL CParamDisplay::DisplayParam(CString filename)
{
UINT sNum = 0;
CHAR paramId[MAX_BUF_SIZE] = _T("");
CHAR paramUnit[MAX_BUF_SIZE] = _T("");
FLOAT paramValue = 0;

FILE\* pFile = fopen (filename, "r");

if(pFile == NULL)
	return FALSE;

while(fscanf(pFile, "%d %s %s %f", sNum, paramId, paramUnit, paramValue) != EOF)
{
     ...
}

fclose(pFile);

return TRUE;

}

when i debug it, the app stopped at fscanf().and displayed:"Uhandled exception in XX.exe (MSVCRTD.DLL):0XC00000005:access violation".i can't fix it...(T_T)

i 've tried ,then i have no regret

[Garth J Lancaster]

what is MAX_BUF_SIZE defined as ? what does your data in the file look like ? the access violation reported is most commonly caused by overwriting memory somehow - not allocating it/enough - I can see you are allocating buffers for your char (string) arrays, but for instance if MAX_BUF_SIZE was 5 and you had 1 thisisacharastring thisisanothercharstring 1.44 you'd see that the first %s in fscanf would get thisisacharastring which is a bit longer than 5 'g'

[Bram van Kampen]

try: while(fscanf(pFile, "%d %s %s %f", **&**sNum, paramId, paramUnit, **&**paramValue)... :)

Bram van Kampen

[Garth J Lancaster]

chuckle, I missed that one completely 'g'

[Bram van Kampen]

Easy thing to Miss! Chased one similar to that last week in my own code for 2 hours. At least the OP set it to '0' (NULL) to begin with. I had not done so, and made it far more difficult to trace. :)

Bram van Kampen

[CHYGO]

thank u, i've tried the Bram van Kampen's method,it works:)

i 've tried ,then i have no regret

[CHYGO]

:) it works.it takes me about three hours to try to solve it. thank u very mnuch.

i 've tried ,then i have no regret