CString conversion problem

User 589870

Hi, i m reading value from ini file and reading into CString.values are stored in japanese language in ini file.now when i convert CString into WCHAR it turns into garbage value.any solution?

Mohan Ramachandra

How are you converting?

User 589870

CString name; WCHAR disname[100]={0}; name= m_IniReader.getKeyValue(str,"VIEWNAME");; wcscpy(disname, A2W((LPCSTR)name)); like this?

Mohan Ramachandra

Try this :)

    WCHAR disname\[100\]={0};
CStringW name;
    name= m\_IniReader.getKeyValue(str,"VIEWNAME");
wcscpy(disname, (LPCWSTR)name.GetBuffer(100));
MessageBoxW(NULL,disname,disname,MB\_OK);
name.ReleaseBuffer(100);

Cedric Moonen

Mohan Ramachandra wrote:

wcscpy(disname, (LPCWSTR)name.GetBuffer(100));

No, calling GetBuffer is really a very bad practice. You shouldn't do that, the CString class already provides cast operators so there's no need to call GetBuffer ! And the the case is probably no needed neither, but that depends how the project was compiled (UNICODE or not).

Cédric Moonen Software developer
Charting control [v3.0] OpenGL game tutorial in C++

Cedric Moonen

I suggest you read this excellent article[^]. You'll understand much more about string manipulation afterward.

Cédric Moonen Software developer
Charting control [v3.0] OpenGL game tutorial in C++

rajajay82

i heard a lot of time calling GetBuffer a bad practice, why do so?

Ajayraj

Adam Roderick J

Did u check the whether you are getting the japanese text in CString? And i hope its a UNICODE build.

Величие не Бога может быть недооценена.

CPallini

GetBuffer (as the name suggests) exposes the internal buffer of the CString object. Moreover you must remember to call ReleaseBuffer when you've done with it. Most of the times, you really don't need to call it. :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles]

Cedric Moonen

Because if you read the documentation of the function, you will see that you get a pointer to the internal buffer of the string and that you HAVE to call ReleaseBuffer afterward (which will be often forgotten). Furthermore, why would you use GetBuffer, while the CString provides a cast operator which returns you the same thing ? Calling GetBuffer can lead to mistakes if you forget to call ReleaseBuffer.

Cédric Moonen Software developer
Charting control [v3.0] OpenGL game tutorial in C++

User 589870

yes i m getting japanese text in CString.

Mohan Ramachandra

Cedric Moonen wrote:

No, calling GetBuffer is really a very bad practice. You shouldn't do that, the CString class already provides cast operators so there's no need to call GetBuffer !

Thanks, I didn't know that

Adam Roderick J

Please check whether _UNICODE preprocessor is added in your project setting.

Величие не Бога может быть недооценена.

Raj Jaiswal

CString name; WCHAR disname[100]={0}; name= m_IniReader.getKeyValue(str,"VIEWNAME");; wcscpy(disname, A2W((LPCWSTR)name)); Use this code. And make sure that your project build support UNICODE.

Raj Jaiswal