method parameters error

Abhinav S

Remove the return from inside the while loop and place it outside. Return a collection of ZoneCodes instead of doing what you have done above.

SqlConnection con1 = new SqlConnection();
con1.ConnectionString = ConfigurationManager.ConnectionStrings["Connectionstring"].ToString();
string sql1 = "select " + colu + " from " + tbl + " where " + cond1 + " ='" + value1 + "' and " + cond2 + " = " + value2 + "";
SqlCommand cmd1 = new SqlCommand(sql1, con1);
con1.Open();
SqlDataReader dr = cmd1.ExecuteReader();
List objList = new List();
while (dr.Read())
{
objList.Add(dr["ZoneCode"].ToString(););
}
return objList;
con1.Close();

You method signature will be

public List ReturnString(string tbl, string colu, string cond1, string value1, string cond2, string value2)

Sorry. I cannot include this code in the

tags. The generics part is getting messed up.

Abdul Rhman Alsri

Compiler Error Message: CS0246: The type or namespace name 'List' could not be found (are you missing a using directive or an assembly reference?)

Abhinav S

Abdul-Rhman Alsri wrote:

Compiler Error Message: CS0246: The type or namespace name 'List' could not be found (are you missing a using directive or an assembly reference?)

You need to include the Systems.Collection.Generic namespace.

modified on Sunday, May 2, 2010 2:43 AM

Pete OHanlon

A slight correction to this code moves the line con1.Close before the return - it's unreachable code, but you could always set ExecuteReader with the parameter CommandBehavior.CloseConnection to shut the connection automatically. I'd also suggest wrapping the code in using blocks to trigger disposal of the objects.

using (SqlConnection con1 = new SqlConnection())
{
con1.ConnectionString = ConfigurationManager.ConnectionStrings["Connectionstring"].ToString();
string sql1 = "select " + colu + " from " + tbl + " where " + cond1 + " ='" + value1 + "' and " + cond2 + " = " + value2 + "";
using (SqlCommand cmd1 = new SqlCommand(sql1, con1))
{
con1.Open();
using (SqlDataReader dr = cmd1.ExecuteReader())
{
List<string> objList = new List<string>();
while (dr.Read())
{
objList.Add(dr["ZoneCode"].ToString(););
}
return objList;
}
}
}

"WPF has many lovers. It's a veritable porn star!" - Josh Smith

As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

My blog | My articles | MoXAML PowerToys | Onyx

Abhinav S

Thanks - I completely missed the close() statement. :)

Pete OHanlon

No problems. It's the joy of coding directly in the html textbox. :-D

"WPF has many lovers. It's a veritable porn star!" - Josh Smith

As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

My blog | My articles | MoXAML PowerToys | Onyx

Abhinav S

Pete O'Hanlon wrote:

No problems. It's the joy of coding directly in the html textbox

I messed up the "dry run". :)

Abdul Rhman Alsri

List<string> ZoneCode = ReturnZoneCode("select ZoneCode from AdZone where ID = 20 and AccountID=530");
TextBox1.Text = Convert.ToString(ZoneCode.ToString());

In the code above I called the function(Note: I edited the signature) and I want to bind the returned List into a textbox. Problem what I have that the Textbox is not bounded the the value returned from the call, but it had the following: "System.Collections.Generic.List`1[System.String]"

Pete OHanlon

That's because ToString returns this type of information on a list. If you want to display the values, you need to actually bind to an individual item.

"WPF has many lovers. It's a veritable porn star!" - Josh Smith

As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

My blog | My articles | MoXAML PowerToys | Onyx

Abdul Rhman Alsri

how? give me code in c#

Pete OHanlon

Well, suppose you wanted to display a list of all of the items in a textbox, you could use:

private void BindZones(List<string> zones)
{
StringBuilder sb = new StringBuilder();
foreach (string item in zones)
{
sb.AppendFormat("{0}{1}", item, Environment.NewLine);
}
TextBox1.Text = sb.ToString();
}

To be honest though - you would be better off displaying this in a ListBox rather than a Textbox.

"WPF has many lovers. It's a veritable porn star!" - Josh Smith

As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

My blog | My articles | MoXAML PowerToys | Onyx

Abdul Rhman Alsri

I got a null value. please help me to return a string and not

List

I'd like to change to the previous one... :)

Pete OHanlon

Your code is missing - please show it.

"WPF has many lovers. It's a veritable porn star!" - Josh Smith

As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

My blog | My articles | MoXAML PowerToys | Onyx

Abdul Rhman Alsri

I want the function to return a string and not a list string Function:

public List<string> ReturnZoneCode(string sql1)
{
using (SqlConnection con1 = new SqlConnection())
{
con1.ConnectionString = ConfigurationManager.ConnectionStrings["Connectionstring"].ToString();
//string sql1 = "select " + colu + " from " + tbl + " where " + cond1 + " ='" + value1 + "' and " + cond2 + " = " + value2 + "";
using (SqlCommand cmd1 = new SqlCommand(sql1, con1))
{
con1.Open();
using (SqlDataReader dr = cmd1.ExecuteReader())
{
List<string> objList = new List<string>();
while (dr.Read())
{
objList.Add(dr["ZoneCode"].ToString());
}
return objList;
}
}
}

Pete OHanlon

Use a StringBuilder instead of a list.

"WPF has many lovers. It's a veritable porn star!" - Josh Smith

As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

My blog | My articles | MoXAML PowerToys | Onyx