Start page layout broken when using AdBlockPlus
-
Hi, yes I know, you guys here really need the money from the advertisments but nonetheless one of my stations runs FireFox 3.6.12 with activated AdBlockPlus. Since one week or so, the start page of Codeproject (especially the list of recent articles) looks a bit weird. I just noticed that it's looking fine if I deactive AdBlock. Is this your way of telling us to deactivate the ad blocker? :laugh: Best regards, JF
I am sure the team will treat this as high priority.
TodoList.Add("Fix layout when user has AdBlockPlus enabled", Priority.MinValue);
Regards, Nish
My technology blog: voidnish.wordpress.com
-
Hi, yes I know, you guys here really need the money from the advertisments but nonetheless one of my stations runs FireFox 3.6.12 with activated AdBlockPlus. Since one week or so, the start page of Codeproject (especially the list of recent articles) looks a bit weird. I just noticed that it's looking fine if I deactive AdBlock. Is this your way of telling us to deactivate the ad blocker? :laugh: Best regards, JF
Purely unintentional since I don't use AdBlock. However, fixing rendering issues caused by add-ins that change our layout is, as Nish pointed out, about as low on the priority list as it gets. ;)
cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP
-
Hi, yes I know, you guys here really need the money from the advertisments but nonetheless one of my stations runs FireFox 3.6.12 with activated AdBlockPlus. Since one week or so, the start page of Codeproject (especially the list of recent articles) looks a bit weird. I just noticed that it's looking fine if I deactive AdBlock. Is this your way of telling us to deactivate the ad blocker? :laugh: Best regards, JF
Technically it is not an adblocker causing the problems, it's a 3rd party JavaScript from lakequincy.com. Using Firefox with NoScript will lead to the same layout problems, right? /M
-
Technically it is not an adblocker causing the problems, it's a 3rd party JavaScript from lakequincy.com. Using Firefox with NoScript will lead to the same layout problems, right? /M
Turning off Javascript will mean the site doesn't render the same as with Javascript since we use jQuery UI to generate the tabs. In this particular instance, though, AdBlocker is stripping out some javascript, but not all, causing unexpected* javascript errors which then cause the remaining javascript (the stuff to render the tabs) to then fail. *As opposed to the expected errors.
cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP
-
Turning off Javascript will mean the site doesn't render the same as with Javascript since we use jQuery UI to generate the tabs. In this particular instance, though, AdBlocker is stripping out some javascript, but not all, causing unexpected* javascript errors which then cause the remaining javascript (the stuff to render the tabs) to then fail. *As opposed to the expected errors.
cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP
No that's not entirely true, you see the layout problems with NoScript alone. The potential adblocker/noscript does not remove partial JavaScript, the problem is a single 3rd party external script, which if not loaded will cause the frontpage layout to fail. Surfing the rest of the site seems to work fine, I use FF with NoScript and had no problems with posting and voting. Makes me wonder why does an advertiser network have to provide executable code to thousands of users?
-
No that's not entirely true, you see the layout problems with NoScript alone. The potential adblocker/noscript does not remove partial JavaScript, the problem is a single 3rd party external script, which if not loaded will cause the frontpage layout to fail. Surfing the rest of the site seems to work fine, I use FF with NoScript and had no problems with posting and voting. Makes me wonder why does an advertiser network have to provide executable code to thousands of users?
I don't think you understood fully what I was saying. If there is no javascript then the layout is different. If javascipt is present but AdBlock removes our ad serving javascript file then our javascript throws an error (function not found) and this then causes the rest of the javascript to fail, meaning the rest of the page renders as if javascript is not enabled. I've fixed this and will have an update soon. LakeQuincy Media is CodeProject's ad serving service. The script we place on the page via LakeQuincy does all the work of (a) telling the server where the ad should be shown (and what type of ad), and (b) actually showing the ad that is returned. We've done some optimisation with that javascript so that, when viewing the page, round trips to the ad server are minimised, speeding up the entire page.
cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP
-
I don't think you understood fully what I was saying. If there is no javascript then the layout is different. If javascipt is present but AdBlock removes our ad serving javascript file then our javascript throws an error (function not found) and this then causes the rest of the javascript to fail, meaning the rest of the page renders as if javascript is not enabled. I've fixed this and will have an update soon. LakeQuincy Media is CodeProject's ad serving service. The script we place on the page via LakeQuincy does all the work of (a) telling the server where the ad should be shown (and what type of ad), and (b) actually showing the ad that is returned. We've done some optimisation with that javascript so that, when viewing the page, round trips to the ad server are minimised, speeding up the entire page.
cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP
I think Jeff Sutherland is right when he says one of the biggest problems of organisations is to remove impediments, even with help. Good luck!
-
Hi, yes I know, you guys here really need the money from the advertisments but nonetheless one of my stations runs FireFox 3.6.12 with activated AdBlockPlus. Since one week or so, the start page of Codeproject (especially the list of recent articles) looks a bit weird. I just noticed that it's looking fine if I deactive AdBlock. Is this your way of telling us to deactivate the ad blocker? :laugh: Best regards, JF
Good catch :)
-
Purely unintentional since I don't use AdBlock. However, fixing rendering issues caused by add-ins that change our layout is, as Nish pointed out, about as low on the priority list as it gets. ;)
cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP
Chris Maunder wrote:
fixing rendering issues caused by add-ins that change our layout is, as Nish pointed out, about as low on the priority list as it gets.
But thank you for fixing. I have to run AdBlockPlus, as our corporate internet is so slow. Maybe I'll turn it off selectively for CP (I have it completely turned off at home however).
-
Chris Maunder wrote:
fixing rendering issues caused by add-ins that change our layout is, as Nish pointed out, about as low on the priority list as it gets.
But thank you for fixing. I have to run AdBlockPlus, as our corporate internet is so slow. Maybe I'll turn it off selectively for CP (I have it completely turned off at home however).
The fix was not even a single line so I whacked it in. That still doesn't mean I'm not hurt, deep down, by the use of adblockers on our site ;)
cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP
-
I don't think you understood fully what I was saying. If there is no javascript then the layout is different. If javascipt is present but AdBlock removes our ad serving javascript file then our javascript throws an error (function not found) and this then causes the rest of the javascript to fail, meaning the rest of the page renders as if javascript is not enabled. I've fixed this and will have an update soon. LakeQuincy Media is CodeProject's ad serving service. The script we place on the page via LakeQuincy does all the work of (a) telling the server where the ad should be shown (and what type of ad), and (b) actually showing the ad that is returned. We've done some optimisation with that javascript so that, when viewing the page, round trips to the ad server are minimised, speeding up the entire page.
cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP
-
So this was fixed not because adblock was causing a problem with layout but because if lakequincy fell over it would cause problems with layout for everyone?
3x12=36 2x12=24 1x12=12 0x12=18
It was fixed because it was a bug in our code, regardless of what surfaced the bug.
cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP