Bubble sort in CObList [modified]

[Eugen Podsypalnikov]

// switch pObj1 and pObj2 between them ... but how ? Try it :) :

void SortDrawObjects(CDrawObjList& cList)
{
for (int i = 0; i < cList.GetCount(); i++) {
POSITION pos = cList.GetHeadPosition();
while (pos) {
POSITION posFirst = pos;
CDrawObj* pcFirst = cList.GetNext(pos);
if (pos) {
POSITION posSecond = pos;
CDrawObj* pcSecond = cList.GetNext(pos);
if (pcFirst->m_position.left > pcSecond->m_position.left) {
cList.SetAt(posFirst, pcSecond);
cList.SetAt(posSecond, pcFirst);
}
pos = posSecond;
}
}
}
}

They sought it with thimbles, they sought it with care; They pursued it with forks and hope; They threatened its life with a railway-share; They charmed it with smiles and soap. :)

[Rajesh R Subramanian]

Well, you could use the stl algorithms work with the MFC collection classes too. That's the unprecedented beauty of STL. :)

It was ever thus, the Neophiles will always rush out and get 'The Latest Thing' at a high price and with all the inherent faults - Dalek Dave.

[Lost User]

An algorithm after all is just a modus operandi. As long as a collection class, irrespective of the library that is part of, provides mechanism to insert and remove elements at any location, all the algorithms can be implemented. The performance may be not as expected due to the implementation of the classes themselves. What I am trying to say is, if you understand the algorithm and read the documentation for the collection class, it must not be difficult at all.

...byte till it megahertz... my donation to web rubbish

[mesajflaviu]

Well , it's work great ! Thank you very much !

[mesajflaviu]

If I mix MFC with STL , I wouldn't keep consistency , or not ?

[L Braun]

Try google: "sort coblist" comes up with http://www.codeguru.com/cpp/cpp/cpp_mfc/collections/article.php/c757/[^] and a lot of recommendations to drop MFC :)

[mesajflaviu]

Useful code !

[thomas michaud]

It's been a while (and I don't have my book with me) but iirc, the std::algorithm (and I think sort is in that) didn't require the structure to be a std::list. (I seem to recall standard arrays being able to be sorted with std as well.)

[Michael Waters]

If you are wedded to MFC, at least use a CObArray instead of a CObList. The algorithim will be much cleaner and faster with a smaller memory footprint. For instance ...

typedef CTypedPtrArray<> CDrawObjArray;

then create the array ...

CDrawObjArray ObjArray;

const unsigned int nSize = 5;

ObjArray.SetSize(nSize);

fill the array ...

for(int i = 0; i < nSize; i++)
{
CDrawObj* pObj = new CDrawObj(CRect(ptOrigin,sizeRect));

ObjArray\[i\] = pObj;

}

and finally sort the array (using the most inefficient sorting algorithim known to man).

for(int i = 0; i < nSize; i++)
{
for(int j = i; j < nSize; j++)
{
unsigned int nPrevious = ObjArray[j-1]->m_position.left;
unsigned int nCurrent = ObjArray[j]->m_position.left;

    if(nPrevious > nCurrent)
    {
        CDrawObj\* pObj = ObjArray\[j-1\];

        ObjArray\[j-1\] = ObjArray\[j\];
        ObjArray\[j\] = pObj ;
    }
}

}

[David Crow]

Michael Waters wrote:

...(using the most inefficient sorting algorithim known to man).

I can think of one worse.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Man who follows car will be exhausted." - Confucius

[mesajflaviu]

Guys , you're overcome me with solutions !!! I want to kindly thank you ! I was learn something here .And after all , seems to must begin use STL ... I will googling and see what I find ... You are very kind !