At least this one was easy to refactor...

[Rob Grainger]

I'm no fan of goto at the best of times, but at least this one disappeared quickly:

    If Not rsTest.EOF Then
        rsTest.MoveLast
     
        If Format(rsTest!OKDATE, "yyyy/mm/dd") > Format(cutOffDate, "yyyy/mm/dd") Then
            dataStat = "2"
            GoTo UpdAccount
        End If
    End If

UpdAccount:

I kid you not!

[fjdiewornncalwe]

I'm not quite sure if the GoTo is the horror, or that I just read a block of VB.... Dirty... I feel dirty...

I wasn't, now I am, then I won't be anymore.

[Rob Grainger]

It's slightly worse than that, this is VBA.

[musefan]

My thoughts exactly X|

return 5;

[imagiro]

Well, the GoTo is important here, otherwise the computer may not know what to do: Sit down and have a coffee, travel to Egypt and visit the pyramides or maybe format the harddisks.. I always suggested to put a GoToNextStatement after each statement. But these dumb guys from microsoft didn't want to listen to me..

[PIEBALDconsult]

Yeah, if only we could maybe assign a numerical order to the statements... :rolleyes:

[Euhemerus]

What I find deeply disturbing by this and other examples of bad coding is that these people get paid for writing this rubbish. Furthermore, what is more frightening is the fact that they could be writing code for safety systems or banking systems or who knows what else. No bloody wonder the software industry puts a NO WARRANTIES EXPRESSED OR IMPLIED notice into every EULA D'Oh! They're not even sure it's going to work. Can you imagine buying a new car and the manufacturer said that there were no warranties?

Nobody can get the truth out of me because even I don't know what it is. I keep myself in a constant state of utter confusion. - Col. Flagg