Please laugh at me so I never do this again...

henrikqwerty321

This is actually an epic fail I did myself, just yesterday... I believe I should be punished for this horrible act against humanity so please laugh at me so I never do it again...

Private Sub enableControls()
        txtDbHost.Enabled = True
        txtDbName.Enabled = True
        txtDbPass.Enabled = True
        //Continues all the way down....
End Sub
Private Sub disableControls()
        txtDbHost.Enabled = False
        txtDbName.Enabled = False
        txtDbPass.Enabled = False
       //Continues all the way down....
End Sub

Worst thing is that it is part of a project I send into Codecanyon, I really think it's going to get rejected for that blunder.

Henrik Pedersen - HSP Software - www.hsp.dk

Lost User

I also do such stuff. What's wrong with it. I need a slap if there is something wrong with it. :^)

henrikqwerty321

You could short it down to something like:

Private Sub SetUIActivated(ByBal Active As Boolean)
control1.Enabled = Active
control2.Enabled = Active
//Continues like hell...
End Sub

Lost User

ohh! Such a simple Solution and I never thought. I need to slap myself. :zzz: 5 to you!

henrikqwerty321

Haha and thanks. But I still committed the crime too :S

88Rocker

i used to do that too :)

RobCroll

Now that is a fail. Shouldn't the routine be called at worst SetUIEnabled or even better EnableControls. The code block doesn't activate anything. Maybe a more elegant solution would be to iterate through the forms controls and ignore the few controls you wish to remain enabled.

Public Sub EnableControls(ByVal Enabled As Boolean)
    For Each FormControl As Control In Me.Controls
        FormControl.Enabled = Enabled
    Next
End Sub

Personally I didn't see anything wrong with your original solution except that the routine names were lower case.

"You get that on the big jobs."

Nagy Vilmos

You used VB! :-D

Panic, Chaos, Destruction. My work here is done. or "Drink. Get drunk. Fall over." - P O'H OK, I will win to day or my name isn't Ethel Crudacre! - DD Ethel Crudacre Have a bit more patience with newbies. Of course some of them act dumb -- they're often *students*, for heaven's sake. -- (Terry Pratchett, alt.fan.pratchett)

henrikqwerty321

Yeah sorry still trying to get the naming conventions -.-' (PHP and C++ is messing around with my head)... But about the part of looping trough the form I don't think it's the right solution as the majority of controls must remain unchanged.

Robert Rohde

Normally in such a situation I also try to put the affected controls into one Panel or GroupBox and just enable/disable that one. Robert

Joshi Rushikesh

Always think and revisit a piece of code which you just wrote, and you understand how best you can re-write it. -- Rushi

Rob Grainger

And even improve that (for readability) using...

Private Sub EnableControls()
SetUIActivated(True)
End Sub
Private Sub DisableControls()
SetUIActivated(False)
End Sub

TorstenFrings

It's never a good idea to provide multiple ways to do the same thing

TorstenFrings

an elegant solution would be to put the controls in question into a dedicated collection and iterate over this