Comma operator considered harmful

[o m n i]

From a console tic-tac-toe game: (drawing function)

for (int x = 0, y = 0; y < 3; y+=((x==2)?1:0),x+=((x==2)?-2:1) ) {
cout << boardStrings[board[x][y]] << ((x == 2) ? "\n" : "");
}

:((

[Al_Brown]

I hate to say it, but I quite like that code. With a couple of named constants instead of the use of literals 2 and 3 and more consistant spacing it would be nice and succinct.

[oggenok64]

I'm glad to say that i like this code :-) No horror there i my opinion.

- oggenok

[BillW33]

While I do use the comma operator, I do so sparingly. I also like code to be easily readable, which this example is not. :sigh:

Just because the code works, it doesn't mean that it is good code.

[BobJanova]

That's not really bad, to me. Initialising and updating two variables in a loop is one of the well understood allowed places to use a comma. The thing that's wrong with this code is that the 3x3 nature of the board should be a variable (or at least a constant), not in there as a magic number 5 times.