Every line makes me die a little more...

[leppie]

WTF~!!!!!!!!!!! :wtf: :omg: :omg: :wtf:

var key = "13870";
var checkboxName = key + "_Selected";
var commentName = key + "_Comments";
if(document.getElementById(checkboxName).checked == true)
{
document.getElementById(commentName).value = commentBox.value;
appliedToCount ++;
}

var key = "13886";
var checkboxName = key + "_Selected";
var commentName = key + "_Comments";
if(document.getElementById(checkboxName).checked == true)
{
document.getElementById(commentName).value = commentBox.value;
appliedToCount ++;
}

var key = "13905";
var checkboxName = key + "_Selected";
var commentName = key + "_Comments";
if(document.getElementById(checkboxName).checked == true)
{
document.getElementById(commentName).value = commentBox.value;
appliedToCount ++;
}

var key = "13910";
var checkboxName = key + "_Selected";
var commentName = key + "_Comments";
if(document.getElementById(checkboxName).checked == true)
{
document.getElementById(commentName).value = commentBox.value;
appliedToCount ++;
}

var key = "13918";
var checkboxName = key + "_Selected";
var commentName = key + "_Comments";
if(document.getElementById(checkboxName).checked == true)
{
document.getElementById(commentName).value = commentBox.value;
appliedToCount ++;
}

var key = "13922";
var checkboxName = key + "_Selected";
var commentName = key + "_Comments";
if(document.getElementById(checkboxName).checked == true)
{
document.getElementById(commentName).value = commentBox.value;
appliedToCount ++;
}

var key = "13927";
var checkboxName = key + "_Selected";
var commentName = key + "_Comments";
if(document.getElementById(checkboxName).checked == true)
{
document.getElementById(commentName).value = commentBox.value;
appliedToCount ++;
}

var key = "13930";
var checkboxName = key + "_Selected";
var commentName = key + "_Comments";
if(document.getElementById(checkboxName).checked == true)
{
document.getElementById(commentName).value = commentBox.value;
appliedToCount ++;
}

var key = "13948";
var checkboxName = key + "_Selected";
var commentName = key + "_Comments";
if(document.getElementById(checkboxName).checked == true)
{
document.getElementById(commentN

[Lost User]

leppie wrote:

.checked == true

This is an instance of shame within a shame.

[GibbleCH]

I presume each of these duplicated sections was in it's own method, otherwise it won't even compile. Since each var statement keeps declaring variables that are already declared.

[leppie]

It is acceptable javascript.

((λ (x) `(,x ',x)) '(λ (x) `(,x ',x)))

[Brady Kelly]

leppie wrote:

This code was in fact generated...

by a generator written by a tool.

[Allan Thomas]

How about a 13 month KPI that has code that has logic to work out the summary values to be displayed for each month, storing values used elsewhere in seperate variables (not an array) and then having that code duplicated 13 times (with a slight change in variables/controls). It would have been at least 10 pages and all embedded in the click event of the button :( . After checking the code to see if anything else was buried in there I refactored this (with the help of a few functions) into two loops with about a dozen lines total. It helped because a bit later I found two other places where the same thing happened and while the code was different I was able to copy and paste the code and update the loop for the different KPI's.

[leppie]

Exactly what should have been done. I see the same pattern as you described. They use jQuery, so I dont understand why they can't even make it a one liner...

((λ (x) `(,x ',x)) '(λ (x) `(,x ',x)))