Code should be 5 or anything above 7 long...

[Sander Rossel]

Before people start... The horror is NOT that this is VB code... Now with that out of the way... A bit of weird code a colleague found recently...

' This code should always be 5 characters long.
If code.Length < 5 Or code.Length = 6 Or code.Length = 7 Then
Throw New Exception("Code should be 5 characters long.")
End If

My guess is that the programmer assumed it would be 5 characters long or less. Then it turned out it could be 6 too so the Or code.length = 6 part was added, then the code was 7 at some occurrence... The users weren't stupid enough to enter an 8 character code so that one hasn't been added (yet) :laugh: Why not simply check if code.Length <> 5? :rolleyes:

It's an OO world.

public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}

[Jochen Arndt]

At least the programmer added a comment stating what the code should do. :rolleyes:

[Sander Rossel]

If only the code did what was commented... Perhaps requirements changed and the comment is wrong? :rolleyes:

It's an OO world.

public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}

[ChrisNic]

Maybe the comment and the error message should have been ' This code should always be 5 characters or more than 7 characters.

[biagiop1986]

OMG ... I can't look at it. I'm feeling sick. Thank you for ruining my day! :-)

[reilly96]

or simply set the max lenght of the textbox = 5

[Gary Huck]

What? That's all you got!? I've seen this s**tstuff for years! ;)

[Lost User]

What's so bad about being explicit about what you don't accept as a valid value? :) Besides that, we also have a lot of literal values here. Checking the length against a constant or some configuration entry can be helpful, especially because the code's valid length may have changed over time. Throwing a plain vanilla exception with a literal message also is sloppy. It's not that hard to derive custom exeption classes for your application and would help in avoiding Pokemon exception handling.

I'm invincible, I can't be vinced

[YvesDaoust]

My fix :-)

' Code should be 5 or anything above 7 long
If IsPrime(90*code.Length+61) Then
Throw New Exception("Code should be 5 or anything above 7 characters long.")
End If

[ZurdoDev]

Hey, VB is great. It is much easier than C#. I do everything in C# but don't hate on VB.

[Saksida Bojan]

Difference between VB or C# is a syntax, thanks to the .net framework. But if you ask what do I think is that C# is better. But ultimately it comes toward preference.

[Chris Meech]

Are you a member of Obfuscators Anonymous. :)

Chris Meech I am Canadian. [heard in a local bar] In theory there is no difference between theory and practice. In practice there is. [Yogi Berra] posting about Crystal Reports here is like discussing gay marriage on a catholic church’s website.[Nishant Sivakumar]

[Lost User]

Just goes to show that some programmers haven't got a clue! :doh:

A perpetual holiday is a good working definition of hell.

[bwallan]

"code.Length <> 5" is far too easy!

[Sander Rossel]

Indeed...

Dim counter As Long ' This could be a REAL long code!
For Each c As Char In code
counter = counter + 1
End If
If counter < 5 Then
Throw New Exception("The code is to short!")
ElseIf counter = 6
Throw New Exception("The code is to long!")
ElseIf counter = 7
Throw New Exception("The code is to long!")
Else
' Some code here :)
End If

It's an OO world.

public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}

[bwallan]

Much better! LOL bwa P.S.: Does the happy face get output??

[Sander Rossel]

The happy face is a hidden VB feature in .NET 4 ;p

It's an OO world.

public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}

[YvesDaoust]

Yeah, at the Novice rank. I hope to go up to Apprentice this year.

[0bx]

Then he should correct the exception too: "Code should be 5 characters long OR longer than 7."

Giraffes are not real.

[MarvinMartian]

These instances of code changes were not done by a programmer. A developer maybe, but not a programmer.