Button Color In MFC
-
Hello Friends I am creating a dialog based Application in which I am creating several Tabs.I am adding seven button to this Dialog also. Now,I want to set the some color on Button. And,On Tab change ,I want to change the colors of button too. Any Ideas? Thanks & regards Yogesh
-
Hello Friends I am creating a dialog based Application in which I am creating several Tabs.I am adding seven button to this Dialog also. Now,I want to set the some color on Button. And,On Tab change ,I want to change the colors of button too. Any Ideas? Thanks & regards Yogesh
-
Hello Friends I am creating a dialog based Application in which I am creating several Tabs.I am adding seven button to this Dialog also. Now,I want to set the some color on Button. And,On Tab change ,I want to change the colors of button too. Any Ideas? Thanks & regards Yogesh
yogeshs wrote:
Now,I want to set the some color on Button.
Are you handling the
WM_CTLCOLORBTNmessage?"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous
-
By: I want to set the some color on Button Do you mean set some bitmap and change it to indicate button state or change the color of the whole button?
JohnCz
-
yogeshs wrote:
Now,I want to set the some color on Button.
Are you handling the
WM_CTLCOLORBTNmessage?"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous
No, I am not handling this Message .But i tried to inherit Class from CButton and tried to set color. But no use. And i want to change the color at runtime also.So,for that Do I need to Override Drawitem? What its Actual Working ? Some Ideas ?? Regards Yogesh
-
Hello Friends I am creating a dialog based Application in which I am creating several Tabs.I am adding seven button to this Dialog also. Now,I want to set the some color on Button. And,On Tab change ,I want to change the colors of button too. Any Ideas? Thanks & regards Yogesh
-
Hello Friends I am creating a dialog based Application in which I am creating several Tabs.I am adding seven button to this Dialog also. Now,I want to set the some color on Button. And,On Tab change ,I want to change the colors of button too. Any Ideas? Thanks & regards Yogesh
WM_CTLCOLORBTN does not work for buttons, since it draws face and borders. If you are using VS 2008 with feature pack or with SP1 use CMFCButton class. To set button face color, call SetFaceColor member. You have to set m_bTransparent to FALSE anf disable teaming by calling EnableWindowsTheming member and passing FALSE as parameter. If you are using earlier version of VS you will have to use owner drawn button and draw button yourself. Another alternative would be to set bitmap for the button with BS_BITMAP style; do not use CBitmapButton.
JohnCz
-
WM_CTLCOLORBTN does not work for buttons, since it draws face and borders. If you are using VS 2008 with feature pack or with SP1 use CMFCButton class. To set button face color, call SetFaceColor member. You have to set m_bTransparent to FALSE anf disable teaming by calling EnableWindowsTheming member and passing FALSE as parameter. If you are using earlier version of VS you will have to use owner drawn button and draw button yourself. Another alternative would be to set bitmap for the button with BS_BITMAP style; do not use CBitmapButton.
JohnCz
JohnCz wrote:
WM_CTLCOLORBTN does not work for buttons, since it draws face and borders.
So MSDN's "The parent window can change the button's text and background colors" statement is wrong?
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous
-
No, I am not handling this Message .But i tried to inherit Class from CButton and tried to set color. But no use. And i want to change the color at runtime also.So,for that Do I need to Override Drawitem? What its Actual Working ? Some Ideas ?? Regards Yogesh
yogeshs wrote:
No, I am not handling this Message .But i tried to inherit Class from CButton and tried to set color.
But no use.I think you have to use
ON_NOTIFY_REFLECT()in the button's message map, orON_NOTIFY()in the parent (i.e., dialog)."One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous
-
JohnCz wrote:
WM_CTLCOLORBTN does not work for buttons, since it draws face and borders.
So MSDN's "The parent window can change the button's text and background colors" statement is wrong?
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous
-
MSDN states also (below the line you have quoted): "By default, the DefWindowProc function selects the default system colors for the button. Buttons with the BS_PUSHBUTTON, BS_DEFPUSHBUTTON, or BS_PUSHLIKE styles do not use the returned brush. Buttons with these styles are always drawn with the default system colors. Drawing push buttons requires several different brushes-face, highlight, and shadow-but the WM_CTLCOLORBTN message allows only one brush to be returned. To provide a custom appearance for push buttons, use an owner-drawn button. For more information, see Creating Owner-Drawn Controls." This is also incorrect, as you can see from the sample code at the bottom. Radio and check boxes use static background color. If you change styles to "push like" color of the face will also not change. As you can see parent window is not able to change button’s face color of the pushbutton. In conclusion, MSDN is incorrect (not the first time).
JohnCz
-
MSDN states also (below the line you have quoted): "By default, the DefWindowProc function selects the default system colors for the button. Buttons with the BS_PUSHBUTTON, BS_DEFPUSHBUTTON, or BS_PUSHLIKE styles do not use the returned brush. Buttons with these styles are always drawn with the default system colors. Drawing push buttons requires several different brushes-face, highlight, and shadow-but the WM_CTLCOLORBTN message allows only one brush to be returned. To provide a custom appearance for push buttons, use an owner-drawn button. For more information, see Creating Owner-Drawn Controls." This is also incorrect, as you can see from the sample code at the bottom. Radio and check boxes use static background color. If you change styles to "push like" color of the face will also not change. As you can see parent window is not able to change button’s face color of the pushbutton. In conclusion, MSDN is incorrect (not the first time).
JohnCz
-
Hello I used CButon class to create button and then i override the DrawItem in Window class. But its not Coming on Drawitem,where I am updating the color of Button. Thanks
Hey Friends i got something That is working but need some help from you. Here is the way.I created a new class CColorButton inherit from CButton. And override functions paint and draw to set color. But when I am attaching my ButtonId to object of CCOlorbutton,it is giving some assertion. I am trying like this CColorbutton* pBtn = new CColorButton(); pBtn->Attach(GetDlgItemId( IDC_BUTTON_ID + ndx )->GetSafeHwnd()); Regards Yogesh
-
Hey Friends i got something That is working but need some help from you. Here is the way.I created a new class CColorButton inherit from CButton. And override functions paint and draw to set color. But when I am attaching my ButtonId to object of CCOlorbutton,it is giving some assertion. I am trying like this CColorbutton* pBtn = new CColorButton(); pBtn->Attach(GetDlgItemId( IDC_BUTTON_ID + ndx )->GetSafeHwnd()); Regards Yogesh
yogeshs, I think you are confusing two things: Windows window with MFC object that is not a window. MFC object encapsulates window handle and only after window handle is valid, such an object represent Windows window. There are three ways to make MFC object alive (assign a valid handle): Calling member function Create for a given class Calling Attach Subclassing window Only calling Create and Subclassing will allow MFC object handling messages of the attached window. Calling Attach will not allow process any messages processing, since window procedure has not been replaced by the object’s window procedure. You should post a snippet that shows a function where it assert. Your code snippet does not make much sense since the meaning of the GetDlgItemId is unknown. Regardless, it looks like you are trying to attach an object that is already alive, meaning Windows window has MFC object attached to it. MFC code does it for you. Please answer one question that I have already asked: What version of Visual Studio you are using? Maybe taking it from here will be more beneficial for you.
JohnCz
-
Hey Friends i got something That is working but need some help from you. Here is the way.I created a new class CColorButton inherit from CButton. And override functions paint and draw to set color. But when I am attaching my ButtonId to object of CCOlorbutton,it is giving some assertion. I am trying like this CColorbutton* pBtn = new CColorButton(); pBtn->Attach(GetDlgItemId( IDC_BUTTON_ID + ndx )->GetSafeHwnd()); Regards Yogesh
yogeshs wrote:
CColorbutton* pBtn = new CColorButton();
pBtn->Attach(GetDlgItemId( IDC_BUTTON_ID + ndx )->GetSafeHwnd());It's highly unlikely that you would need to do this. Why not just replace
CButtonwithCColorbuttonin your dialog's.hfile?"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous
-
yogeshs, I think you are confusing two things: Windows window with MFC object that is not a window. MFC object encapsulates window handle and only after window handle is valid, such an object represent Windows window. There are three ways to make MFC object alive (assign a valid handle): Calling member function Create for a given class Calling Attach Subclassing window Only calling Create and Subclassing will allow MFC object handling messages of the attached window. Calling Attach will not allow process any messages processing, since window procedure has not been replaced by the object’s window procedure. You should post a snippet that shows a function where it assert. Your code snippet does not make much sense since the meaning of the GetDlgItemId is unknown. Regardless, it looks like you are trying to attach an object that is already alive, meaning Windows window has MFC object attached to it. MFC code does it for you. Please answer one question that I have already asked: What version of Visual Studio you are using? Maybe taking it from here will be more beneficial for you.
JohnCz
-
I am using Vs2008 professional. Thanks For Your Reply. Trying To Understand. Thanks Yogesh
OK, that is good so far. If you have SP1 installed, why not to follow my previous advice (from my earlier response): If you are using VS 2008 with feature pack or with SP1 use CMFCButton class. To set button face color, call SetFaceColor member. You have to set m_bTransparent to FALSE anf disable teaming by calling EnableWindowsTheming member and passing FALSE as parameter. This is much easier than reinventing a wheel.
JohnCz
-
OK, that is good so far. If you have SP1 installed, why not to follow my previous advice (from my earlier response): If you are using VS 2008 with feature pack or with SP1 use CMFCButton class. To set button face color, call SetFaceColor member. You have to set m_bTransparent to FALSE anf disable teaming by calling EnableWindowsTheming member and passing FALSE as parameter. This is much easier than reinventing a wheel.
JohnCz
-
yogeshs wrote:
CColorbutton* pBtn = new CColorButton();
pBtn->Attach(GetDlgItemId( IDC_BUTTON_ID + ndx )->GetSafeHwnd());It's highly unlikely that you would need to do this. Why not just replace
CButtonwithCColorbuttonin your dialog's.hfile?"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous
