Cannot change text of button on a control.

Ammar_Ahmad

I made a control which has a button on it. But I need to change the text of it when it is clicked. this is what I have tried but it didn't work:

If Button1.Text = "1" then
Button1.Text = "0"
Elseif Button1.Text = "0" then
Button1.Text = "1"
End if

Dave Kreskowiak

Where did you put this code?? What EXACTLY do you want this to happen??

A guide to posting questions on CodeProject[^]
Dave Kreskowiak

Ammar_Ahmad

I put that code on a button_click event in a UserControl that I made. It is supposed to work as a boolean. eg if the value is 1 then it should change it to 0 else if the value is 0 it should change it to 1.

Dave Kreskowiak

The click event is not going to work for this. Click is fired after the button is pushed AND released. Similar code has to be called by the MouseDown, MouseUp, KeyDown and KeyUp handlers. The xDown events fire when the button is pushed down and the mouse or key is still being held down. The xUp events fire when the mouse or key is released.

A guide to posting questions on CodeProject[^]
Dave Kreskowiak

javadadabi

Hello before selecting another event to let your code, make a breakpoint after bottun_click() line,run your control in dubug mode check if break point stop your program,therefore event has no problem,then check your condition state.

Dave Kreskowiak

I think you meant to reply to the OP.

A guide to posting questions on CodeProject[^]
Dave Kreskowiak

Ammar_Ahmad

I added breakpoint on button1_click That event does get fired! And the other code that is in that event gets fired up correctly. The problem it that, that it doesn't change the text of button1. Here I have attached the source code as well: http://www.mediafire.com/?onhramkfh4zy6zx[^]

Ammar_Ahmad

Button1_click gets fired. But the text of button1 isn't changing... Here I have added the source code: http://www.mediafire.com/?onhramkfh4zy6zx[^] Can you please look into it?

Luc Pattyn

If you mean the Button1 handler should modify the Button1 text, then I see no problem, that works just fine. Mind you, you will see the results only after the Click handler has finished (unless you add a call to Refresh). So changing the text initially, performing a long operation, then changing the text back to its original, all in the one Click handler, will not show any change at all. But then, you shouldn't be doing long operations inside a handler on the GUI thread to begin with... Threads (and BackgroundWorkers) were invented to decouple long operations from the GUI thread. :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

Ammar_Ahmad

I did add refresh() at the end... but that didn't work :(

Luc Pattyn

Then you are doing something wrong. Maybe you have more than one Button1 in your project, and you're talking to the wrong one (it helps to use meaningful names). Maybe its initial text isn't neither "0" nor "1". Maybe ... You will need to provide a more comprehensive description of what you have if you want to get more effective help around here. :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

Ammar_Ahmad

I actually uploaded the entire source code of the application over here: http://www.mediafire.com/?onhramkfh4zy6zx[^] I think I am doing everything right... can you please check what I am doing wrong?

Luc Pattyn

Sorry, I am not going to download, unpack, and investigate a bunch of code, and neither would anyone else around here. If you want effective help, put some effort in describing the problem properly and provide the relevant pieces of code (inside your message, and using PRE tags), not just all of it. :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

Ammar_Ahmad

Alright. So here is the exact issue with all the pictures and everything. I have a Form which has a FlowLayoutPanel, which has a UserControl on it. That Usercontrol has a Button on it. The initial text of that Button is "0" But I want to change that to "1" if it is a "0" and change it back to "0" if it is a "1" So this is the code I used on the UserControl which has the Button on it:

Public Class UserControl1

Private Sub Button1\_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
    If Button1.Text = "0" Then
        Button1.Text = "1"
    ElseIf Button1.Text = "1" Then
        Button1.Text = "0"
    End If
End Sub

End Class

But when I click on Button1, the event does get fired but the text of the Button1, that is on the UserControl which is drawn on FlowLayoutPanel doesn't get changed.

Dave Kreskowiak

First, you don't need ElseIf in this case. It should just be:

If Button1.Text = "0" Then
    Button1.Text = "1"
Else
    Button1.Text = "0"
End If

Second, Button1 is a horrible name for a button. Change it to something meaningful, like "OkButton", so you know without thinking which button it's referring to on your form.

A guide to posting questions on CodeProject[^]
Dave Kreskowiak

javadadabi

Dear ammar ahmad there was no user control name usercontrol1 in your solution. I saw your coding,you are more expert than me. I didnt run your program at all. Would you please tell me what this code is for?

Ally5

Try changing the sub to:

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
If Button1.Text = "0" Then
Button1.Text = "1"
Else
Button1.Text = "0"
End If
End Sub

Ammar_Ahmad

Still doesn't work.

Ammar_Ahmad

It is there... it should be under Form1. This is Twitter client that I am working on.

Ammar_Ahmad

nope. not working.