String.Format - I'm sure there must be a worse way to do this.

[egenis]

RCoate wrote:

// Format month if (month.Length == 1){ month = "0" + month; }   // Format day if (day.Length == 1){ day = "0" + day; }

Now if that had been done with a StringBuilder... I would have been impressed! :-\

[RCoate]

// Format month
var sbMonth = new StringBuilder();
if (month.Length == 1)
{
sbMonth.Append("0");
}
sbMonth.Append(month);

Awesome! I knew there was another method missing! :)

[PIEBALDconsult]

Now try it with Insert.

[RCoate]

Got your insert right here.

// Format month
var sbMonth = new StringBuilder();
sbMonth.Append(month);
if (month.Length == 1)
{
sbMonth.Insert(0, "0");
}

I'm sure if the genius who wrote this was aware of Insert and string builders, it would have been used. Can't complain too much. At least the code actually produces the required outcome. I can't always claim that. :)

[Slacker007]

String.Remove() and String.Insert() - I use these a lot. BTW, I hardly use StringBuilder(), but that's just my style. ;)

[0bx]

var sbMonth = new StringBuilder();
try
{
int x = 1 / month.Length -1;
sbMonth = AppendMonth(sbMonth);
}
catch
{
sbMonth = AppendMonth(sbMonth, "0" + month);
}

private StringBuilder AppendMonth(StringBuilder sb, string s)
{
string x = sb.Append(s).ToString();
StringBuilder y = new StringBuilder();
return y.Append(x);
}

Giraffes are not real.

[RCoate]

:omg: Yep. That's worse.

[Sentenryu]

ok, now where's my mind bleach?

I'm brazilian and english (well, human languages in general) aren't my best skill, so, sorry by my english. (if you want we can speak in C# or VB.Net =p)

[0bx]

I'm so sorry... I just couldn't stop.

Giraffes are not real.

[Mario Majcica]

You need to understand that a thing like this,

string DocumentName = string.Format("Application - [{0}] - {1:yyyyMMdd}", Person.RegistrationNo, DateTime.Now);

was not easy to understand and it could trick less experienced developers!!! Cheers!!!

[BobJanova]

Joke? That's far easier to read than what was originally posted.

[Mario Majcica]

Well it is flagged as a joke, also I hope my tone was sarcastic enough. Cheers

[BobJanova]

Okay, just checking :)

[Brisingr Aerowing]

Here you go![^]

I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. Stephen Hawking

[Sentenryu]

Thanks!

I'm brazilian and english (well, human languages in general) aren't my best skill, so, sorry by my english. (if you want we can speak in C# or VB.Net =p)

[Brisingr Aerowing]

You're welcome!

I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. Stephen Hawking

[Lost User]

I would think this is how it's supposed to be done.

string Daternator()
{
DateTime dt = DateTime.Now;

string result = ""; // Failure to use String.Empty - Check

// Homemade string concat - Check
for (int i = 0; i < 3; i++)
{
    if (i == 0)
        result += dt.Year.ToString() + ", ";
    else if (i == 1)
        result += dt.Month.ToString() + ", ";
    else if (i == 2)
        result += dt.Day.ToString() + ", "; // Unnecessary code - Check 
}

// More unnecessary code to fix previous unnecessary code - Check
result = result.Remove(result.LastIndexOf(" "), 1);
result = result.Remove(result.LastIndexOf(","), 1);

// My lord, he wouldn't...
Start:

// And what's this? Regex? Fancy!
MatchCollection mc = Regex.Matches(result, @"\\b(\\d)\\b");

// I like where this is headed...
foreach (Match m in mc)
{
    if (m.Success)
    {
        result = result.Insert(m.Index, "0");
        goto Start; // Oh lord, he did, a goto loop - Check
    }
}

// Sweet sciency magic we have a result!!
return string.Format("Application - \[{0}\] - " + result, this.Person.RegistrationNo.ToString());

}