Why would you do this to a stored procedure? It never did anything to you.
-
ALTER PROCEDURE [dbo].[arUpdate]
@intForecastID int,
@strForecastName varchar(18),
@strBillTo varchar(12),
@strPOCName varchar(50),
@strPOCEmail varchar(100),
@strModifiedBy varchar(20),
@strComment varchar(3000),
@strDelMaterials varchar(8000),
@strData1 varchar(8000),
@strData2 varchar(8000),
@strData3 varchar(8000),
@strData4 varchar(8000),
@strData5 varchar(8000),
@strData6 varchar(8000),
@strData7 varchar(8000),
@strData8 varchar(8000),
@strData9 varchar(8000),
@strData10 varchar(8000),
@strData11 varchar(8000),
@strData12 varchar(8000),
@strData13 varchar(8000),
@strData14 varchar(8000),
@strData15 varchar(8000),
@strData16 varchar(8000),
@strData17 varchar(8000),
@strData18 varchar(8000),
@strData19 varchar(8000),
@strData20 varchar(8000):wtf: None of the code in this procedure or from the calling methods looked any better. The data going into the varchar(8000) fields was delimited with a grab bag combination of special characters. Which was then pealed apart using cursors. :wtf:
Play my game Gravity: IOS[^], Android[^], Windows Phone 7[^]
Because the person who wrote it likes to curl up in a small ball with a nervous twitch in their eye whilst they inappropriately touch a small fury animal. Honestly, you're better not asking, pretend you never saw it and maybe, just maybe, you'll make it through to tomorrow with a shred of sanity left in you.
Eagles may soar, but weasels don't get sucked into jet engines
-
Because the person who wrote it likes to curl up in a small ball with a nervous twitch in their eye whilst they inappropriately touch a small fury animal. Honestly, you're better not asking, pretend you never saw it and maybe, just maybe, you'll make it through to tomorrow with a shred of sanity left in you.
Eagles may soar, but weasels don't get sucked into jet engines
Gave me a good laugh right now :D
-
Back slowly away. This was obviously the work of a Sociopath.
*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington
"Mind bleach! Send me mind bleach!" - Nagy Vilmos
CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier
Unfortunately, such people insist on calling them programmers. Gives our profession a bad name ...
-
Because people are still looking for a silver-bullet, 1 thing that can do everything for you. Would hate to see the design & architecture of the rest of the 'solution'
____________________________________________________________ Be brave little warrior, be VERY brave
-
ALTER PROCEDURE [dbo].[arUpdate]
@intForecastID int,
@strForecastName varchar(18),
@strBillTo varchar(12),
@strPOCName varchar(50),
@strPOCEmail varchar(100),
@strModifiedBy varchar(20),
@strComment varchar(3000),
@strDelMaterials varchar(8000),
@strData1 varchar(8000),
@strData2 varchar(8000),
@strData3 varchar(8000),
@strData4 varchar(8000),
@strData5 varchar(8000),
@strData6 varchar(8000),
@strData7 varchar(8000),
@strData8 varchar(8000),
@strData9 varchar(8000),
@strData10 varchar(8000),
@strData11 varchar(8000),
@strData12 varchar(8000),
@strData13 varchar(8000),
@strData14 varchar(8000),
@strData15 varchar(8000),
@strData16 varchar(8000),
@strData17 varchar(8000),
@strData18 varchar(8000),
@strData19 varchar(8000),
@strData20 varchar(8000):wtf: None of the code in this procedure or from the calling methods looked any better. The data going into the varchar(8000) fields was delimited with a grab bag combination of special characters. Which was then pealed apart using cursors. :wtf:
Play my game Gravity: IOS[^], Android[^], Windows Phone 7[^]
You have an application that is 25 years old with no documentation for the tables, c-isam tables. You have to make this wonderful application talk to a modern day databases. You have been given a budget of $0 to get this task completed. You have just enough time to learn syntax to put something together that will hopefully work. That is how this happens.
-
ALTER PROCEDURE [dbo].[arUpdate]
@intForecastID int,
@strForecastName varchar(18),
@strBillTo varchar(12),
@strPOCName varchar(50),
@strPOCEmail varchar(100),
@strModifiedBy varchar(20),
@strComment varchar(3000),
@strDelMaterials varchar(8000),
@strData1 varchar(8000),
@strData2 varchar(8000),
@strData3 varchar(8000),
@strData4 varchar(8000),
@strData5 varchar(8000),
@strData6 varchar(8000),
@strData7 varchar(8000),
@strData8 varchar(8000),
@strData9 varchar(8000),
@strData10 varchar(8000),
@strData11 varchar(8000),
@strData12 varchar(8000),
@strData13 varchar(8000),
@strData14 varchar(8000),
@strData15 varchar(8000),
@strData16 varchar(8000),
@strData17 varchar(8000),
@strData18 varchar(8000),
@strData19 varchar(8000),
@strData20 varchar(8000):wtf: None of the code in this procedure or from the calling methods looked any better. The data going into the varchar(8000) fields was delimited with a grab bag combination of special characters. Which was then pealed apart using cursors. :wtf:
Play my game Gravity: IOS[^], Android[^], Windows Phone 7[^]
-
You have an application that is 25 years old with no documentation for the tables, c-isam tables. You have to make this wonderful application talk to a modern day databases. You have been given a budget of $0 to get this task completed. You have just enough time to learn syntax to put something together that will hopefully work. That is how this happens.
I could see it happening that way sometimes. But this code was from an ASP.net app. The comments put the creation date of this piece around 2005. This may have come about through code rot. Maybe it worked great for something small and the scope and input string kept expanding. In any case... ick. And of course I don't have the time to fix it either. So I'll pass it on to somebody else also.
Play my game Gravity: IOS[^], Android[^], Windows Phone 7[^]
-
I have that exact same pattern in my DB(not done by me), i wonder if they were both written by the same person. In my version though all those varchar(8000)s are ignored in the first SP and passed to a second which does even more string manipulation with cursors. wonder why they just didnt use one varchar(max) or a text field.
Please remember to rate helpful or unhelpful answers, it lets us and people reading the forums know if our answers are any good.
SomeGuyThatIsMe wrote:
wonder why they just didnt use one varchar(max) or a text field.
I'd guess this was written in SQL 2000. max didn't exist and it took too much thinking to do character manipulation on text fields. (For anyone who'd write this in the first place.) I can't picture how to execute a cursor on a varchar field. (Extract a fraction of the data and then use a cursor to retrieve it from a table, sure, but ON the field?)
-
SomeGuyThatIsMe wrote:
wonder why they just didnt use one varchar(max) or a text field.
I'd guess this was written in SQL 2000. max didn't exist and it took too much thinking to do character manipulation on text fields. (For anyone who'd write this in the first place.) I can't picture how to execute a cursor on a varchar field. (Extract a fraction of the data and then use a cursor to retrieve it from a table, sure, but ON the field?)
If i find the time today i'll post that piece of the sp.
Please remember to rate helpful or unhelpful answers, it lets us and people reading the forums know if our answers are any good.
-
ALTER PROCEDURE [dbo].[arUpdate]
@intForecastID int,
@strForecastName varchar(18),
@strBillTo varchar(12),
@strPOCName varchar(50),
@strPOCEmail varchar(100),
@strModifiedBy varchar(20),
@strComment varchar(3000),
@strDelMaterials varchar(8000),
@strData1 varchar(8000),
@strData2 varchar(8000),
@strData3 varchar(8000),
@strData4 varchar(8000),
@strData5 varchar(8000),
@strData6 varchar(8000),
@strData7 varchar(8000),
@strData8 varchar(8000),
@strData9 varchar(8000),
@strData10 varchar(8000),
@strData11 varchar(8000),
@strData12 varchar(8000),
@strData13 varchar(8000),
@strData14 varchar(8000),
@strData15 varchar(8000),
@strData16 varchar(8000),
@strData17 varchar(8000),
@strData18 varchar(8000),
@strData19 varchar(8000),
@strData20 varchar(8000):wtf: None of the code in this procedure or from the calling methods looked any better. The data going into the varchar(8000) fields was delimited with a grab bag combination of special characters. Which was then pealed apart using cursors. :wtf:
Play my game Gravity: IOS[^], Android[^], Windows Phone 7[^]
I've seen code like that were they were manipulating data -- usually because they couldn't (normally they just didn't want to) use better tools. But I'm worried about this line -- Which was then pealed apart using cursors. Cursors?
-
ALTER PROCEDURE [dbo].[arUpdate]
@intForecastID int,
@strForecastName varchar(18),
@strBillTo varchar(12),
@strPOCName varchar(50),
@strPOCEmail varchar(100),
@strModifiedBy varchar(20),
@strComment varchar(3000),
@strDelMaterials varchar(8000),
@strData1 varchar(8000),
@strData2 varchar(8000),
@strData3 varchar(8000),
@strData4 varchar(8000),
@strData5 varchar(8000),
@strData6 varchar(8000),
@strData7 varchar(8000),
@strData8 varchar(8000),
@strData9 varchar(8000),
@strData10 varchar(8000),
@strData11 varchar(8000),
@strData12 varchar(8000),
@strData13 varchar(8000),
@strData14 varchar(8000),
@strData15 varchar(8000),
@strData16 varchar(8000),
@strData17 varchar(8000),
@strData18 varchar(8000),
@strData19 varchar(8000),
@strData20 varchar(8000):wtf: None of the code in this procedure or from the calling methods looked any better. The data going into the varchar(8000) fields was delimited with a grab bag combination of special characters. Which was then pealed apart using cursors. :wtf:
Play my game Gravity: IOS[^], Android[^], Windows Phone 7[^]