crash with push_back for vector

[nss]

What am I doing wrong? I want to read the names from a file and put them onto a vector of char*......it crashes at the pushback. Each file name is on a different line. I did a dir/b in dos and got a txt file with a list of file names (a bunch of .bmps) from the directory. I assume theres carriage returns at the end of each line. But maybe not. There are 18 letters in the name08FEB096_9571s.bmp, and carriage return line feed is 1 byte (MSDN).

CFile file;

std::vector fileVec;

file.Open("c:\\\\miss\\\\SImages.txt", CFile::modeRead, 0);

char\* pBuf;

char folder\[200\];

strcpy(folder , "C:\\\\miss\\\\");

for (int i = 0; i <96; i++)
{

	pBuf = new char\[200\];

	file.Read( pBuf,20);

	strcat(folder, pBuf);

	fileVec.push\_back(folder);

	delete\[\] pBuf;
}


file.Close();

[Chris Losinger]

looks like the board ate some of your code. how is your vector defined? (what is it a vector of?) -c

---

WWT2D?

Fractals

[nss]

It was avector of CString. However my problem was that I was using CFile when CStdioFile was more suitable and I had overwritten some buffers, but the poor vector got blamed.... Thanks.:)

[Solomon Wu]

CFile file; change std::vector fileVec; to std::vector<string> fileVec; Move strcpy(folder,"c:\\miss\\"); to For Statement

for (int i = 0; i <96; i++) {
strcpy(folder , "C:\\miss\\");
pBuf = new char[200];
file.Read( pBuf,20);
strcat(folder, pBuf);
fileVec.push_back(folder);
delete[] pBuf;
}

Learning and Working

[Jambolo]

Nobody explained the reason for the crash...Without the unimportant stuff, here is what the code looks like. Do you see the problem? char folder[200]; strcpy(folder , "C:\\miss\\"); for (int i = 0; i <96; i++) { ... strcat(folder, pBuf); ... }

[ns]

Yup. I saw finally....my poor "folder" variable was getting concatenated way beyond its allocated space... Thanks Appreciate your help, ns