Is this bad or am I just picky?
-
Came across this "class" during a code review. My reaction is pretty much "the fuck is this". Do you think this is good code or not?
class Listalizer {
public static function listalize( $convert, &$data ) { if ( is\_object( $data ) ) { try { $data = call\_user\_func( $convert, $data ); } catch ( \\Exception $ex ) { try { trigger\_error( "listalize: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::listalize( $convert, $value ); } } } public static function objectify( $convert, &$data, $role = null ) { if ( is\_array( $data ) ) { try { $data = call\_user\_func( $convert, $data, $role ); } catch ( \\Exception $ex ) { try { trigger\_error( "objectify: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::objectify( $convert, $value, $key ); } } } public static function callable2String( $callable ) { if ( is\_array( $callable ) && count( $callable ) === 1 ) { $callable = array\_pop( $callable ); } if ( is\_string( $callable ) ) { return $callable; } elseif ( is\_object( $callable ) ) { return get\_class( $callable ) . '->\_\_invoke'; } elseif ( is\_array( $callable ) ) { $target = $callable\[0\]; -
Came across this "class" during a code review. My reaction is pretty much "the fuck is this". Do you think this is good code or not?
class Listalizer {
public static function listalize( $convert, &$data ) { if ( is\_object( $data ) ) { try { $data = call\_user\_func( $convert, $data ); } catch ( \\Exception $ex ) { try { trigger\_error( "listalize: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::listalize( $convert, $value ); } } } public static function objectify( $convert, &$data, $role = null ) { if ( is\_array( $data ) ) { try { $data = call\_user\_func( $convert, $data, $role ); } catch ( \\Exception $ex ) { try { trigger\_error( "objectify: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::objectify( $convert, $value, $key ); } } } public static function callable2String( $callable ) { if ( is\_array( $callable ) && count( $callable ) === 1 ) { $callable = array\_pop( $callable ); } if ( is\_string( $callable ) ) { return $callable; } elseif ( is\_object( $callable ) ) { return get\_class( $callable ) . '->\_\_invoke'; } elseif ( is\_array( $callable ) ) { $target = $callable\[0\]; -
Came across this "class" during a code review. My reaction is pretty much "the fuck is this". Do you think this is good code or not?
class Listalizer {
public static function listalize( $convert, &$data ) { if ( is\_object( $data ) ) { try { $data = call\_user\_func( $convert, $data ); } catch ( \\Exception $ex ) { try { trigger\_error( "listalize: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::listalize( $convert, $value ); } } } public static function objectify( $convert, &$data, $role = null ) { if ( is\_array( $data ) ) { try { $data = call\_user\_func( $convert, $data, $role ); } catch ( \\Exception $ex ) { try { trigger\_error( "objectify: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::objectify( $convert, $value, $key ); } } } public static function callable2String( $callable ) { if ( is\_array( $callable ) && count( $callable ) === 1 ) { $callable = array\_pop( $callable ); } if ( is\_string( $callable ) ) { return $callable; } elseif ( is\_object( $callable ) ) { return get\_class( $callable ) . '->\_\_invoke'; } elseif ( is\_array( $callable ) ) { $target = $callable\[0\];Too much
$exx
Or not enough...
It was broke, so I fixed it.
-
Yep, PHP. Though some people consider this to be a horror on itself, that's not what I am getting at here :)
Jeroen De Dauw (blog | Twitter | Identi.ca)
-
Came across this "class" during a code review. My reaction is pretty much "the fuck is this". Do you think this is good code or not?
class Listalizer {
public static function listalize( $convert, &$data ) { if ( is\_object( $data ) ) { try { $data = call\_user\_func( $convert, $data ); } catch ( \\Exception $ex ) { try { trigger\_error( "listalize: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::listalize( $convert, $value ); } } } public static function objectify( $convert, &$data, $role = null ) { if ( is\_array( $data ) ) { try { $data = call\_user\_func( $convert, $data, $role ); } catch ( \\Exception $ex ) { try { trigger\_error( "objectify: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::objectify( $convert, $value, $key ); } } } public static function callable2String( $callable ) { if ( is\_array( $callable ) && count( $callable ) === 1 ) { $callable = array\_pop( $callable ); } if ( is\_string( $callable ) ) { return $callable; } elseif ( is\_object( $callable ) ) { return get\_class( $callable ) . '->\_\_invoke'; } elseif ( is\_array( $callable ) ) { $target = $callable\[0\]; -
Came across this "class" during a code review. My reaction is pretty much "the fuck is this". Do you think this is good code or not?
class Listalizer {
public static function listalize( $convert, &$data ) { if ( is\_object( $data ) ) { try { $data = call\_user\_func( $convert, $data ); } catch ( \\Exception $ex ) { try { trigger\_error( "listalize: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::listalize( $convert, $value ); } } } public static function objectify( $convert, &$data, $role = null ) { if ( is\_array( $data ) ) { try { $data = call\_user\_func( $convert, $data, $role ); } catch ( \\Exception $ex ) { try { trigger\_error( "objectify: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::objectify( $convert, $value, $key ); } } } public static function callable2String( $callable ) { if ( is\_array( $callable ) && count( $callable ) === 1 ) { $callable = array\_pop( $callable ); } if ( is\_string( $callable ) ) { return $callable; } elseif ( is\_object( $callable ) ) { return get\_class( $callable ) . '->\_\_invoke'; } elseif ( is\_array( $callable ) ) { $target = $callable\[0\];the f***. developer needs more Argh comments. (am I supposed to include an emoticon?)
-
Came across this "class" during a code review. My reaction is pretty much "the fuck is this". Do you think this is good code or not?
class Listalizer {
public static function listalize( $convert, &$data ) { if ( is\_object( $data ) ) { try { $data = call\_user\_func( $convert, $data ); } catch ( \\Exception $ex ) { try { trigger\_error( "listalize: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::listalize( $convert, $value ); } } } public static function objectify( $convert, &$data, $role = null ) { if ( is\_array( $data ) ) { try { $data = call\_user\_func( $convert, $data, $role ); } catch ( \\Exception $ex ) { try { trigger\_error( "objectify: Callable " . self::callable2String( $convert ) . " caused an exception: " . $ex->getMessage(), E\_USER\_WARNING ); } catch ( \\Exception $exx ) { // Argh! We \*can't\* throw an exception! $exx = (object)$exx; // this is just a breakpoint anchor. } $data = false; } } if ( is\_array( $data ) || $data instanceof \\ArrayObject ) { foreach ( $data as $key => &$value ) { self::objectify( $convert, $value, $key ); } } } public static function callable2String( $callable ) { if ( is\_array( $callable ) && count( $callable ) === 1 ) { $callable = array\_pop( $callable ); } if ( is\_string( $callable ) ) { return $callable; } elseif ( is\_object( $callable ) ) { return get\_class( $callable ) . '->\_\_invoke'; } elseif ( is\_array( $callable ) ) { $target = $callable\[0\];After taking a good look see, this class takes an array, converts it to strings and tests to see if the string is a callable object with a method inside. In PHP, you can assign a function or object name to a string and call it as though you you had hard coded the name in the code. This code, despite all the complaints is actually what you would have to do in order to avoid the exceptions that occur when you call a function or object that does not exist. The author is utilizing a class perhaps to keep all the related code in one place, but a simple function would have sufficed.
-
Could be worse. It could have been vb... :)
I wasn't, now I am, then I won't be anymore.
I am getting tired of silly comments about vb. Presumably by someone who has not checked out vb since vb6.
-
I am getting tired of silly comments about vb. Presumably by someone who has not checked out vb since vb6.
Apparently you missed the Joke icon. I've had to do plenty of vb and vb.net work over the years so I do not speak ignorantly on the matter. :)
I wasn't, now I am, then I won't be anymore.
-
Apparently you missed the Joke icon. I've had to do plenty of vb and vb.net work over the years so I do not speak ignorantly on the matter. :)
I wasn't, now I am, then I won't be anymore.
Damn. I knew I had to get my eyes tested.
-
I am getting tired of silly comments about vb. Presumably by someone who has not checked out vb since vb6.
Last year I translated a whole lot of VB6 code into VB.NET 10. After the project was over he complained that most of my code was unintelligible and "I had used LINQ!"
-
I am getting tired of silly comments about vb. Presumably by someone who has not checked out vb since vb6.