Code as War Crime
-
I haven't been on these forums in a while. But I've come across a coding atrocity so horrible, so offensive, that I have to document it. This is a Windows service. Can you see how the developer accesses database data? (Answer below)
Dim ResultDS As New SqlDataSource
ResultDS.ConnectionString = System.Configuration.ConfigurationManager.AppSettings("JaguarReportingConnectionString").ToString()
ResultDS.SelectCommand = ""ResultDS.[Select](DataSourceSelectArguments.Empty)
Dim dg As New GridView
dg.DataSource = ResultDS
dg.DataBind()
Dim dv As New DataView
Dim dt As New DataTable
dv = ResultDS.Select(DataSourceSelectArguments.Empty)
dt = dv.ToTable()Hint: GridView is from the Web UI control namespace. Did I mention this is a Windows service?
It could be worse. The developer could have started an instance of one of the Microsoft Office applications to do the job (in a service).
Software Zen:
delete this; -
It could be worse. The developer could have started an instance of one of the Microsoft Office applications to do the job (in a service).
Software Zen:
delete this;Yep. And for extra credit he could have used ActiveX to start it on the client! :laugh:
The universe is composed of electrons, neutrons, protons and......morons. (ThePhantomUpvoter)
-
It could be worse. The developer could have started an instance of one of the Microsoft Office applications to do the job (in a service).
Software Zen:
delete this;You're creeping me out. That is exactly what he did with the DataSet!
-
You're creeping me out. That is exactly what he did with the DataSet!
"Your mission, should you choose to accept it, is to eradicate this evil from the world. As always, the Secretary will disavow any knowledge of your actions. This post will self-destruct in five seconds. Good luck, Gordon."
Software Zen:
delete this; -
Yep. And for extra credit he could have used ActiveX to start it on the client! :laugh:
The universe is composed of electrons, neutrons, protons and......morons. (ThePhantomUpvoter)
-
Because I am the AntiChrist, and it's my job to introduce Evil to the world? :laugh:
The universe is composed of electrons, neutrons, protons and......morons. (ThePhantomUpvoter)
-
"Your mission, should you choose to accept it, is to eradicate this evil from the world. As always, the Secretary will disavow any knowledge of your actions. This post will self-destruct in five seconds. Good luck, Gordon."
Software Zen:
delete this;Naw - then the other developers on the team complain because that's the way they have always done it. The senior developer on the team before you doesn't want to take the time and effort to teach more junior developers better ways of doing things. So in the end - you will rip out all the code you wrote, to replace it with 5X more code/execution paths to be tested :-D
Phil
-
I haven't been on these forums in a while. But I've come across a coding atrocity so horrible, so offensive, that I have to document it. This is a Windows service. Can you see how the developer accesses database data? (Answer below)
Dim ResultDS As New SqlDataSource
ResultDS.ConnectionString = System.Configuration.ConfigurationManager.AppSettings("JaguarReportingConnectionString").ToString()
ResultDS.SelectCommand = ""ResultDS.[Select](DataSourceSelectArguments.Empty)
Dim dg As New GridView
dg.DataSource = ResultDS
dg.DataBind()
Dim dv As New DataView
Dim dt As New DataTable
dv = ResultDS.Select(DataSourceSelectArguments.Empty)
dt = dv.ToTable()Hint: GridView is from the Web UI control namespace. Did I mention this is a Windows service?
I'm just a trainee and I still have a LOT to learn (and wrote some sh*tty code myself), but even to me this looks... funny :laugh:
-
I'm just a trainee and I still have a LOT to learn (and wrote some sh*tty code myself), but even to me this looks... funny :laugh:
Look at it hard. Study it. Do the opposite and you'll do well in your career. Best to you.
-
"Your mission, should you choose to accept it, is to eradicate this evil from the world. As always, the Secretary will disavow any knowledge of your actions. This post will self-destruct in five seconds. Good luck, Gordon."
Software Zen:
delete this;I'll assemble my elite team now! Thanks ;-)
-
Look at it hard. Study it. Do the opposite and you'll do well in your career. Best to you.
Thanks! Learning what not to do is also important, that's why I always take a look around here :)
-
I haven't been on these forums in a while. But I've come across a coding atrocity so horrible, so offensive, that I have to document it. This is a Windows service. Can you see how the developer accesses database data? (Answer below)
Dim ResultDS As New SqlDataSource
ResultDS.ConnectionString = System.Configuration.ConfigurationManager.AppSettings("JaguarReportingConnectionString").ToString()
ResultDS.SelectCommand = ""ResultDS.[Select](DataSourceSelectArguments.Empty)
Dim dg As New GridView
dg.DataSource = ResultDS
dg.DataBind()
Dim dv As New DataView
Dim dt As New DataTable
dv = ResultDS.Select(DataSourceSelectArguments.Empty)
dt = dv.ToTable()Hint: GridView is from the Web UI control namespace. Did I mention this is a Windows service?
-
I haven't been on these forums in a while. But I've come across a coding atrocity so horrible, so offensive, that I have to document it. This is a Windows service. Can you see how the developer accesses database data? (Answer below)
Dim ResultDS As New SqlDataSource
ResultDS.ConnectionString = System.Configuration.ConfigurationManager.AppSettings("JaguarReportingConnectionString").ToString()
ResultDS.SelectCommand = ""ResultDS.[Select](DataSourceSelectArguments.Empty)
Dim dg As New GridView
dg.DataSource = ResultDS
dg.DataBind()
Dim dv As New DataView
Dim dt As New DataTable
dv = ResultDS.Select(DataSourceSelectArguments.Empty)
dt = dv.ToTable()Hint: GridView is from the Web UI control namespace. Did I mention this is a Windows service?
Whoever wrote this; should be hanged, drawn and quartered...
CEO at: - Rafaga Systems - Para Facturas - Modern Components for the moment...
-
I haven't been on these forums in a while. But I've come across a coding atrocity so horrible, so offensive, that I have to document it. This is a Windows service. Can you see how the developer accesses database data? (Answer below)
Dim ResultDS As New SqlDataSource
ResultDS.ConnectionString = System.Configuration.ConfigurationManager.AppSettings("JaguarReportingConnectionString").ToString()
ResultDS.SelectCommand = ""ResultDS.[Select](DataSourceSelectArguments.Empty)
Dim dg As New GridView
dg.DataSource = ResultDS
dg.DataBind()
Dim dv As New DataView
Dim dt As New DataTable
dv = ResultDS.Select(DataSourceSelectArguments.Empty)
dt = dv.ToTable()Hint: GridView is from the Web UI control namespace. Did I mention this is a Windows service?
-
Doesn't that run the query twice, too? (Once to bind it to the GridView, which I assume is the big laugh here – does that even work in a service? – and once when initialising dv.)
You're probably right. I was given a task to get it working again. I later learned that it may have *never* worked.
-
I haven't been on these forums in a while. But I've come across a coding atrocity so horrible, so offensive, that I have to document it. This is a Windows service. Can you see how the developer accesses database data? (Answer below)
Dim ResultDS As New SqlDataSource
ResultDS.ConnectionString = System.Configuration.ConfigurationManager.AppSettings("JaguarReportingConnectionString").ToString()
ResultDS.SelectCommand = ""ResultDS.[Select](DataSourceSelectArguments.Empty)
Dim dg As New GridView
dg.DataSource = ResultDS
dg.DataBind()
Dim dv As New DataView
Dim dt As New DataTable
dv = ResultDS.Select(DataSourceSelectArguments.Empty)
dt = dv.ToTable()Hint: GridView is from the Web UI control namespace. Did I mention this is a Windows service?
-
[Reads first line of code] Is that Visual Basic?? There's your problem right there! :laugh: Let the flame war begin (or fizzle out because nobody noticed/cared). :rose:
-
It could be worse. The developer could have started an instance of one of the Microsoft Office applications to do the job (in a service).
Software Zen:
delete this;I've seen people try that - it normally fails, horribly.
"If you don't fail at least 90 percent of the time, you're not aiming high enough." Alan Kay.
-
[Reads first line of code] Is that Visual Basic?? There's your problem right there! :laugh: Let the flame war begin (or fizzle out because nobody noticed/cared). :rose:
I still contend that Object Pascal is the better language! There, feel better? :D
-
I've seen people try that - it normally fails, horribly.
"If you don't fail at least 90 percent of the time, you're not aiming high enough." Alan Kay.
Ignoring the legal implications (server usage of Microsoft Office apps violates the license), the Office apps fail in odd ways or cause unusual server failures when used in this fashion.
Software Zen:
delete this;
