No names, no refences - and not mine.

[OriginalGriff]

That's what's even worse than the code and the design: it's an invoicing system, and these are for the prices he's going to invoice to the customer ... hence the total :sigh:

The universe is composed of electrons, neutrons, protons and......morons. (ThePhantomUpvoter)

[obermd]

I've seen this type of garbage in VC6, VB6, VB.Net, C#, Java, JavaScript, etc. Garbage is garbage - it doesn't depend on the language.

[Jorgen Andersson]

I think the OP is working at my place nowadays[^].

Be excellent to each other. And... PARTY ON, DUDES! Abraham Lincoln

[StM0n]

Agreed... unfortunately :rolleyes:

(yes|no|maybe)*

[Richard C Bishop]

What's wrong with that code? ;P

[OriginalGriff]

Remind me never to employ you! :laugh:

The universe is composed of electrons, neutrons, protons and......morons. (ThePhantomUpvoter)

[Richard C Bishop]

I will just use that code as my resume and the reminding shall occur.

[Rajesh R Subramanian]

Absolutely no comments. :wtf:

"Real men drive manual transmission" - Rajesh.

[Simon ORiordan from UK]

Firstly I'm not dissing Open Source. Just making an observation. I'm quite sure that there is similarly 'bad' code hidden in proprietary. I use nothing but OSS at home(except nvidia) and as much as work will let me, which is why I was trawling the kernel. Besides, the section was in an 'Opened' module which had originally been written as proprietary in the 90s.

[Simon ORiordan from UK]

It certainly works. But when the labelled line merely sets a return value, it would have been more in keeping with C to use multiple return paths.(Perhaps the code was so old the then-compilers couldn't check multiple paths?)

[Clumpco]

Isn't this the original Excel source code?

[ENOTTY]

Well, this is keeping with kernel C style, since having one exit point is a well established pattern (not only) there; it makes it easier to argue about the correctness no matter eventual compiler warnings.

[Lutoslaw]

I don think so. If it was, it would more likely be

ptotal = Double.Parse(Me.txttA.Text) + Double.Parse(Me.txttB.Text) + Double.Parse(Me.txttC.Text) + _
Double.Parse(Me.txttD.Text) + Double.Parse(Me.txttE.Text) + Double.Parse(Me.txttF.Text) + _
Double.Parse(Me.txttG.Text) + Double.Parse(Me.txttH.Text) + Double.Parse(Me.txttI.Text) + _
Double.Parse(Me.txttA0.Text) + Double.Parse(Me.txttAA.Text) + Double.Parse(Me.txttAB.Text) + _
Double.Parse(Me.txttAC.Text) + Double.Parse(Me.txttAD.Text) + Double.Parse(Me.txttAE.Text) + _
Double.Parse(Me.txttAF.Text) + Double.Parse(Me.txttAG.Text) + Double.Parse(Me.txttAH.Text) + _
Double.Parse(Me.txttAI.Text) + Double.Parse(Me.txttB0.Text) + Double.Parse(Me.txttBA.Text) + _
Double.Parse(Me.txttBB.Text) + Double.Parse(Me.txttBC.Text) + Double.Parse(Me.txttBD.Text) + _
Double.Parse(Me.txttBE.Text) + Double.Parse(Me.txttBF.Text) + Double.Parse(Me.txttBG.Text) + _
Double.Parse(Me.txttBH.Text) + Double.Parse(Me.txttBI.Text) + Double.Parse(Me.txttC0.Text) + _
Double.Parse(Me.txttCA.Text) + Double.Parse(Me.txttCB.Text) + Double.Parse(Me.txttCC.Text) + _
Double.Parse(Me.txttCD.Text) + Double.Parse(Me.txttCE.Text) + Double.Parse(Me.txttCF.Text) + _
Double.Parse(Me.txttCG.Text) + Double.Parse(Me.txttCH.Text) + Double.Parse(Me.txttCI.Text) + _
Double.Parse(Me.txttD0.Text) + Double.Parse(Me.txttDA.Text) + Double.Parse(Me.txttDB.Text) + _
Double.Parse(Me.txttDC.Text) + Double.Parse(Me.txttDD.Text) + Double.Parse(Me.txttDE.Text) + _
Double.Parse(Me.txttDF.Text) + Double.Parse(Me.txttDG.Text) + Double.Parse(Me.txttDH.Text) + _
Double.Parse(Me.txttDI.Text) + Double.Parse(Me.txttE0.Text)

Greetings - Jacek

[Killzone DeathMan]

What else can you do? Well lets seeeeee......

double ptotal = 0;

foreach(Control ctrl in this.controls)
{
if(ctrl is TextBox)
ptotal += Double.Parse(ctrl.Text);
}