How To Use Session Variables
-
I'm re-writing a legacy ASP application. There's an expensive call to an external webservice and a database to determine a calculated setting specific to the person logged in. On the first page this calculation is done and the result is stored in a session variable. On every subsequent page the session variable is ignore, the value is recalculated and then stored in the session variable again! Some days I don't know if to laugh or cry.
-
I'm re-writing a legacy ASP application. There's an expensive call to an external webservice and a database to determine a calculated setting specific to the person logged in. On the first page this calculation is done and the result is stored in a session variable. On every subsequent page the session variable is ignore, the value is recalculated and then stored in the session variable again! Some days I don't know if to laugh or cry.
Sometimes, you just want to go into a code review with a baseball bat and a spiked glove... :sigh:
The universe is composed of electrons, neutrons, protons and......morons. (ThePhantomUpvoter)
-
I'm re-writing a legacy ASP application. There's an expensive call to an external webservice and a database to determine a calculated setting specific to the person logged in. On the first page this calculation is done and the result is stored in a session variable. On every subsequent page the session variable is ignore, the value is recalculated and then stored in the session variable again! Some days I don't know if to laugh or cry.
-
Cool, who ever wrote the code invented the write-only variable.. What shall we call it? "Wrariable"?
That kind of innovation must be why this guy is now a manager. My only solace in that is that he's no longer writing "code".
-
That kind of innovation must be why this guy is now a manager. My only solace in that is that he's no longer writing "code".
-
He's a manager now? Well, that explains a lot. I know quite some managers who also write (or wrote) code, and that was among the most horrible code I've ever seen. Think you still might find examples here in TWATW.
imagiro wrote:
He's a manager now? Well, that explains a lot. I know quite some managers who also write (or wrote) code, and that was among the most horrible code I've ever seen. Think you still might find examples here in TWATW.
Remember the old saying: "Those that can't do, manage!" Update: LOL ... Isfeasachme, whoever that is, just posted a flaming reply to my message. Listen sport, I have been writing code probably since you were born, enough with the sanctimony. I've seen plenty of inept management in my days and very frequently they were coder's who couldn't hack it (no pun intended). As sharp as you are, you couldn't refrain from a flame which was copied to my inbox before you removed same. Chill out man! ;)
-
I'm re-writing a legacy ASP application. There's an expensive call to an external webservice and a database to determine a calculated setting specific to the person logged in. On the first page this calculation is done and the result is stored in a session variable. On every subsequent page the session variable is ignore, the value is recalculated and then stored in the session variable again! Some days I don't know if to laugh or cry.
-
imagiro wrote:
He's a manager now? Well, that explains a lot. I know quite some managers who also write (or wrote) code, and that was among the most horrible code I've ever seen. Think you still might find examples here in TWATW.
Remember the old saying: "Those that can't do, manage!" Update: LOL ... Isfeasachme, whoever that is, just posted a flaming reply to my message. Listen sport, I have been writing code probably since you were born, enough with the sanctimony. I've seen plenty of inept management in my days and very frequently they were coder's who couldn't hack it (no pun intended). As sharp as you are, you couldn't refrain from a flame which was copied to my inbox before you removed same. Chill out man! ;)
I love how you punk know-it-all coders who havent an ounce of business experience jump on disrespect for managers. My job as a manager is to keep the shitstorm of indecision and wildly fluctuating targets from disrupting your pretty little land of unicorns and code. The corporate world just past the tip of your nose could care a smear of crap about your elegant solution that took 4x 2-liter caffeinated days to figure out. They don't get code reviews, buggy compilers, platform quirks, scalability or error trapping. All that blather means to them is more time and money "wasted". I get the joy of "selling" the idea that the prototype demo, while working for the presentation is still 3 months out from production. If you are lucky, we are coders and can empathize with you, but coding is not revenue and revenue is what pays your salary. If you so much as open your mouth to argue that point, I will offshore your job to some guys who turn out shitty, useless code that barely works because that is what everyone above my head thinks they want. :mad::mad::mad:
-
Cool, who ever wrote the code invented the write-only variable.. What shall we call it? "Wrariable"?
-
I'm re-writing a legacy ASP application. There's an expensive call to an external webservice and a database to determine a calculated setting specific to the person logged in. On the first page this calculation is done and the result is stored in a session variable. On every subsequent page the session variable is ignore, the value is recalculated and then stored in the session variable again! Some days I don't know if to laugh or cry.
You never know, maybe the external system changed its mind after the first call to it... :rolleyes:
CEO at: - Rafaga Systems - Para Facturas - Modern Components for the moment...
-
That kind of innovation must be why this guy is now a manager. My only solace in that is that he's no longer writing "code".
AnalogNerd wrote:
My only solace in that is that he's no longer writing "code".
I had the same feelings about my former Bitch Supervisor From Helltm. She barely understood coding concepts and management recognized that she knew enough to be dangerous and she was good at cracking the whip, so she was promoted to supervisor. She was terribly insecure and terrified that I wanted her job (I didn't) and compensated by being a total control freak. Those of us on her team have hours of stories we could tell about her incompetence. I always said that if her manager had ever come to an abrupt halt, they'd need an emergency room proctologist to save her. Instead she was eventually promoted to be the assistant to the new technology vice-president. However after the company realized he was only a hot bag of buzzwords and equally incompetent, he was given the boot and she was out the door shortly after.
Psychosis at 10 Film at 11 Those who do not remember the past, are doomed to repeat it. Those who do not remember the past, cannot build upon it.
-
AnalogNerd wrote:
My only solace in that is that he's no longer writing "code".
I had the same feelings about my former Bitch Supervisor From Helltm. She barely understood coding concepts and management recognized that she knew enough to be dangerous and she was good at cracking the whip, so she was promoted to supervisor. She was terribly insecure and terrified that I wanted her job (I didn't) and compensated by being a total control freak. Those of us on her team have hours of stories we could tell about her incompetence. I always said that if her manager had ever come to an abrupt halt, they'd need an emergency room proctologist to save her. Instead she was eventually promoted to be the assistant to the new technology vice-president. However after the company realized he was only a hot bag of buzzwords and equally incompetent, he was given the boot and she was out the door shortly after.
Psychosis at 10 Film at 11 Those who do not remember the past, are doomed to repeat it. Those who do not remember the past, cannot build upon it.
-
I'm re-writing a legacy ASP application. There's an expensive call to an external webservice and a database to determine a calculated setting specific to the person logged in. On the first page this calculation is done and the result is stored in a session variable. On every subsequent page the session variable is ignore, the value is recalculated and then stored in the session variable again! Some days I don't know if to laugh or cry.
I am relatively new to this sort of thing and I currently use a different language but reading this thread makes me wonder if there is an issue with using session variables? I am upgrading a program that currently uses POST method to transfer small portions of data between screens and I want to reduce the number of screens and to do this I need to transfer larger data sets. Using Session variables seem like a better idea since they are more persistent and are there through the whole session. For the original poster it would seem that it would be easy to check the session variable to see if it exists and if it doesn't then calculate it otherwise use the session variable and continue? Seems like a simple bug to fix to me. But I only have experience with PHP with this at this point and am still learning. I have not even attempted to learn ASP.
-
I am relatively new to this sort of thing and I currently use a different language but reading this thread makes me wonder if there is an issue with using session variables? I am upgrading a program that currently uses POST method to transfer small portions of data between screens and I want to reduce the number of screens and to do this I need to transfer larger data sets. Using Session variables seem like a better idea since they are more persistent and are there through the whole session. For the original poster it would seem that it would be easy to check the session variable to see if it exists and if it doesn't then calculate it otherwise use the session variable and continue? Seems like a simple bug to fix to me. But I only have experience with PHP with this at this point and am still learning. I have not even attempted to learn ASP.
What you say is what should have been done. The code should check the session variable, if it is null then go to the database and 3rd party API and calculate the value needed, and store it in the session variable for later use. In this way it's basically using the session variable for caching a value that is expensive to calculate and doesn't change often. I posted this because what the person who actually wrote this did was kind of a face-palm moment. They write the value into the session variable and then never read from the session variable again. Every time this value was needed they calculated it, then wrote the calculated value into the session variable only to never retreive it and do anything with it.
