How to create an audit table?
-
Do you know if it exist a document or recommendation to create audit table or metadata elements on a database. I ask this question because I just saw this :
CREATE TABLE client (
id char(36) NOT NULL,
first_name varchar(255) NOT NULL,
last_name varchar(255) NOT NULL,
creation_date timestamp NOT NULL,
update_date timestamp NOT NULL,
CONSTRAINT client_pk PRIMARY KEY (id)
);I don't like the idea to have metadata like creation_date and update_date in a business oriented table. Actually these two fields exists in all tables of this database. What if I create a audit table like this:
CREATE TABLE audit (
table_name char(32) NOT NULL,
fk char(36) NOT NULL,
update_date timestamp NOT NULL
);I don't need a creation date because the creation date is my first record with table_name and fk in this table. I could add a columns to add insert, update, delete information. With thi table I keep all my update dates and not only the last one. Is this audit table a god practice ? Can I also use this audit table to avoid conflict. You know when two users update the same record at the same time. It's possible to use the last update time to warn them there is a conflict.
Personally I don't consider that an audit solution, I say solution because audit is a whole lot of objects. We do a field level audit so we can track any changes to the data. Simply the ID for an inserted record, each field that is changed - only getting the from value and each field from a deleted record. In theory this allows us to reproduce any action done by the users. Also we do not audit every table as the apps we build are based on other systems so we only track the master table changes. The audit is initiated by a trigger spit, the ONLY valid use for the dammed things. This is our audit table.
CREATE TABLE [dbo].[AuditLog](
[AuditID] [INT] IDENTITY(1,1) NOT NULL,
[Action] [CHAR](1) NULL,
[TableName] [VARCHAR](128) NULL,
[PrimaryKeyField] [VARCHAR](1000) NULL,
[PrimaryKeyValue] [VARCHAR](1000) NULL,
[FieldName] [VARCHAR](500) NULL,
[OldValue] [VARCHAR](1000) NULL,
[ModifiedDate] [DATETIME] NULL,
[UserName] [VARCHAR](200) NULL
) ON [PRIMARY]Every table has a modified and modifiedby field. We also have a table of table names that allows us to run a script and apply/remove triggers from the target tables. As I said theres a whole ecosystem for auditing and it all lives in our model database so it is automatically included in every new database created. In a vast number of years building LOB apps and some of them transactional I have never been hit by the condition of 2 users editing the same record except in 2 cases, contrived conditions to test the effect and in the early 90s using Microsoft Access in a multi user environment. It is a completed furfy IMNSHO.
Never underestimate the power of human stupidity RAH
-
Personally I don't consider that an audit solution, I say solution because audit is a whole lot of objects. We do a field level audit so we can track any changes to the data. Simply the ID for an inserted record, each field that is changed - only getting the from value and each field from a deleted record. In theory this allows us to reproduce any action done by the users. Also we do not audit every table as the apps we build are based on other systems so we only track the master table changes. The audit is initiated by a trigger spit, the ONLY valid use for the dammed things. This is our audit table.
CREATE TABLE [dbo].[AuditLog](
[AuditID] [INT] IDENTITY(1,1) NOT NULL,
[Action] [CHAR](1) NULL,
[TableName] [VARCHAR](128) NULL,
[PrimaryKeyField] [VARCHAR](1000) NULL,
[PrimaryKeyValue] [VARCHAR](1000) NULL,
[FieldName] [VARCHAR](500) NULL,
[OldValue] [VARCHAR](1000) NULL,
[ModifiedDate] [DATETIME] NULL,
[UserName] [VARCHAR](200) NULL
) ON [PRIMARY]Every table has a modified and modifiedby field. We also have a table of table names that allows us to run a script and apply/remove triggers from the target tables. As I said theres a whole ecosystem for auditing and it all lives in our model database so it is automatically included in every new database created. In a vast number of years building LOB apps and some of them transactional I have never been hit by the condition of 2 users editing the same record except in 2 cases, contrived conditions to test the effect and in the early 90s using Microsoft Access in a multi user environment. It is a completed furfy IMNSHO.
Never underestimate the power of human stupidity RAH
I will second Mycroft's design which is almost identical to the audit table I created. CRUD dates alone will be of little help as they will not give any context to the data. Audit tends to mean that you can rebuild a row's values at any point in time.
“That which can be asserted without evidence, can be dismissed without evidence.”
― Christopher Hitchens
-
Personally I don't consider that an audit solution, I say solution because audit is a whole lot of objects. We do a field level audit so we can track any changes to the data. Simply the ID for an inserted record, each field that is changed - only getting the from value and each field from a deleted record. In theory this allows us to reproduce any action done by the users. Also we do not audit every table as the apps we build are based on other systems so we only track the master table changes. The audit is initiated by a trigger spit, the ONLY valid use for the dammed things. This is our audit table.
CREATE TABLE [dbo].[AuditLog](
[AuditID] [INT] IDENTITY(1,1) NOT NULL,
[Action] [CHAR](1) NULL,
[TableName] [VARCHAR](128) NULL,
[PrimaryKeyField] [VARCHAR](1000) NULL,
[PrimaryKeyValue] [VARCHAR](1000) NULL,
[FieldName] [VARCHAR](500) NULL,
[OldValue] [VARCHAR](1000) NULL,
[ModifiedDate] [DATETIME] NULL,
[UserName] [VARCHAR](200) NULL
) ON [PRIMARY]Every table has a modified and modifiedby field. We also have a table of table names that allows us to run a script and apply/remove triggers from the target tables. As I said theres a whole ecosystem for auditing and it all lives in our model database so it is automatically included in every new database created. In a vast number of years building LOB apps and some of them transactional I have never been hit by the condition of 2 users editing the same record except in 2 cases, contrived conditions to test the effect and in the early 90s using Microsoft Access in a multi user environment. It is a completed furfy IMNSHO.
Never underestimate the power of human stupidity RAH
Mycroft Holmes wrote:
I have never been hit by the condition of 2 users editing the same record except in 2 cases
That doesn't mean that the concurrency-issue does not exist. Depending on the amount of operations, once in a million could happen next monday.
Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]
-
Mycroft Holmes wrote:
I have never been hit by the condition of 2 users editing the same record except in 2 cases
That doesn't mean that the concurrency-issue does not exist. Depending on the amount of operations, once in a million could happen next monday.
Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]
Eddy Vluggen wrote:
Depending on the amount of operations, once in a million could happen next monday.
No that isn't what that means at all. If you have a business case where modification of the same record by two users can occur then the number of operations has nothing to do with it. When one has such a business case then one should of course take the necessary precautions, based on business needs (not just implementation hacking) to insure that a the best and most correct result is arrived at. If there is no business case then the only way that can happen is due to poor design and/or implementation. Or perhaps just flat out wrong design/implementation.
-
Personally I don't consider that an audit solution, I say solution because audit is a whole lot of objects. We do a field level audit so we can track any changes to the data. Simply the ID for an inserted record, each field that is changed - only getting the from value and each field from a deleted record. In theory this allows us to reproduce any action done by the users. Also we do not audit every table as the apps we build are based on other systems so we only track the master table changes. The audit is initiated by a trigger spit, the ONLY valid use for the dammed things. This is our audit table.
CREATE TABLE [dbo].[AuditLog](
[AuditID] [INT] IDENTITY(1,1) NOT NULL,
[Action] [CHAR](1) NULL,
[TableName] [VARCHAR](128) NULL,
[PrimaryKeyField] [VARCHAR](1000) NULL,
[PrimaryKeyValue] [VARCHAR](1000) NULL,
[FieldName] [VARCHAR](500) NULL,
[OldValue] [VARCHAR](1000) NULL,
[ModifiedDate] [DATETIME] NULL,
[UserName] [VARCHAR](200) NULL
) ON [PRIMARY]Every table has a modified and modifiedby field. We also have a table of table names that allows us to run a script and apply/remove triggers from the target tables. As I said theres a whole ecosystem for auditing and it all lives in our model database so it is automatically included in every new database created. In a vast number of years building LOB apps and some of them transactional I have never been hit by the condition of 2 users editing the same record except in 2 cases, contrived conditions to test the effect and in the early 90s using Microsoft Access in a multi user environment. It is a completed furfy IMNSHO.
Never underestimate the power of human stupidity RAH
Mycroft Holmes wrote:
Personally I don't consider that an audit solution, I say solution because audit is a whole lot of objects.
However that should depend on business needs. If you need to track every change in the system then something like your solution is required. But there can be a much lower need so less of a solution might be sufficient.
Mycroft Holmes wrote:
In a vast number of years building LOB apps and some of them transactional I have never been hit by the condition of 2 users editing the same record
I have seen a number of developers and QA people come up with that situation. Took me quite a few years to realize that I should start asking them what their business case was for the scenario.
-
Eddy Vluggen wrote:
Depending on the amount of operations, once in a million could happen next monday.
No that isn't what that means at all. If you have a business case where modification of the same record by two users can occur then the number of operations has nothing to do with it. When one has such a business case then one should of course take the necessary precautions, based on business needs (not just implementation hacking) to insure that a the best and most correct result is arrived at. If there is no business case then the only way that can happen is due to poor design and/or implementation. Or perhaps just flat out wrong design/implementation.
jschell wrote:
based on business needs (not just implementation hacking) to insure that a the best and most correct result is arrived at.
Two of us get called by a customer and update the same issue in the bugtracker. Whose result is the most "best and correct"? You better make sure it's my edit, not yours.
Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]
-
jschell wrote:
based on business needs (not just implementation hacking) to insure that a the best and most correct result is arrived at.
Two of us get called by a customer and update the same issue in the bugtracker. Whose result is the most "best and correct"? You better make sure it's my edit, not yours.
Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]
Eddy Vluggen wrote:
Two of us get called by a customer and update the same issue in the bugtracker
I would contend that that is not a reasonable business case, the same bug. Still it MAY be possible and you would have to design around it. However most requirements for this are just not reasonable.
Never underestimate the power of human stupidity RAH
-
Mycroft Holmes wrote:
Personally I don't consider that an audit solution, I say solution because audit is a whole lot of objects.
However that should depend on business needs. If you need to track every change in the system then something like your solution is required. But there can be a much lower need so less of a solution might be sufficient.
Mycroft Holmes wrote:
In a vast number of years building LOB apps and some of them transactional I have never been hit by the condition of 2 users editing the same record
I have seen a number of developers and QA people come up with that situation. Took me quite a few years to realize that I should start asking them what their business case was for the scenario.
jschell wrote:
However that should depend on business needs
Always, this is the mantra I repeat at the start of every requirements meeting, I want it tattoo'd on the foreheads of every BA, I want "it is your job to interpret their requirements CORRECTLY" tattoo'd on their buts! I'm old I've been doing this for a bloody long time, the number of times I have had this argument discussion with BAs and user are innumerable. I just hate it when I have to pound it into the head of a senior dev. Mind you I'm delighted when they (the BAs and senior devs) come up with some novel concepts especially when they work.
Never underestimate the power of human stupidity RAH
-
jschell wrote:
based on business needs (not just implementation hacking) to insure that a the best and most correct result is arrived at.
Two of us get called by a customer and update the same issue in the bugtracker. Whose result is the most "best and correct"? You better make sure it's my edit, not yours.
Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]
Eddy Vluggen wrote:
Two of us get called by a customer and update the same issue in the bugtracker
Ok. First exactly what sort of business scenario is going to lead to two different customer employees to call at the same time to have one modify the very same bug? Second presumably you are referring to that those two different customer employees are acting independently and both wish to resolve the bug, and not just comment on it, in different ways. So exactly how, in terms of business usage, if those two same people called at different times would you correctly resolve updating the status two completely different ways? Say one calls on tuesday and says they want to close the bug as no longer applicable and a completely different person calls on wednesday and says they want to increase the priority to critical. Exactly how is your software, and only your software, going to resolve that? And just to make it more fun lets say the guy on tuesday is the CTO of the customers company and the guy on wednesday is a junior developer. (Keeping in mind of course that this is your scenario where two completely different people are interacting with your company at the same time.) Third, "Whose result is the most 'best and correct'?", is exactly the question. That is business decision not a software decision. You cannot write software that is going to answer that question.
-
Eddy Vluggen wrote:
Two of us get called by a customer and update the same issue in the bugtracker
Ok. First exactly what sort of business scenario is going to lead to two different customer employees to call at the same time to have one modify the very same bug? Second presumably you are referring to that those two different customer employees are acting independently and both wish to resolve the bug, and not just comment on it, in different ways. So exactly how, in terms of business usage, if those two same people called at different times would you correctly resolve updating the status two completely different ways? Say one calls on tuesday and says they want to close the bug as no longer applicable and a completely different person calls on wednesday and says they want to increase the priority to critical. Exactly how is your software, and only your software, going to resolve that? And just to make it more fun lets say the guy on tuesday is the CTO of the customers company and the guy on wednesday is a junior developer. (Keeping in mind of course that this is your scenario where two completely different people are interacting with your company at the same time.) Third, "Whose result is the most 'best and correct'?", is exactly the question. That is business decision not a software decision. You cannot write software that is going to answer that question.
jschell wrote:
First exactly what sort of business scenario is going to lead to two different customer employees to call at the same time to have one modify the very same bug?
Try the one I painted.
jschell wrote:
Second presumably you are referring to that those two different customer employees are acting independently and both wish to resolve the bug, and not just comment on it, in different ways.
Yeah, easiest way to not have the problem is to not edit, but to add.
jschell wrote:
would you correctly resolve updating the status two completely different ways?
Yes. But then again, we already noted that adding a record, as opposed to editing one, would solve that.
Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]
-
jschell wrote:
First exactly what sort of business scenario is going to lead to two different customer employees to call at the same time to have one modify the very same bug?
Try the one I painted.
jschell wrote:
Second presumably you are referring to that those two different customer employees are acting independently and both wish to resolve the bug, and not just comment on it, in different ways.
Yeah, easiest way to not have the problem is to not edit, but to add.
jschell wrote:
would you correctly resolve updating the status two completely different ways?
Yes. But then again, we already noted that adding a record, as opposed to editing one, would solve that.
Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]
Eddy Vluggen wrote:
Try the one I painted.
You have a customer with two different employees. Both of them call the service desk at 8:50am on Tuesday June 6th. Both want to do wildly different things to the same thing. This means the customer has tasked them both with the same task. And that both reached wildly different outcomes with regard to what should happen. No that doesn't seem like a scenario which is likely to occur and in fact is wildly unlikely to occur. Thus prioritizing this even to the extent of writing the requirement much less implementing it seems very unlikely.
Eddy Vluggen wrote:
But then again, we already noted that adding a record, as opposed to editing one, would solve that.
But again that is not the point. There are valid, probable and needful reasons for adding a record versus update that have nothing to do with the highly likely scenario that you have posited.