"...using the best programming practice..." yes sure

[PIEBALDconsult]

How else would you do it? Other than, of course, eliminating the #else by putting the right-parenthesis outside the #if .

[Andres Cassagnes]

leaving V_OK = 0 whenever you don't define SEANSAR maybe. If I could I would put all the code here for you to see what I have to strugle every day. There are violations to every single "good programing practice", starting for the encapsulation, with a lot of variables and defines mixed in separated and "isolated" modules.

[PIEBALDconsult]

But this way eliminates a test when you don't have SENSAR; ergo it's FFFAAASSSTTTEEERRR... :cool: Why test something that's always true?

[Andres Cassagnes]

Maybe, but this things makes the code unclear and dificults the scalability. Anyway you are right in the fact that it is faster, innecesarily and almost insignificaly faster

[Bernhard Hiller]

You're absolutely right. You ought to write it more concise:

if((error == 0)
#ifdef SENSAR
|| (V_OK == 0)
#endif
)

Much cleaner now!

[Patrice T]

I would have write it that way.

#ifdef SENSAR
if((error == 0) || (V_OK == 0))
#else
if((error == 0))
#endif

Patrice “Everything should be made as simple as possible, but no simpler.” Albert Einstein

[Nicholas Marty]

But when working with microcontrollers performance and memory management are important, aren't they? And many small things might lead to a noticeable gain in that.

[BillW33]

I have to agree, it is easier to read that way.

Just because the code works, it doesn't mean that it is good code.

[KarstenK]

Such messie code is dangerous as gasoline. One error and everything blows up. I wont accept such stuff from my collegues. :mad:

Press F1 for help or google it. Greetings from Germany

[Mohibur Rashid]

I was going to say that. Sometime had to do weird trick, that looked really ugly, just to save program memory :D (PIC16F84)

I do not fear of failure. I fear of giving up out of frustration.

[RugbyLeague]

still has double parentheses on the 2nd case. That will slow the compiler massively :)

[Patrice T]

I didn't try to optimise, just to make it easier to read.

Patrice “Everything should be made as simple as possible, but no simpler.” Albert Einstein