Paid per line of code???

ZurdoDev

Some people prefer to spell it out rather than jam it all into a single line. :^)

There are only 10 types of people in the world, those who understand binary and those who don't.

jeron1

I agree it's ugly, could it be that orphan was used in other places at some point?

"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment "Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst "I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle

jgakenhe

You must have just gotten a job in my organization.

Nathan Minier

Ah, when the initial commit from psudocode doesn't ever cleaned up. Good days.

"There are three kinds of lies: lies, damned lies and statistics." - Benjamin Disraeli

Bernhard Hiller

How ugly that code is with its inconsistent naming! Tell those poor code monkeys to clean it up: it must be boolOrphan instead of orphan, and strMessage instead of message! How come it they forgot half of their VB6 wisdom?

V 0

if (orphan)
{
string message = "orphan detected intJobCategoryJobTypeID=" + intId.ToString();
this.state.Status = message;
}

if (orphan)
{
string message = "";
message = "orphan detected intJobCategoryJobTypeID=";
message += intId.ToString();
this.state.Status = message;
}

Of course concatenating strings is not very productive, so you could create a Stringbuilder, concatenate the pieces, create a string with the toString method and set that string to the Status variable. Forgive the person who wrote that, he's just a padawan learner ;P

V.

(MQOTD rules and previous solutions)

F ES Sitecore

A stringbuilder to concatenate two strings is overkill, you could just use string.Concat, it has the same benefits of the StringBuilder without the overhead of creating an object and without any risk that memory needs reallocated multiple times. You should only use stringbuilder if the size of the resultant text can't easily be known, or if you know you are going to do a lot of concatenation.

F ES Sitecore

That's what I thought, maybe the variable was originally used elsewhere but that code deleted and this not tidied up. Also compiler optimisation would probably fix this code anyway.

V 0

it was a quick joke, not a serious reply.

V.

(MQOTD rules and previous solutions)

F ES Sitecore

Code iz serius bizness!!1

V 0

:-D

V.

(MQOTD rules and previous solutions)

WiganLatics

That's what I hoped but I checked through the revision history and no sign of it being used.

Nathan Minier

Hungarian Notation: For when intellisense just seems too hard.

"There are three kinds of lies: lies, damned lies and statistics." - Benjamin Disraeli

Lost User

'False' Hungarian uses the prefixes to describe types. Instead, the prefixes were intended to describe the usage of the variable. Remember such things as 'lpstr', a long pinter to a string terminated by zero? Can Intellisense do that as well?

The language is JavaScript. that of Mordor, which I will not utter here
This is Javascript. If you put big wheels and a racing stripe on a golf cart, it's still a fucking golf cart.
"I don't know, extraterrestrial?" "You mean like from space?" "No, from Canada." If software development were a circus, we would all be the clowns.

Nathan Minier

An absolutely fair point that unfortunately does not describe the usage I see in web applications. I apologize for maligning Hungarian Notation. I may have simply lost my mind after seeing lblLabel one too many times.

"There are three kinds of lies: lies, damned lies and statistics." - Benjamin Disraeli

Lost User

That's why I still like oldschool machine code. You can't do very much wrong with hexadecimal. :-)

The language is JavaScript. that of Mordor, which I will not utter here
This is Javascript. If you put big wheels and a racing stripe on a golf cart, it's still a fucking golf cart.
"I don't know, extraterrestrial?" "You mean like from space?" "No, from Canada." If software development were a circus, we would all be the clowns.

den2k88

Debug purposes or planned mechanics never introduced. It happens.

GCS d--- s-/++ a- C++++ U+++ P- L- E-- W++ N++ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t++ 5? X R++ tv-- b+ DI+++ D++ G e++>+++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X If you think 'goto' is evil, try writing an Assembly program without JMP. -- TNCaver When I was six, there were no ones and zeroes - only zeroes. And not all of them worked. -- Ravi Bhavnani