new bool()

Sander Rossel

Just in case your bools give you a NullReferenceException. And your BaR s have trailing spaces and lower cases. And you really need those if else statements... Just out of curiosity, are you sure Trim() also trims uppercased spaces? :D

Best, Sander arrgh.js - Bringing LINQ to JavaScript SQL Server for C# Developers Succinctly Object-Oriented Programming in C# Succinctly

Lost User

You joke, but I've seen code that "uppercased" spaces to \0

Jon McKee

A little pointless but not too crazy. bool is just an alias for System.Boolean. The else was the silly part.

Boolean isOffset = new Boolean(); //default false
if (reader["foo"].ToString().ToUpper().Trim() == "BAR")
isOffset = Boolean.Parse(Boolean.TrueString);

Though I suspect unlike above that true and false are probably aliases for pre-defined constants. Couldn't find documentation on how they're created; above was just a guess using public Boolean members. Also true and false are operators that can be overloaded to create nullable types prior to .NET 2.0 (Nullable). Of course it's still silly to do it this way. bool is shorter to write and using true and false is both clearer and shorter.

Jon McKee

That is legitimately frightening :wtf:

Lost User

This goes well with a comment such as // deep copy of true

Marc Clifton

Well, the whole thing could be reduced to

bool isOffset = reader["foo"].ToString().ToUpper().Trim() == "BAR";

Why couldn't the programmer see that? Why didn't someone in the 2+ years that this code has been in production fix it? Marc

V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

Jon McKee

Very true! :thumbsup: I was just pointing out that new bool() isn't as crazy as it looks at first glance :)

Marc Clifton

Jon McKee wrote:

I was just pointing out that new bool() isn't as crazy as it looks at first glance

Quite so. I don't usually even think about bool being shorthand for System.Boolean, and it's good to be reminded of the deeper nuances of the language. Marc

V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

Lost User

FWIW while bool is "sort of a struct", like all primitive types instances of it are "created" (without any ctors being called) by MSIL instructions, eg `true` is created by ldc.i4.1 And `new bool()` *literally is* (not just sort of metaphysically/hypothetically according to an AS-IF rule but the literal compiler output) ldc.i4.0 I guess the moral of this story is that bool is int

Jon McKee

Interesting. Looking at the CLI Specification[^] I.8.2.2 on page 46 that makes sense. Under all the abstraction it's an integer type.

Bernhard Hiller

Well, look: a variable must be initialized before it can be used. Now just imagine: somehow a third possibility comes into existence which is not covered by that if ... else - now you'll run into an error when you access isOffset because it was not initialized. :^)

OriginalGriff

So you want

if (...)
...
else
...
maybe
...

:laugh:

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Kornfeld Eliyahu Peter

Do you have a keyboard? Hit CTRL+A/Del and save us!

Skipper: We'll fix it. Alex: Fix it? How you gonna fix this? Skipper: Grit, spit and a whole lotta duct tape.

Mike Hankey

bool IsOffSet = new bool { improved };

New version: WinHeist Version 2.2.2 Beta
I told my psychiatrist that I was hearing voices in my head. He said you don't have a psychiatrist!

Jorgen Andersson

Reminds me of the fuzzy logic that was so popular in the beginning of the nineties.

Wrong is evil and must be defeated. - Jeff Ello

Johnny YYZ

Marc Clifton wrote:

Well, the whole thing could be reduced to

I guess it can if reader["foo"] can never return null.

Jeremy Falcon

So, just for my own understanding then, something like this would be better then correct? ...

bool isOffset = (reader["foo"]?.ToString().ToUpper().Trim() == "BAR") ?? false;

Jeremy Falcon

Lost User

Marc Clifton wrote:

Why couldn't the programmer see that? Why didn't someone in the 2+ years that this code has been in production fix it?

I have always predicted that this type would show up on the scene sooner or later and, by now, have seen them in action often enough. They actually do as they were told and avoided memory management at all cost. That is why they have no understanding what value types and reference types are all about, nor do they have any idea how value types are an illusion created by the compiler to spare us having to wrestle with references and check for null for every variable. To them these things make no sense and appear to be some random and arcane rules which have been inherited from languages of the past. The same goes for logical operators. I have given up on trying to help the kids when they can't get it done. They think that's more of this arcane ancient stuff that nobody needs to know anymore. Letting them figure it out themselves is the only way to convince them otherwise. So be it.

The language is JavaScript. that of Mordor, which I will not utter here
This is Javascript. If you put big wheels and a racing stripe on a golf cart, it's still a fucking golf cart.
"I don't know, extraterrestrial?" "You mean like from space?" "No, from Canada." If software development were a circus, we would all be the clowns.