Let's REALLY make sure "4" isn't "5"
-
"You will save a lot of time only typing 2 or 3 letter variable names instead of those long names. Therefore you will be able to program faster if you keep your variable names short." At a previous job, that is what one of the senior programmers would teach to the new programmers and the boss (who was also a programmer) agreed with him. :wtf: X| There are reasons why I don't work there any longer. ;)
Just because the code works, it doesn't mean that it is good code.
BillW33 wrote:
You will save a lot of time only typing 2 or 3 letter variable names instead of those long names.
And here I thought if you use shorter variable names, the program runs faster! :-D
Latest Article - A Concise Overview of Threads Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802
-
Was it originally a set of nested if and they just missed that one?
MarkTJohnson wrote:
Was it originally a set of nested if and they just missed that one?
I have no idea, and I didn't want to look through the TFS change history to find out. :laugh:
Latest Article - A Concise Overview of Threads Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802
-
Good grief. I keep telling my techie wife that soon you'll see critical systems failing left and right that used to work pretty well. Shoot, maybe that's why AI is all the rage today. Were scared of, let's just call em the up and comers.
Maybe they need to check that left!=right ?
CQ de W5ALT
Walt Fair, Jr., P. E. Comport Computing Specializing in Technical Engineering Software
-
switch (str)
{
case "4":
if (str != "5") ...Ah, the joys of outsourcing with no code reviews.
Latest Article - A Concise Overview of Threads Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802
Hey now, that could actually be a valid check! :laugh:
public class Stringy
{
private string Value { get; set; }public Stringy(string value) { Value = value; } public static implicit operator string(Stringy s) { string value = s.Value; if (s.Value == "4") s.Value = "5"; return value; }}
Which lets you write code like this:
var str = new Stringy("4");
if (str == "4" && str == "5")
Console.WriteLine("LOL");Which will, of course, print LOL to the console. Though I imagine you'd only do something like this if you really, really hate your co-workers.
-
I recently inherited a load of "code" (it's VBA so I don't want to it ideas above its station :laugh: ) ... during the "handover" (apparently that's what it was) the original "programmer" explained with great pride, that they didn't
Quote:
waste their time using long variable names...
Yep! Every single one of them was a single character. Every. Single. One. :mad: (Except where he copied code snippets off the internet)
CHill60 wrote:
waste their time using long variable names
It's likely they spent more time trying to remember and figure out what each single character variable actually was. :doh:
Everyone is born right handed. Only the strongest overcome it. Fight for left-handed rights and hand equality.
-
Hey now, that could actually be a valid check! :laugh:
public class Stringy
{
private string Value { get; set; }public Stringy(string value) { Value = value; } public static implicit operator string(Stringy s) { string value = s.Value; if (s.Value == "4") s.Value = "5"; return value; }}
Which lets you write code like this:
var str = new Stringy("4");
if (str == "4" && str == "5")
Console.WriteLine("LOL");Which will, of course, print LOL to the console. Though I imagine you'd only do something like this if you really, really hate your co-workers.
You are evil... but that's a really good one :laugh: :laugh: :laugh: :laugh: :thumbsup::thumbsup::thumbsup:
M.D.V. ;) If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about? Help me to understand what I'm saying, and I'll explain it better to you Rating helpful answers is nice, but saying thanks can be even nicer.
-
switch (str)
{
case "4":
if (str != "5") ...Ah, the joys of outsourcing with no code reviews.
Latest Article - A Concise Overview of Threads Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802
Aren't you a consultant / contractor? And an experienced one at that? :)
Charlie Gilley <italic>Stuck in a dysfunctional matrix from which I must escape... "Where liberty dwells, there is my country." B. Franklin, 1783 “They who can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety.” BF, 1759
-
The naming of
strbugs me just as much. Ok, I know it's a string. But what is it? Calling it something likeinvoiceTypeCodeindicates it is a string and lets me know what I am looking at.The only thing we know for surte is that it isn't 5.
CQ de W5ALT
Walt Fair, Jr., P. E. Comport Computing Specializing in Technical Engineering Software
-
Good grief. I keep telling my techie wife that soon you'll see critical systems failing left and right that used to work pretty well. Shoot, maybe that's why AI is all the rage today. Were scared of, let's just call em the up and comers.
Yeah, you never know when 4 might turn out to be 5!
CQ de W5ALT
Walt Fair, Jr., P. E. Comport Computing Specializing in Technical Engineering Software
-
It's 3 weeks I am a consultant and I'm seeing sh*t like this way too often. And I am expected to produce the same, since I have to be productive with a 2 weeks training over a medium sized project with no documentation nor coding standard (functions that take 12 arguments named ct, ly, ex, ey, tx, fx and so on...).
GCS d-- s-/++ a- C++++ U+++ P- L+@ E-- W++ N+ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X
Do you get paid by the line of code?
CQ de W5ALT
Walt Fair, Jr., P. E. Comport Computing Specializing in Technical Engineering Software
-
Well, seeing that you do not like switch statements to begin with, they have already failed, throwing the 4 and 5 in is just overkill. :-D BTW, I love how they are checking
strif it is not 5 in a case statement wherestr = 4. Of course it is not 5. :laugh: :laugh: :laugh: :laugh: :laugh: :laugh: :laugh: :laugh: :laugh: Edit: I just realized your title is saying what I just said. :doh: I really need to take a nap. :cool:Slacker007 wrote:
hey are checking
strif it is not 5 in a case statement wherestr = 4. Of course it is not 5.But it might be next week!
CQ de W5ALT
Walt Fair, Jr., P. E. Comport Computing Specializing in Technical Engineering Software
-
Do you get paid by the line of code?
CQ de W5ALT
Walt Fair, Jr., P. E. Comport Computing Specializing in Technical Engineering Software
Sadly not. I would have made a million in the first two weeks and then resigned if that was the case.
GCS d-- s-/++ a- C++++ U+++ P- L+@ E-- W++ N+ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X
-
Did the guy knew about IDEs with auto-complete? I understand the point that even if it takes a fraction of a second longer to type a variable name, it will save you several minutes/hours in the future when you or someone else has to maintain that code. But even that fraction of a second disappears with auto-complete.
Quote:
Did the guy knew about IDEs with auto-complete?
He didn't like auto-complete telling him what to type.
Quote:
it will save you several minutes/hours in the future
He believed that some ephemeral future savings did not outweigh a concrete savings right now! :wtf: And besides, "a real programmer can figure out the code". Extra time to figure things was not important, but the fraction of a second typing time mattered. I believe the saying "Penny wise and Pound foolish" applies. :sigh:
Just because the code works, it doesn't mean that it is good code.
-
switch (str)
{
case "4":
if (str != "5") ...Ah, the joys of outsourcing with no code reviews.
Latest Article - A Concise Overview of Threads Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802
By chance was the case "4" a fall-through from cases above it? Not saying it's good coding practice, but that would sorta make sense then seeing the "if" statement. I hate crap like that.... Currently dealing with 20,000 line files with 5,000 line functions. X| X| :mad: I'm NOT exaggerating.
#SupportHeForShe Government can give you nothing but what it takes from somebody else. A government big enough to give you everything you want is big enough to take everything you've got, including your freedom.-Ezra Taft Benson You must accept 1 of 2 basic premises: Either we are alone in the universe or we are not alone. Either way, the implications are staggering!-Wernher von Braun