How to make thing more complicated for nothing...
-
in the same header file, 5 lines apart.
#define szSTATUS_DONE "D"
#define cSTATUS_DONE 'D'they represent the same status (and values) (yeah, we use type prefix !! :-( )
CI/CD = Continuous Impediment/Continuous Despair
I use my prescient powers to see that you are going through someone else's code base. :laugh:
Mircea
-
I use my prescient powers to see that you are going through someone else's code base. :laugh:
Mircea
yeah! :sigh:
CI/CD = Continuous Impediment/Continuous Despair
-
yeah! :sigh:
CI/CD = Continuous Impediment/Continuous Despair
Trust me, it's much worse when you go through your own's and go: "What was I thinking!" :laugh:
Mircea
-
in the same header file, 5 lines apart.
#define szSTATUS_DONE "D"
#define cSTATUS_DONE 'D'they represent the same status (and values) (yeah, we use type prefix !! :-( )
CI/CD = Continuous Impediment/Continuous Despair
Well, sometimes you are comparing strings and other times you are comparing characters.
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated. I’m begging you for the benefit of everyone, don’t be STUPID.
-
Well, sometimes you are comparing strings and other times you are comparing characters.
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated. I’m begging you for the benefit of everyone, don’t be STUPID.
if only ... both defines are used at max a dozen of times in places where performance is not required.
CI/CD = Continuous Impediment/Continuous Despair
-
in the same header file, 5 lines apart.
#define szSTATUS_DONE "D"
#define cSTATUS_DONE 'D'they represent the same status (and values) (yeah, we use type prefix !! :-( )
CI/CD = Continuous Impediment/Continuous Despair
Job security? Or maybe someone was paid by lines of code? The ‘why’ is almost always inscrutable, but likely the coder slept between sessions. Cleaning someone else’s code is both satisfying and nerve wracking. Good luck. :)
Time is the differentiation of eternity devised by man to measure the passage of human events. - Manly P. Hall Mark Just another cog in the wheel
-
Well, sometimes you are comparing strings and other times you are comparing characters.
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated. I’m begging you for the benefit of everyone, don’t be STUPID.
szSTATUS_DONE [0]?
Paul Sanders. If I had more time, I would have written a shorter letter - Blaise Pascal. Some of my best work is in the undo buffer.
-
Job security? Or maybe someone was paid by lines of code? The ‘why’ is almost always inscrutable, but likely the coder slept between sessions. Cleaning someone else’s code is both satisfying and nerve wracking. Good luck. :)
Time is the differentiation of eternity devised by man to measure the passage of human events. - Manly P. Hall Mark Just another cog in the wheel
The compiler told someone that string -> char was a type mismatch upon comparison so they added the other def and used that one. They did this for type mismatches for other values/variables too, sticking to their pattern. At least, that's my forensic analysis of the crime of a previous coder. A long time ago they were me, so we're intimate acquaintances without their knowing and I feel like I can predict some transgressions because I once made them. It's like catching your kids sneaking out, isn't it? Sleepover at Susie's! psssh...
-
in the same header file, 5 lines apart.
#define szSTATUS_DONE "D"
#define cSTATUS_DONE 'D'they represent the same status (and values) (yeah, we use type prefix !! :-( )
CI/CD = Continuous Impediment/Continuous Despair
-
The compiler told someone that string -> char was a type mismatch upon comparison so they added the other def and used that one. They did this for type mismatches for other values/variables too, sticking to their pattern. At least, that's my forensic analysis of the crime of a previous coder. A long time ago they were me, so we're intimate acquaintances without their knowing and I feel like I can predict some transgressions because I once made them. It's like catching your kids sneaking out, isn't it? Sleepover at Susie's! psssh...
Yep: Empathy and understanding can lead to a more serene life. :omg:
Time is the differentiation of eternity devised by man to measure the passage of human events. - Manly P. Hall Mark Just another cog in the wheel
-
Yep: Empathy and understanding can lead to a more serene life. :omg:
Time is the differentiation of eternity devised by man to measure the passage of human events. - Manly P. Hall Mark Just another cog in the wheel
-
in the same header file, 5 lines apart.
#define szSTATUS_DONE "D"
#define cSTATUS_DONE 'D'they represent the same status (and values) (yeah, we use type prefix !! :-( )
CI/CD = Continuous Impediment/Continuous Despair
-
const char const *szSTATUS_DONE = "D";
const char cSTATUS_DONE = *szSTATUS_DONE;This will make you feel better…
lol. (heart attack)
CI/CD = Continuous Impediment/Continuous Despair
-
in the same header file, 5 lines apart.
#define szSTATUS_DONE "D"
#define cSTATUS_DONE 'D'they represent the same status (and values) (yeah, we use type prefix !! :-( )
CI/CD = Continuous Impediment/Continuous Despair
I frequently define two representations of the same status, error or whatever, although usually an enum and a text string, rather than a char and a text string. From the old days, I like switch()-ing on scalars, not on strings or whatever. Besides, the switch variable is language independent, while the text string is language dependent. The question is whether the two representations should be kept together, which may seem like a good idea for maintenance purposes. Then you must keep all the language variants of the string in the same place, and they must have different names. Or you separate them, which makes maintenance more difficult, but you can keep all the Norwegian strings together, the German strings together and so on. Maybe they are even referenced by the same name. Then, if you add another status/error/... code, you have to look up all the different places where strings are defined, to make sure that you have a string version in all supported languages. Usually that is not a issue to consider in USA software: Who would ever want any other language than English?
-
Yeah I don't intend to be ugly about it. What else is everyone in the raft supposed to do when someone says they'll prioritize themselves ahead as much as they want to everyone else's detriment?
jochance wrote:
What else is everyone in the raft supposed to do when someone says they'll prioritize themselves ahead as much as they want to everyone else's detriment?
The rest of the survivors eat them first? :)
Freedom is the freedom to say that two plus two make four. If that is granted, all else follows. -- 6079 Smith W.
-
in the same header file, 5 lines apart.
#define szSTATUS_DONE "D"
#define cSTATUS_DONE 'D'they represent the same status (and values) (yeah, we use type prefix !! :-( )
CI/CD = Continuous Impediment/Continuous Despair
-
in the same header file, 5 lines apart.
#define szSTATUS_DONE "D"
#define cSTATUS_DONE 'D'they represent the same status (and values) (yeah, we use type prefix !! :-( )
CI/CD = Continuous Impediment/Continuous Despair
Maximilien wrote:
they represent the same status (and values)
They may represent the same status but they certainly don't represent the same values. One is a string while the other is a character. /ravi
My new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com
-
Maximilien wrote:
they represent the same status (and values)
They may represent the same status but they certainly don't represent the same values. One is a string while the other is a character. /ravi
My new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com
obviously. :-\
CI/CD = Continuous Impediment/Continuous Despair
-
in the same header file, 5 lines apart.
#define szSTATUS_DONE "D"
#define cSTATUS_DONE 'D'they represent the same status (and values) (yeah, we use type prefix !! :-( )
CI/CD = Continuous Impediment/Continuous Despair
-
I had to work on a code base with a static code checker enforcement. And if you used a 'constant' more than twice it would flag it. Static code checkers are absolutely worthless.
jschell wrote:
Static code checkers are absolutely worthless.
You must have encountered an (or several) really bad code checkers. Some of them are really good. On the other hand: The good ones are far from cheap. You get what you pay for. Also, all the ones I have been in touch with, from the very top down to simple lint, has provided mechanisms for suppressing reports on each specific 'defect'. I see no viable justification for treating >2 uses of constant as a defect, so I would disable that test immediately.
Religious freedom is the freedom to say that two plus two make five.