Nitpicking at code reviews is bad for everyone
-
Shouldn't code reviews be about unobvious mistakes (with the obvious ones already fixed.)
-
Shouldn't code reviews be about unobvious mistakes (with the obvious ones already fixed.)
Yes. But some people are zealots about style and "my way or the highway"
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated. I’m begging you for the benefit of everyone, don’t be STUPID.
-
Yes. But some people are zealots about style and "my way or the highway"
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated. I’m begging you for the benefit of everyone, don’t be STUPID.
Define zealot. Calling out someone on bad formatting or style is valid. For example, if the dev used a style different from the project or used terrible names. Part of the review has to consider future maintainability.
-
I already have linters with MISRA rules to nitpick at me :D
GCS/GE d--(d) s-/+ a C+++ U+++ P-- L+@ E-- W+++ N+ o+ K- w+++ O? M-- V? PS+ PE Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- r+++ y+++* Weapons extension: ma- k++ F+2 X The shortest horror story: On Error Resume Next
-
The original purpose of a code review was to fix issues that make future development on the same code more difficult than it needs to be. It's not a QA session to find bugs (so saying that the code works fine is an irrelevant defense). His colleagues are perfectly justified for complaining about style, and he should fix those issues. If there are debates on proper style, then an official style guide needs to be put together to resolve the debates.