Error while insert DB

[Ronen Kfir]

I'm trying to open a user with insert SQL query to Access. This is the statements: string sqlCreateNewUser = "INSERT INTO usersTbl ( UserName, Password) " + "VALUES (" + username.UserName+ ", " + username.Password + ")"; Think the eror derived from the class I wrote to user. This is the class: public class user { private string username; private long password; public user(string username, long password) { this.username = username; this.password = password; } /// /// Gets, Sets username. /// public string UserName { get { return this.username; } set { this.username = value; } } /// /// Gets password. /// public long Password { get { return this.password; } set { this.password = value; } } } Please help me find the false. BTW: sorry I don’t use indentation. Just couldn’t understand the tags system here... Where would I find some info on it? TIA, Ronen

[Guffa]

Standard question #2: What error message do you get? --- b { font-weight: normal; }

[Rob Graham]

You need to enclose your values in single quotes:

... "VALUES ('" + username.UserName+ "','" + username.Password + "')";

note the extra single quotes I have added. A better way to do this would be to use parameters and a stored procedure (querydef in access lingo), then you wouldn't have to worry with things like the single quotes (which will need to be doubled up if they are part of a name - O'Neill - becomes O''Neill - in order to work). If you use a strored procedure with parameters, you won't have to worry about escaping the embedded single quote. Absolute faith corrupts as absolutely as absolute power Eric Hoffer The opposite of the religious fanatic is not the fanatical atheist but the gentle cynic who cares not whether there is a god or not. Eric Hoffer

[Ronen Kfir]

The Error I get is: "Syntax error in INSERT INTO statement" Tried it with the extra quotes, with no use. I would rather do it this way at this stage. I think the syntax is OK (?) What do you think of the user class I wrote?

[Guffa]

Username or password might be reserved words, depending on what connection you use. Put brackets around them: [username], [password] --- b { font-weight: normal; }

[sea]

The problem was with Password as a reserved word. once put it brackets around it- solved. cheers! Ronen